tomhughes left a comment (openstreetmap/openstreetmap-website#6412)
I think this is probably good to merge now - thanks for all the work.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6412#issuecomment-3335223767
You are receivi
@tomhughes pushed 1 commit.
2acbe6c726df070957220474bd29fe8605a6e0f9 Lock changesets during a diff upload
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6379/files/3e211c441a066d8c266cf07d4c08655b4ea42beb..2acbe6c726df070957220474bd29fe8605a6e0f9
You are recei
tomhughes left a comment (openstreetmap/openstreetmap-website#6379)
I've added a test though I'm having trouble getting it to fail with the old
code in the controller - possibly my machine is also too fast ;-)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
Merged #6412 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6412#event-19925687185
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6412)
This is looking very good now - the only thing I've noticed is that sometimes
(but not always) on first view the `shown.bs.modal` event can fire before the
turbo frame has finished loading meaning that it doesn't find the elemen
@tomhughes pushed 1 commit.
b50105d49df0fc541a3255b4fca821f3300696d9 Update num_changes when backfilling
changesets
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6361/files/b2d116ffc2c073c5b6e0160ffce7ac297fa19854..b50105d49df0fc541a3255b4fca821f3300696d9
Yo
Merged #6418 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6418#event-19897920641
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 1 commit.
3e211c441a066d8c266cf07d4c08655b4ea42beb Lock changesets during a diff upload
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6379/files/4484ae647465f94c252bdaf0db97293375a02e4c..3e211c441a066d8c266cf07d4c08655b4ea42beb
You are recei
tomhughes left a comment (openstreetmap/openstreetmap-website#6418)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6418#issuecomment-3329929609
You are receiving this because you are subscribed to this t
@tomhughes pushed 1 commit.
c4a6fd13398bbdbd4c86a9c13e80a5e05695cbd4 Render marker symbols for the embed
view unconditionally
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6404/files/ffe0cc73152e2e74012e0effb7c799a8cde46e3d..c4a6fd13398bbdbd4c86a9c13e80a5e05
tomhughes left a comment (openstreetmap/openstreetmap-website#6404)
I can't reproduce it now either, but I think I know what's really going on.
That view is cached in production, but it not does different things depending
on whether `params[:marker]` is set when the request is made, so for each
Merged #6413 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6413#event-19872291920
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This updates to rails 8.0.3 including working around a new bug in the mime type
detection code.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6416
-- Commit Summary --
* Update rails to 8.0.3
* Fix identificatio
Merged #6417 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6417#event-19874761075
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6417)
The seven days isn't actually part of the OWG policy but something that is just
in the FAQ here which is a bit odd... It's probably better read as that we
can't guarantee to merge and deploy things immediately.
So I say set it
tomhughes left a comment (openstreetmap/openstreetmap-website#6417)
Banners can have overlapping dates if you want - any banners that haven't been
dismissed yet will be shown in turn in that case.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
@tomhughes commented on this pull request.
> @@ -4,6 +4,9 @@
@import "rails_bootstrap_forms";
@import "colors";
+$bootstrap-icons-font-dir: "bootstrap-icons/font/fonts";
+@import "bootstrap-icons/font/bootstrap-icons";
I thought a lot of the icons in `app/assets/images/icons` came from the
@tomhughes commented on this pull request.
I think the structure of the commits here is wrong - rather than removing the
old assets and commenting out the code in the first commit and then rewriting
things and re-enabling the code in the second I would reverse things and have
the first commit r
Merged #6408 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6408#event-19846789542
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #6287 as completed via #6408.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6287#event-19846790100
You are receiving this because you are subscribed to this thread.
Message ID:
_
tomhughes left a comment (openstreetmap/openstreetmap-website#6408)
I don't really like doing this sort of thing, especially where there seems
little chance of it being temporary, but I guess we don't have any better
options.
We probably need to be considering if there's some way we can replace
@tomhughes pushed 1 commit.
387cea0f19fdc2c453063a678e995deea38d16e9 Add support for OpenTelemetry
reporting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6405/files/be91ddc7295fa69bb5c6bfc924317f5af328d94a..387cea0f19fdc2c453063a678e995deea38d16e9
You are r
tomhughes left a comment (openstreetmap/openstreetmap-website#2344)
Well I thought devcontainer was something on top of docker which is why I
suggested what I did.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2344#issuecomme
tomhughes left a comment (openstreetmap/openstreetmap-website#2344)
I'm not sure vagrant has ever got much use and I'm pretty sure that these days
if people try to use something then it's docker.
I don't really like the docker setup myself because it doesn't seem to me like
a good fit for devel
tomhughes left a comment (openstreetmap/openstreetmap-website#6407)
This is why we shouldn't try and linkify things - there's simply no way we can
ever guess correctly what people mean when they can enter any old nonsense.
In this case we interpret whatever is entered there as a link, and a link
tomhughes left a comment (openstreetmap/openstreetmap-website#6406)
Why do you think it's a related to a ticket that was closed with no action
taken?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6406#issuecomment-3316208380
This will be necessary for
https://github.com/openstreetmap/operations/issues/1284 to allow OpenTelemetry
data collection.
Note that it does nothing unless an exporter is configured in the environment.
You can view, comment on, or merge this pull request online at:
https://github.com/openstre
Having the markers inside the map div means they get destroyed when the map is
created.
Fixes #6045.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6404
-- Commit Summary --
* Move markers out of the map div for t
tomhughes left a comment (openstreetmap/openstreetmap-website#6400)
> leaflet-osm might have [other
> clients](https://github.com/openstreetmap/leaflet-osm/network/dependents)
> besides osm-website that are less mapper-focused. If the arrows would be
> distracting for laypeople, maybe it could
@tomhughes commented on this pull request.
As `leaflet.arrowheads` is on NPM it would be better to add it to
`package.json` rather than vendoring it - that will also pull in
`leaflet.geometryutils` as NPM has a dependency there.
--
Reply to this email directly or view it on GitHub:
https://g
Merged #6398 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6398#event-19811219406
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6403 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6403#event-19811219410
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6402 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6402#event-19811219425
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #6401 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6401#event-19811219415
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6397)
Well that just means somebody has put bad data in the database so feel free to
fix it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6397#issuecomment-330655
tomhughes left a comment (openstreetmap/openstreetmap-website#6387)
I have pointed you at that twice before in #6282 and #6311 so please do read it
- we don't use assignment in this repository.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
Merged #6396 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6396#event-19781049476
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Reopened #6397.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6397#event-19777616155
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
tomhughes left a comment (openstreetmap/openstreetmap-website#6397)
Oh I see you've tried to put a semicolon separated list of values but we're
treating it as a single value? Has that ever worked?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
tomhughes left a comment (openstreetmap/openstreetmap-website#6397)
I thought you were complaining about the broken link?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6397#issuecomment-3307852137
You are receiving this becaus
Closed #6397 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6397#event-19770732356
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
tomhughes left a comment (openstreetmap/openstreetmap-website#6393)
There was no "mistake" here, just a merge conflict. It's completely normal for
the person merging to fix those as part of the merge and the merge commit
(where the fix is) will already be attributed to the person doing the merge
tomhughes left a comment (openstreetmap/openstreetmap-website#6393)
You don't actually have to create a remote you can just do `git push -f
:`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6393#issuecomment-3303967319
You are
@tomhughes pushed 1 commit.
4484ae647465f94c252bdaf0db97293375a02e4c Lock changesets during a diff upload
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6379/files/020b603dd15ee7480c858be35d334f3ff2560d75..4484ae647465f94c252bdaf0db97293375a02e4c
You are recei
@tomhughes pushed 1 commit.
b2d116ffc2c073c5b6e0160ffce7ac297fa19854 Update num_changes when backfilling
changesets
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6361/files/c7355069c8fb3654b557dfc071fb0032e09020a3..b2d116ffc2c073c5b6e0160ffce7ac297fa19854
Yo
tomhughes left a comment (openstreetmap/openstreetmap-website#6393)
Updated... Generally fixing `Gemfile.lock` conflicts just means deleting the
conflicts and running `bundle install` to fix things I think?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/o
@tomhughes pushed 1 commit.
da0cd4e71c71ec0a5d2e86e1c5c06c5b4edbca39 Remove logstash support
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6393/files/761dbb512f66fd8b5a89b079eaac2b8996454b46..da0cd4e71c71ec0a5d2e86e1c5c06c5b4edbca39
You are receiving this bec
tomhughes left a comment (openstreetmap/openstreetmap-website#6392)
We like to record all merges so we don't normally use rebase type merges that
lead to a fast forward - in fact I normally do all my merges offline and not
using the github UI at all.
Also in this case the commit message really
Merged #6392 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6392#event-19707805569
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#6392)
Thanks - can you squash that fix into the original commit please and then we
can merge this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6392#issuecomment-32
This is no longer used in production...
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6393
-- Commit Summary --
* Remove logstash support
-- File Changes --
M Gemfile (3)
M Gemfile.lock (6)
M config/a
tomhughes left a comment (openstreetmap/openstreetmap-website#6392)
The reason for abbreviation will probably be to avoid the name being too long
which in turn causes problems with the multi-column formatting of the language
selector.
--
Reply to this email directly or view it on GitHub:
https