Re: [Rdkit-discuss] SMARTS/SMARTS and SMILES/SMARTS substructure matching

2014-03-05 Thread Greg Landrum
On Wed, Mar 5, 2014 at 4:03 PM, Toby Wright wrote: > > This is probably related to the above so I thought I'd post it on this > thread. I am noticing inconsistent behaviour when a molecule created via > SMARTS that contains an 'or' statement has HasSubstructMatch called on it, > as opposed to it

Re: [Rdkit-discuss] Pg cartridge - mol_to_ctab() and trouble with conformers.

2014-03-05 Thread Greg Landrum
Thanks Jan. The fix and pull request have both been integrated. -greg On Wed, Mar 5, 2014 at 7:35 PM, Jan Holst Jensen wrote: > Hi Greg, > > Thanks for the explanation. > > I added this to rdkit_io.c in mol_from_ctab(): > > + bool keepConformer = PG_GETARG_BOOL(1); > - mol = parseMolCTAB(da

Re: [Rdkit-discuss] Pg cartridge - mol_to_ctab() and trouble with conformers.

2014-03-05 Thread Jan Holst Jensen
Hi Greg, Thanks for the explanation. I added this to rdkit_io.c in mol_from_ctab(): + bool keepConformer = PG_GETARG_BOOL(1); - mol = parseMolCTAB(data,false,true); + mol = parseMolCTAB(data,keepConformer,true); and then I can get the expected behavior and have my tests complete successful

Re: [Rdkit-discuss] SMARTS/SMARTS and SMILES/SMARTS substructure matching

2014-03-05 Thread Toby Wright
Hi, This is probably related to the above so I thought I'd post it on this thread. I am noticing inconsistent behaviour when a molecule created via SMARTS that contains an 'or' statement has HasSubstructMatch called on it, as opposed to it being the argument to HasSubstructMatch. A simple example

Re: [Rdkit-discuss] Pg cartridge - mol_to_ctab() and trouble with conformers.

2014-03-05 Thread Greg Landrum
Hi Jan, The below behavior is the result of a bug ( https://github.com/rdkit/rdkit/issues/229). mol_from_ctab() takes an (undocumented) optional argument that is supposed to determine whether or not the molecule's conformation is stored in the database. The default is to not store the conformation

Re: [Rdkit-discuss] Two nitrogens in a 5 membered ring

2014-03-05 Thread Toby Wright
Thanks all for informative and helpful responses, the behaviour I was struggling to understand now makes perfect sense. Toby Wright -- InhibOx Ltd On 4 March 2014 04:06, Greg Landrum wrote: > Bob hit the nail on the head. > > The first case, "N1N=CC=C1", is aromatic because the RDKit sees tha

Re: [Rdkit-discuss] SMARTS/SMARTS and SMILES/SMARTS substructure matching

2014-03-05 Thread Christos Kannas
Hi Greg, Thanks a lot for the explanation. It makes things clearer now. Well the reason I'm doing SMARTS-SMARTS match is because I would like to match functional groups with the reactants in reactions. Regards, Christos Christos Kannas Researcher Ph.D Student Mob (UK): +44 (0) 7447700937 Mob

[Rdkit-discuss] Pg cartridge - mol_to_ctab() and trouble with conformers.

2014-03-05 Thread Jan Holst Jensen
Hi, About ready to push a changeset for implementing mol_to_ctab(), but I would like it to play nice and preserve input depictions. Ideally I would like the following select mol_to_ctab(mol_from_ctab()); to output a molfile where the coordinates of "input-molfile" are preserved. If I do

Re: [Rdkit-discuss] Building RDKit on Windows

2014-03-05 Thread Greg Landrum
On Wednesday, March 5, 2014, James Davidson wrote: > Thanks Greg - that did the trick! > (I still see pythonTestDbCLI - as previously posted) Those problems are due to windows not being able to delete files that it has just closed. I need to put the deletion bit in a try..except block. The fail

Re: [Rdkit-discuss] Building RDKit on Windows

2014-03-05 Thread James Davidson
Thanks Greg - that did the trick! (I still see pythonTestDbCLI - as previously posted) Kind regards James __ PLEASE READ: This email is confidential and may be privileged. It is intended for the named addressee(s) only and acce