Re: verbose BUG_ON reporting

2005-06-27 Thread Pekka J Enberg
Andi Kleen writes: It's still useless - it is too bloated to turn on by default and then if you need it you still won't have it. And when you explicitely turn it on then you likely don't need it because you control the source. Hmm. Would a BUG_ON_WITH_TEXT be a better solution? The home-grown

[PATCH] verbose BUG_ON reporting

2005-06-27 Thread Pekka J Enberg
On Mon, 27 Jun 2005, Andi Kleen wrote: > It won't work for me because it'll bloat the kernel .text > considerable. There is a reason why BUG is implemented > like it is. Compare it. The assertion codes bloat the kernel all the same. So how about this instead? This patch adds a CONFIG_DEBUG_BUG_O

Re: -mm -> 2.6.13 merge status

2005-06-27 Thread Pekka J Enberg
On Mon, 2005-06-27 at 09:28 +0200, Andi Kleen wrote: > You can just dump the expression (with #argument). That is what > traditional userspace assert did forever. > > It won't help for BUG_ON(a || b || c || d || e) but these > are bad style anyways and should be avoided. Sounds good to me. Jens,

Re: -mm -> 2.6.13 merge status

2005-06-23 Thread Pekka J Enberg
Hi Hans, On Thu, 2005-06-23 at 00:42 -0700, Hans Reiser wrote: > These assertion codes are meaningless to the rest of us so please drop > them. I think you don't appreciate the role of assertions in making code easier to audit and debug. I did not say you should drop the assertions. I refe