Hi, > On mercredi 6 mars 2019 13:31:13 CET Andreas Sturmlechner wrote: >> On Sat, 2 Mar 2019 at 16:48, David Faure <fa...@kde.org> wrote: >> > Dear packagers, >> > >> > KDE Frameworks 5.56.0 has been uploaded to the usual place. >> >> syntax-highlighting should be respun to include commit 84d78a05 >> ("guard target link libraries for older CMake version") > > OK, done. > > syntax-highlighting v5.56.0-rc2 > 0ec4b4c84c2ed04b3eda629ec0386f74f74c3355 > 700439e5052e4fd6b681b8cff177b39e92edb418f055c31a91700ebf58b3d956 > sources/syntax-highlighting-5.56.0.tar.xz > > It's surprising to me that with older cmake we just skip linking to something > (one would think it leads to undefined symbols), but I just tested compilation > with > cmake 3.10 and it worked. The linking is only needed to get the right includes/defines for the namespaced compilation, otherwise this is a nop for that object lib.
Unfortunately my fix was not good enough, see: https://phabricator.kde.org/D19581 Greetings Christoph > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE Frameworks 5 -- ----------------------------- Dr.-Ing. Christoph Cullmann --------- AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANY WWW: http://www.AbsInt.com -------------------------------------------------------------------- Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234