Re: [Replicant] [PATCH v2] Add native Android support for external WiFi dongles

2019-10-12 Thread Denis 'GNUtoo' Carikli
On Sat, 12 Oct 2019 05:02:22 + Belgin ?tirbu wrote: > With this patch, if the nonfree firmware is found, the internal WiFi > is used, otherwise the WiFi state machine tries to use the external > WiFi adapter. Sorry, I forgot to do the research for the bluetooth coexistance, so I did it now.

[Replicant] [PATCH v2] Hide information leaking phone number lookup settings

2019-10-12 Thread Joonas Kylmälä
The phone number lookup service leaks private information so hide the option to enable it. The lookup service is by default disabled so this guarantees no information gets leaked if the user would accidentally enable the service. Signed-off-by: Joonas Kylmälä ---

Re: [Replicant] [PATCH v3] Add native Android support for external WiFi dongles

2019-10-12 Thread Joonas Kylmälä
Hi, removing the multicast packet filtering is not ideal but I checked the RepWifi code and it doesn't seem to be setting any packet filters either so that seems to be a separate problem to be solved. Otherwise the patch seems okay and I have tested it works: Acked-by: Joonas Kylmälä Thanks a

[Replicant] [PATCH v3] Add native Android support for external WiFi dongles

2019-10-12 Thread Belgin ?tirbu
With this patch, if the nonfree firmware is found, the internal WiFi is used, otherwise the WiFi state machine tries to use the external WiFi adapter. Because the WiFiStateMachine tries to do things with the Bluetooth Coexistence mode, which the ath9k driver doesn't seem to have (at least not by

Re: [Replicant] [PATCH v2] Add native Android support for external WiFi dongles

2019-10-12 Thread Joonas Kylmälä
Hi, I'm a bit worried about removing the code about multicast packet filtering. Would this have some sort of effect on the firewall configuration? You also dropped the signed-off-by line and the description why bluetooth and the packet filter needs to be removed, please add those back for v3.