Re: [Replicant] [PATCH] Fixed incorrect parsing of TLV data

2020-01-03 Thread Denis 'GNUtoo' Carikli
On Fri, 3 Jan 2020 22:23:34 +0100 Denis 'GNUtoo' Carikli wrote: > On Fri, 3 Jan 2020 06:50:40 + > Belgin ?tirbu wrote: > > > This problem prevented the SIM to be fully recognized and only > > incoming calls/messages worked. I've also pushed the patch. Thanks a lot for the fix!!! Denis.

Re: [Replicant] [PATCH] Fixed incorrect parsing of TLV data

2020-01-03 Thread Denis 'GNUtoo' Carikli
On Fri, 3 Jan 2020 06:50:40 + Belgin ?tirbu wrote: > This problem prevented the SIM to be fully recognized and only > incoming calls/messages worked. > > The issue is the code assumes tag 0x88 exists, and then assumes that > the TLV right before it is the size tag. These two assumptions are

[Replicant] [PATCH] Fixed incorrect parsing of TLV data

2020-01-02 Thread Belgin ?tirbu
This problem prevented the SIM to be fully recognized and only incoming calls/messages worked. The issue is the code assumes tag 0x88 exists, and then assumes that the TLV right before it is the size tag. These two assumptions are sometimes wrong. The solution is to send the data as-is to the