[Reportbug-maint] Bug#892898: reportbug crashes due with UnicodeDecodeError

2018-03-17 Thread Nis Martensen
control: tags -1 patch Thank you for the report. This should fix the crash: https://salsa.debian.org/reportbug-team/reportbug/merge_requests/2 I could not reproduce the problem, though. What does DEBCONF_SYSTEMRC=1 DEBCONF_NOWARNINGS=yes debconf-show console-setup output on your system? Is the o

[Reportbug-maint] Bug#878088: Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-02-26 Thread Nis Martensen
Thanks Sandro! One thing is missing, though: we now need a dependency on python3-apt. ___ Reportbug-maint mailing list Reportbug-maint@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reportbug-maint

[Reportbug-maint] Bug#890680: Bug#890680: reportbug: python3-reportbug submodules are not well documented

2018-02-21 Thread Nis Martensen
On 20-02-2018 06:02, Sandro Tosi wrote: > On Sun, Feb 18, 2018 at 5:03 AM, Nis Martensen wrote: >> Extending the test suite is actually the goal here. It's just hard to >> add tests for functions of which you don't know what they're supposed to >> do exactly.

[Reportbug-maint] Bug#890680: Bug#890680: reportbug: python3-reportbug submodules are not well documented

2018-02-18 Thread Nis Martensen
Hey Sandro! On 18-02-2018 05:49, Sandro Tosi wrote: > Hey Nis! > >> The reportbug source code has some issues that make it hard to review: > > > thanks for working on this! even if i dont want to mess with your > plans, let me tell you that if you really want to work on this "qa" > kind-of acti

[Reportbug-maint] Bug#890680: reportbug: python3-reportbug submodules are not well documented

2018-02-17 Thread Nis Martensen
Package: reportbug Version: 7.1.8 Severity: wishlist The reportbug source code has some issues that make it hard to review: - Most functions in reportbug/*.py do not have a docstring, or only a very brief one. Some functions still have many parameters, and some return quite complex objects

[Reportbug-maint] Bug#853915: Bugreports and base64

2018-01-31 Thread Nis Martensen
control: clone 853915 -1 control: reassign 853915 python-debianbts control: retitle -1 reportbug: base64 encoded reports rejected by bts Reading and sending base64 message are two different bugs, so let's split this report. I believe that python-debianbts is supposed to decode a base64 message bo

[Reportbug-maint] Bug#878088: Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-29 Thread Nis Martensen
On 29-01-2018 00:11, Markus Koschany wrote: > > I noticed that you had to import apt but reportbug does not depend on > python3-apt. After I had installed this package it worked. I also > believe you don't need to check for the upstream changelog.gz file, the > Debian changelog should be sufficien

[Reportbug-maint] Bug#878088: Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-27 Thread Nis Martensen
ice mode? Should reportbug incorporate a default version of the json file to fall back to if the lookup fails? Reportbug is probably going to be updated more often than the online version of the json file. An internal version could also be updated regularly. >From 56d6dbffd3075bb9f06aa1b31fd8f688b

[Reportbug-maint] Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-24 Thread Nis Martensen
On 24-01-2018 19:37, Markus Koschany wrote: > Thanks. How do you catch the case when security updates are part of a > stable point release? This requires more effort. Does the package tracker offer a way to query such information? The only other idea I have right now involves inspecting the late

[Reportbug-maint] Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-24 Thread Nis Martensen
How about this? import apt def is_security_update(pkgname, version): try: p = apt.Cache()[pkgname] except: return False if version not in p.versions: return False if 'Debian-Security' in [o.label for o in p.versions[version].origins]:

[Reportbug-maint] Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-24 Thread Nis Martensen
Let me describe my suggestion in more detail: - Instead of having the "is this a security version" check implemented directly in bin/reportbug as a version number check, there could be a new function "is_security_update(package, version)" in reportbug/utils.py. You can move the version number che

[Reportbug-maint] Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-23 Thread Nis Martensen
2018-01-23 15:58 GMT+01:00 Sandro Tosi : > point releases usually include all the security updates from the > previous point release, so they would come from the "main" repo and > not the security one That would only be a problem if they are then no longer available via the security update channel

[Reportbug-maint] Bug#878088: reportbug: please inform security and lts teams about security update regressions

2018-01-23 Thread Nis Martensen
It might be possible to determine whether an installed package is a security update by inspecting the output of apt-cache policy pkgname. Not sure if this information can also be obtained used python3-apt. ___ Reportbug-maint mailing list Reportbug-maint

[Reportbug-maint] Bug#539737: reportbug: RFC-1522-encoded headers for mutt

2018-01-21 Thread Nis Martensen
On 3 Aug 2009 Jakub Wilk wrote: > Package: reportbug > Version: 4.5 > Severity: normal > > reportbug encodes non-ASCII headers as per RFC 1522. However, `mutt -H` > does not expect headers to be encoded in such a way. This seems to have been fixed on the mutt side. At least I am unable to repro

[Reportbug-maint] Bug#577278: reportbug: Attach options (-A) is not safe for UTF-8 content

2018-01-21 Thread Nis Martensen
On 11 Apr 2010 Jari Aalto wrote: > Package: reportbug > Version: 4.11 > Severity: normal > > > Using the -A optiontion to attach and UTF-8 patch seems to have problems. This seems to have been fixed in the meantime, probably when reportbug was ported to python3. ___

[Reportbug-maint] Bug#507600: bug script not ready for scripts

2018-01-21 Thread Nis Martensen
On Wed, 03 Dec 2008 05:03:58 +0800 jida...@jidanni.org wrote: > Package: apt > Version: 0.7.19+b1 > File: /usr/share/bug/apt/script > > Your script never expected stdin to be closed. > I.e., one cannot use reportbug --template in a script then. E.g., > $ echo reportbug --template -f /usr/share/bug

[Reportbug-maint] Bug#857810: reportbug: crashes if $HOME does not exist, bugreport is lost

2018-01-21 Thread Nis Martensen
On 15 Mar 2017 Thorsten Glaser wrote: > Package: reportbug > Version: 6.6.3 > Severity: important > > I just reported a bug in a cowbuilder chroot, so $HOME pointed to > a nonexistent directory. What I got was this: > > File /tmp/reportbug-node-uglify-20170315-25826-NfKllD saved. > Report will be

[Reportbug-maint] Bug#885959: reportbug: marks mime type of attachments as inode/symlink

2018-01-01 Thread Nis Martensen
control: tags -1 patch Thanks for the report! >From 77087cf7a1b16d0be199c301ece62f04f06d5b6f Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Mon, 1 Jan 2018 11:28:25 +0100 Subject: [PATCH] submit.py: dereference symbolic links when detecting file type --- reportbug/submit.py | 2 +-

[Reportbug-maint] Bug#883577: Bug#883577: locales not installed

2017-12-29 Thread Nis Martensen
On 29-12-2017 01:27, Sandro Tosi wrote: > On Wed, Dec 6, 2017 at 12:48 PM, Nis Martensen wrote: >>> Does reportbug depend on locales being installed or something related? >> >> No, strictly speaking not. In practice, however, often yes. > > Nis, what do you thin

[Reportbug-maint] Bug#868155: reportbug: no input line after pager

2017-12-09 Thread Nis Martensen
> Run “reportbug --offline reportbug” on a terminal with 33 lines. > Exit the pager with “q” then wonder. > > Pressing ^L shows the input line, with no introduction. > > This only happens for packages that cause a pager to show > something before the input fields. Cannot reproduce here. Can you

[Reportbug-maint] Bug#877650: reportbug: crashes when maintainer's name contains incompatible character

2017-12-08 Thread Nis Martensen
atch. It applies on top of the patch that I sent to #695887. Besides #877650, it should also fix #868022 and #883577. >From c238cf242a8713ccd8bd9a36319e1bd1d8c72bb6 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Tue, 5 Dec 2017 21:40:03 +0100 Subject: [PATCH 2/2] Prevent Unicode(De|En)codeErr

[Reportbug-maint] Bug#883577: locales not installed

2017-12-06 Thread Nis Martensen
> Does reportbug depend on locales being installed or something related? No, strictly speaking not. In practice, however, often yes. One can set the default system locale to "C.UTF-8" (variable LANG in /etc/default/locale) if having locales installed is not desired. Thanks for the very detailed

[Reportbug-maint] Bug#877650: reportbug: crashes when maintainer's name contains incompatible character

2017-12-05 Thread Nis Martensen
Thanks for your report! On 03 Oct 2017 Eckhard Neber wrote: > Detected character set: UTF-8 Your system is set up to use UTF-8 (good). > File "/usr/lib/python3/dist-packages/reportbug/utils.py", line 728, in > get_changed_config_files > for line in fp: > File "/usr/lib/python3.5/codecs.

[Reportbug-maint] Bug#695887: reportbug locks terminal, refuses echo, requires "reset" after viewing followup

2017-12-04 Thread Nis Martensen
control: forcemerge 695887 849763 882983 control: tags -1 patch These bugs are caused by file descriptors not being closed properly. The attached patch should help. >From 1dbc071c3b966f4fb351948412ffe438de11e62f Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Mon, 4 Dec 2017 21:33:15 +0

[Reportbug-maint] Bug#564112: use python-apt to look up package short descriptions

2017-12-04 Thread Nis Martensen
control: tags -1 patch This also fixes #876373 Other related bugs: #502860, #599290, #882130 >From 4612729648fd17955e80a250baca120ce9747251 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Mon, 4 Dec 2017 13:39:38 +0100 Subject: [PATCH] Look up short package descriptions using python3-

[Reportbug-maint] Bug#851502: Still see this bug

2017-09-18 Thread Nis Martensen
control: tags 851502 unreproducible moreinfo > I would like to request severity raised to serious. Michael, it seems not many people can actually reproduce the bug. I've tried on stretch and current sid, and reportbug works just fine for me. Sandro has already pointed out that reportbug requires

[Reportbug-maint] Bug#868154: reportbug: displays MIME type of attachment

2017-09-09 Thread Nis Martensen
>From bf3724a200d9db947c77c1d9ce0eb61536a0bade Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Sat, 9 Sep 2017 23:41:48 +0200 Subject: [PATCH 3/3] Drop leftover debug print() --- reportbug/submit.py | 1 - 1 file changed, 1 deletion(-) diff --git a/reportbug/submit.py b/reportbug/submit.py inde

[Reportbug-maint] Bug#849765: Bug#849765: reportbug: produces invalid mails when there are long lines

2017-09-07 Thread Nis Martensen
bytes. Here is a patch that fixes the problem in reportbug. >From d32fb670bcdf622b9e2b3d45e88abd8cf0e2d711 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Thu, 7 Sep 2017 18:17:00 +0200 Subject: [PATCH 2/2] Use quoted-printable encoding for too long lines --- report

[Reportbug-maint] Bug#872780: reportbug: When filing ITP report and realname has UTF-8 character, the name will be encoded in RFC2047, which it shouldn't

2017-09-05 Thread Nis Martensen
469ec02f1bfb5c25fa33b78744cc2 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Tue, 5 Sep 2017 22:13:14 +0200 Subject: [PATCH] Do not RFC2047-encode Owner pseudo header --- reportbug/debbugs.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reportbug/debbugs.py b/repor

[Reportbug-maint] Bug#866596: querybts: launch_mbox_reader() strips NL characters

2017-06-30 Thread Nis Martensen
h attached. >From 7b0f010797dc8ad52838604bb9eb3de9e3f5d9a3 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Fri, 30 Jun 2017 23:19:32 +0200 Subject: [PATCH] Add line endings when processing strings line by line Bug introduced in d7e9eb8cc5d2efa4543bd35a806cbc36d7419e5e --- reportbug/debbugs.py | 4 ++-- reportbug/

[Reportbug-maint] Bug#862152: crash when $DISPLAY is defined

2017-05-29 Thread Nis Martensen
On 29-05-2017 21:58, Erwan David wrote: > X display is remote (on a mac in my case, but remote). Direct access to > driver is thus not possible. If you do X remote display (which ssh is capable of doing), then something must communicate with some driver. Is any of your local machine or the remote

[Reportbug-maint] Bug#863322: reportbug: Wrong subject and package description while filling a WNPP RFA

2017-05-28 Thread Nis Martensen
One more patch on top, with some improvements. >From 1e965eb715d80dd07f4b930db0e22a8011c03bae Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Sun, 28 May 2017 13:07:25 +0200 Subject: [PATCH 3/3] utils.py: Do not use localized package description .. and unify the regexps used for getting

[Reportbug-maint] Bug#861153: Bug#861153: reportbug: Architecture field split into two lines

2017-05-28 Thread Nis Martensen
Hey Sandro! > should we revert to the previous behavior of get_command_output before > introducing other regressions? Having re-read the code again, I can't see any risk of introducing other regressions. Only lsb_release_info() and get_arch() directly return the result of get_command_output(), a

[Reportbug-maint] Bug#863322: reportbug: Wrong subject and package description while filling a WNPP RFA

2017-05-27 Thread Nis Martensen
sing > "Description-md5" instead the short description) and the description > itself is using text from tags. Thank you for the report. Attaching two patches. Both together should fix this. >From 924f153462f456840211ee6ba852a041156ffe02 Mon Sep 17 00:00:00 2

[Reportbug-maint] Bug#861153: reportbug: Architecture field split into two lines

2017-04-25 Thread Nis Martensen
ian.org/823456 > Architecture: amd64 (x86_64) Thanks for reporting this. It is only one symptom of the actual bug. Let's fix this before we find out exactly what else was broken by my patch in reportbug 7.1.6. Follow-up patch attached. >From 892d6fb67fbe2e9198884e020e8f1926c7a1188b Mon Sep

[Reportbug-maint] Bug#859274: /usr/bin/querybts: double-faults when using -m option

2017-04-22 Thread Nis Martensen
control: tags 859274 patch Thanks for reporting this. Here's a patch. >From cbe84151785b180188d5df9c26f42714e82e9451 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Sat, 22 Apr 2017 11:27:37 +0200 Subject: [PATCH 1/2] Finish open_url return type conversion The return type of r

[Reportbug-maint] Bug#857013: Fixing #857013

2017-04-22 Thread Nis Martensen
control: tags 857013 patch Thanks Michal for finding and reporting this bug! >From 9d8f610dedbd831961ed2d30d96782c569c60d5c Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Sat, 22 Apr 2017 11:43:19 +0200 Subject: [PATCH 2/2] utils.py: Fix IndexError: list index out of range re.find

[Reportbug-maint] Bug#857013: Fixing #857013

2017-04-20 Thread Nis Martensen
This might work, too? : - conffiles = conffiles + [re.findall(r' (.+) ([0-9a-f]+).*$', line)[0]] + conffiles += re.findall(r' (.+) ([0-9a-f]+).*$', line) ___ Reportbug-maint mailing list Reportbug-maint@lists.alioth.debian.org http://lists.alioth.debian

[Reportbug-maint] Bug#857794: reportbug: crash when encountering some non-ASCII characters

2017-03-24 Thread Nis Martensen
Hi Stuart, Thanks for your comments! On 22-03-2017 02:45, Stuart Prescott wrote: > C.UTF-8 is provided within glibc (it's in the libc-bin package so it > is always available). Is it worth setting that as the locale for all > communication with subprocesses? It strikes me that could simplify > som

[Reportbug-maint] Bug#857794: reportbug: crash when encountering some non-ASCII characters

2017-03-21 Thread Nis Martensen
Thank you for your report, and for the nice recipe to reproduce the bug. Can you try the attached patch? >From f42c5879b91b11a986e93f7f92244cf938dae0fb Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Tue, 21 Mar 2017 22:23:49 +0100 Subject: [PATCH] Stop using subprocess.getoutput() To av

[Reportbug-maint] Bug#848729: It is grave

2017-02-14 Thread Nis Martensen
tion byte > > and my locale is: > > $ locale > LANG=en_DK.UTF-8 Your Traceback is different from the others. This bug is not fixed yet. Did you try to attach a text(plain/html/etc) file in a different encoding than UTF-8? As a workaround, you could gzip that file. Attached a

[Reportbug-maint] Bug#853269: reportbug: attempting to use gtk2 interface on text console segfaults, should fallback to text

2017-02-03 Thread Nis Martensen
> reportbug should fallback to the text ui if run from a text console. Here is a patch that implements this. Regards, Nis >From a2da701d8f1fa1a5b33392a6ee8b4d16171466ce Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Wed, 1 Feb 2017 23:28:51 +0100 Subject: [PATCH 4/4] gtk2_ui: w

[Reportbug-maint] Bug#853269: reportbug: attempting to use gtk2 interface on text console segfaults, should fallback to text

2017-01-30 Thread Nis Martensen
Package: reportbug Version: 7.1.4 Severity: normal $ reportbug --ui gtk2 Unable to init server: Could not connect: Connection refused Unable to init server: Could not connect: Connection refused Segmentation fault $ reportbug should fallback to the text ui if run from a text console. ___

[Reportbug-maint] Bug#853159: [reportbug] package reportbug should recommend to install the package "gir1.2-vte-2.9"

2017-01-30 Thread Nis Martensen
intended. The attached patch fixes both #852652 and #853159. >From 7c4ef828a097583f71144e2b785e15c9a7895a55 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Mon, 30 Jan 2017 23:52:20 +0100 Subject: [PATCH 3/3] ui/gtk2_ui: fix incomplete fallback to text ui This fixes crashes when the python3-gi-ca

[Reportbug-maint] Bug#749884: reportbug: doesn't grok :any qualifiers in Depends

2017-01-28 Thread Nis Martensen
The attached patch fixes this by dropping the qualifier before looking up the package status information. It is possible that something else is needed for proper multi-arch support. Regards, Nis >From 3df5c44f472609894488df47deb30f9f3281dc86 Mon Sep 17 00:00:00 2001 From: Nis Martensen D

[Reportbug-maint] Bug#848729: reportbug UnicodeDecodeError: possible patch, please test

2017-01-28 Thread Nis Martensen
Control: tags 848729 patch On 26-01-2017 00:47, Nis Martensen wrote: > Can you please test if the attached patch fixes this bug? > > (This bug already has multiple duplicates -- Bugs #848729, #849358, > #850687, #851865, #852129 all seem related.) Recipe to reproduce the bug:

[Reportbug-maint] Bug#848729: reportbug UnicodeDecodeError: possible patch, please test

2017-01-25 Thread Nis Martensen
Can you please test if the attached patch fixes this bug? (This bug already has multiple duplicates -- Bugs #848729, #849358, #850687, #851865, #852129 all seem related.) >From f1bbfcfd8ef09ae86f06ea1aa815e0a4c4e51e92 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Thu, 26 Jan 2017 00:09

[Reportbug-maint] Bug#850317: reportbug attachment bug fix

2017-01-16 Thread Nis Martensen
File "/usr/lib/python3/dist-packages/reportbug/submit.py", line 177, in mime_attach email.Encoders.encode_base64(part) AttributeError: module 'email' has no attribute 'Encoders' Looks like a typo with a simple fix: s/Encoders/encoders/ in line 177 of reportbug/submit.py ___

[Reportbug-maint] Bug#851361: reportbug: please show user from address in human readable format, not rfc 2047 encoded

2017-01-14 Thread Nis Martensen
ing '=?utf-8?q?Hans_M=C3=BCller?= ' as your from address. After: > Using 'Hans Müller ' as your from address. >From e1e88e8d5d865dca3d7ad7fb7507423a398248b6 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Sat, 14 Jan 2017 11:52:52 +0100 Subject: [PATCH 4/4] Output user f

[Reportbug-maint] Bug#851355: reportbug manpage: wrong order of email environment variables

2017-01-14 Thread Nis Martensen
aken from your > user name and /etc/mailname. The order of the environment variable does not match the code, which means that the fix for bug #472296 was not complete/correct. Patch attached. >From d4b4fe45ba0a424b7c2ae7bdb2ab8b0b3df994c7 Mon Sep 17 00:00:00 2001 From: Nis Martensen Da

[Reportbug-maint] Bug#851322: reportbug: bug script fails with non-ascii characters in reportbugrc

2017-01-13 Thread Nis Martensen
Package: reportbug Version: 7.1.2 Severity: normal Dear Maintainer, Configure a realname with non-ascii characters, then try to report a bug on reportbug itself with reportbug 7.1.2. If you have no locale set, reportbug fails immediately. (But I'm not sure this case should be supported. You real

[Reportbug-maint] Bug#849749: reportbug: unable to run its own bug script without python 2

2016-12-31 Thread Nis Martensen
The previous patch is still not sufficient if there are non-ascii characters in the name, for example. Explicitly choosing utf-8 character encoding makes it work. >From 95f5fcb92086110e23a3611beae550397ad49801 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Fri, 30 Dec 2016 14:11:24 +0

[Reportbug-maint] Bug#849749: reportbug: unable to run its own bug script without python 2

2016-12-31 Thread Nis Martensen
The previous patch turned out to be incomplete. Here is a new version, now tested. The bug control file should probably also be updated. Attaching another patch. >From 098e23286bfa44566e4877dd9532ce5e436a799f Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Fri, 30 Dec 2016 14:11:24 +0

[Reportbug-maint] Bug#849749: reportbug: unable to run its own bug script without python 2

2016-12-30 Thread Nis Martensen
rom 5ba5586196275bec188fe4f473a1eba207506cb5 Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Fri, 30 Dec 2016 14:11:24 +0100 Subject: [PATCH] Port bug script to python3 --- share/script | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/share/script b/share/script index e64c5e9..58ee

[Reportbug-maint] Bug#849677: Bug#849677: reportbug: ampersand-replaced usernames should be capitalized instead of uppercased

2016-12-30 Thread Nis Martensen
Hey Sandro, On 29-12-2016 19:53, Sandro Tosi wrote: > Thanks for your patch, but in the meantime reportbug has migrated to > python3 (as for v7.0.0, latest v7.1.1) - could you verify if your fix > is still required in the new version and if so port the patch to it? > git repo url for reference: >

[Reportbug-maint] Bug#849677: reportbug: ampersand-replaced usernames should be capitalized instead of uppercased

2016-12-29 Thread Nis Martensen
hed. >From a385efe73ab398b9acd51319dd5249385843326d Mon Sep 17 00:00:00 2001 From: Nis Martensen Date: Thu, 29 Dec 2016 19:25:44 +0100 Subject: [PATCH] Ampersand replacement should capitalize, but not uppercase to match behavior of "finger" --- reportbug/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 de