Re: [Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

On 2010-7-13 17:37, Nuno Teixeira wrote: > > -def __init__(self, cookie_name, cookie_path='/'): > +def __init__(self, cookie_name, cookie_path='/', charset=None): Can we standardise on using 'encoding' as parameter name instead of 'charset' ? I think we use encoding everywhere else as wel

[Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

Tres Seaver added the comment: Thanks for adding tests. I noticed that the tests did not actually confirm that the codec had been used properly, which led me to find a bud in the main part of the patch: the charset must be used to encode the login and password *before* applying the 'base54' c

[Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

System message: __ Repoze Bugs __ ___ Repoze-dev mailing list Repoze-dev@lists.repoze.org http://lists.repoze.org/listinfo/repoze-dev

[Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

Nuno Teixeira added the comment: Added tests for full coverage __ Repoze Bugs __Index: repoze/who/plugins/cookie.py === --- repoze/w

[Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

Tres Seaver added the comment: The patch looks reasonable, but needs test coverage. Can you add tests for the encoding / decoding code paths? -- nosy: +tseaver status: unread -> chatting __ Repoze Bugs

[Repoze-dev] [issue155] Support encoding of cookies on repoze.who cookie plugin

New submission from Nuno Teixeira : I think that encoding cookies data could be useful. My usecase is related with SQLAlchemy that avoid the use of non-unicode strings on queries. -- files: r9728.diff messages: 426 nosy: nteixeira priority: feature status: unread title: Support encoding