Source: wims-extra Version: 3.62-6 Severity: wishlist Tags: patch User: reproducible-builds@lists.alioth.debian.org Usertags: locale X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
Hi, While working on the "reproducible builds" effort [1], we have noticed that wims-extra could not be built reproducibly. Ironically the "fixscripts" target in the upstream Makefile actually breaks files it generates under non-UTF8 locales when they do not contain regular characters, making them include the tell-tale string "Binary file matches.." The attached patch fixes this with grep's --text option. Once applied, wims-extra can be built reproducibly in our reproducible toolchain. [1]: https://wiki.debian.org/ReproducibleBuilds Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
diff --git a/Makefile b/Makefile index c8aaa84..c47a930 100644 --- a/Makefile +++ b/Makefile @@ -62,7 +62,7 @@ copyfiles: fixscripts: for f in $(SCRIPTS); do \ - grep -v '#!' $(INSTMODULES)/$$f > $(INSTMODULES)/$$f.tmp; \ + grep -av '#!' $(INSTMODULES)/$$f > $(INSTMODULES)/$$f.tmp; \ mv $(INSTMODULES)/$$f.tmp $(INSTMODULES)/$$f; \ done
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds