Re: [Reproducible-builds] Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Holger Levsen
On Mon, Aug 08, 2016 at 12:23:08PM +0200, Chris Lamb wrote: > This is, alas, done inconsistently. Some do it in ``recognizes` (returning > False) and some do it in ``compare_details`` but returning ``[]`` this is annoying and should be fixed. > However, most appear to not catch useful errors.

[Reproducible-builds] Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Chris Lamb
> > It seems somewhat cumbersome to do in the code > > istr in some cases it prints the error and return false (so that a > "lower level" comparator can do the comparison This is, alas, done inconsistently. Some do it in ``recognizes` (returning False) and some do it in ``compare_details`` but

[Reproducible-builds] Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-08 Thread Chris Lamb
Hi, > diffoscope: libarchive.exception.ArchiveError when running on two dmg files ACK. Wider question: what's the general diffoscope policy on what to do when the files are invalid? It seems somewhat cumbersome to do in the code, so I am inferring that we just blow up in lots of cases we

[Reproducible-builds] Bug#833697: diffoscope: libarchive.exception.ArchiveError when running on two dmg files

2016-08-07 Thread David Fifield
Package: diffoscope Version: 56 Severity: normal I get a crash when running diffoscope on these two dmg files. They are just byproducts of a development process. The two files are here (about 65 MB each):