Hello!
Please see my comments inline.
On Saturday 31 January 2009 17:35:45 Christian Hammond wrote:
> Thanks for the patches. I'll look into them.
You're welcome.
> > http://reviews.review-board.org/r/729/diff/ ) Probably these keys are
> > intercepted as hotkeys by diffviewer component. I use
Hi David.
There's a bug open for this at:
http://code.google.com/p/reviewboard/issues/detail?id=730
We should have this fixed for 1.0. It's not fixed yet, and it's been around
for a while, but it shouldn't be hard to fix. We'll probably get it in the
betas.
Christian
--
Christian Hammond - ch
Steps to reproduce: Create a review request with a diff that includes
the creation of a file. Update the diff with an additional change to
the new file. Go to the diff view, view changes between r1 and r2.
Observed behavior: The side-by-side diff table for the new file has
class="sidebyside newfi
On Sat, Jan 31, 2009 at 12:38 PM, Christian Hammond wrote:
> Hi,
>
> I'm not sure I understand your problem yet. Your auth backend should be able
> to set this information if you want it to. Is the problem mainly that the
> appropriate fields don't appear in the preferences page? If so, it's beca
Hi,
I'm not sure I understand your problem yet. Your auth backend should be able
to set this information if you want it to. Is the problem mainly that the
appropriate fields don't appear in the preferences page? If so, it's because
we're explicitly checking the backend type in the prefs template.
Hi Alexey.
Thanks for the patches. I'll look into them.
Some comments below.
On Sat, Jan 31, 2009 at 3:21 AM, Alexey Morozov wrote:
> When I first switched to LDAP based auth I discovered that I can't login
> as 'admin' anymore. Short investigation showed that the problem is in
> exception ha
Hi!
On Friday 30 January 2009 16:41:17 Christian Hammond wrote:
> Hi Alexey.
> We have a patch up that I haven't reviewed yet (I'd like other
> LDAP-knowledgeable users to look into it if possible) that may address your
> concerns. Would you be able to give it a try?
>
> http://reviews.review-boa
Should be fixed now in SVN r1730. I'm going to spin a new nightly as well.
Christian
--
Christian Hammond - chip...@chipx86.com
VMware, Inc.
On Sat, Jan 31, 2009 at 2:39 AM, Terry Zhong wrote:
>
> I'm trying to upgrade to r1726 while errors jump up. I see a new
> template file "diffviewer/ch
I'm trying to upgrade to r1726 while errors jump up. I see a new
template file "diffviewer/changeindex_entry.html" is added to some of
the templates, but this file is missing... That's strange and causes
diff viewer "500 Something broken" error.
--~--~-~--~~~---~--~
