Re: post-review login issue

2009-09-23 Thread Hui Lin
The issue started from line 107 of "diffutils.py". This is how the "patch" is executed: p = subprocess.Popen(['patch', '-o', newfile, oldfile], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) The subsequent error check

Re: post-review login issue

2009-09-23 Thread Hui Lin
Hi, Dana: I saw your posts are rendered at full length each line, but mine are wrapped at 70-80 characters, which makes them look quite different from what I originally posted. What is the trick? Thanks On Sep 23, 11:28 am, Hui Lin wrote: > The issue started from line 107 of "diffutils.py".

404 when adding line comment

2009-09-23 Thread Pv
I just got Review Board up and running today using Apache+mod_python +memcache on Windows (py25). First question: Is this the right group to post a question to? :) Things seem to work fairly smoothly, but when I try to save a comment to a line of code in a diff I get a 404 at the top of the scre

Re: 404 when adding line comment

2009-09-23 Thread Christian Hammond
Hi, Yep, this is the right mailing list. So first of all, did you mean to install the in-development version? That's perfectly fine, but I want to make sure. Was the review request published? Or did you leave a comment on the diff before publishing the review request? That will cause this. There

Re: 404 when adding line comment

2009-09-23 Thread Pv
Yes, I meant to install and try out the dev version. The review was still a draft and had not been published. I published the review and could make a comment fine. I did a quick discussion search for 404 (and related), but did not see anything. Also interesting, when I had the review in draft a

Re: 404 when adding line comment

2009-09-23 Thread Christian Hammond
The 500 error is odd. I'll look into it. Fortunately that's just an admin-side thing, and it may be specific to the 1.1 dev branch. This is the bug I was thinking of: http://code.google.com/p/reviewboard/issues/detail?id=831 Note that this shouldn't impact reviewers. It's only in the case where y

Re: post-review login issue

2009-09-23 Thread Hui Lin
I resolved the patch issue by running Apache as a normal Windows application, not a service. Not sure exactly why, but suspect that the different user accounts for running Windows services (SYSTEM) and running user applications (Current User Login) may be the reason. Now diff view is working grea

Re: post-review login issue

2009-09-23 Thread Christian Hammond
Ahh, that very well may be. Glad it's finally working though. Most of our development and testing is done on Linux. Some of our dependencies are hard to install on Windows, and there's some other gotchas like this that we're still only finding out about. I'm personally hoping to find someone who w