"Reviewed by" List

2014-05-22 Thread Prakhar Goyal
Is there a way to find out what all reviews were done by a particular person? I checked ou the documentation for both Review Board and its RBTools and couldn't find anything. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCo

Re: how to apply review code on local machine

2014-05-22 Thread shankar KC
I raised a bug and its resoled as fixed. Fixed version is 0.6.x. Is this version available for download. I downloaded the latest version from GIT repo but it doesnt contain fix for this issue. https://code.google.com/p/reviewboard/issues/detail?id=3365 On Thursday, May 22, 2014 9:49:40 AM UTC+

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread Brett Randall
Thanks Christian. I ran blame to find the commit where this was added, and commented: https://github.com/reviewboard/reviewboard/commit/ed3e2a4382aeaf4155dabe67a2d259ca72362096 So I think the drive here was to ensure that the patch filename is retained, but "attachment" might be more appropria

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread Steven MacLeod
Most sites seem to do the opposite of what I want about 50% of the time. I think in this case though since Review Board gives you a diff viewer, you'd generally want to download the diff when clicking "Download Diff", so I vote for changing it. As an aside, here is a firefox add-on I use for deali

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread David Trowbridge
Personally, if I click "Download X" and it displays in the browser, I get annoyed. -David On Thu, May 22, 2014 at 6:37 PM, Christian Hammond wrote: > Hi Brett, > > It's actually never come up before, that I know of. It may be more useful > to do that, but I think it's arguable. Certainly, I som

Re: Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread Christian Hammond
Hi Brett, It's actually never come up before, that I know of. It may be more useful to do that, but I think it's arguable. Certainly, I sometimes view the diff and am happy looking at it right in the browser, instead of having to save it somewhere and then open it. I'm interested in hearing what

Content-Disposition is "inline" instead of "attachment" in response to Download Diff

2014-05-22 Thread Brett Randall
Hi, RB 1.7.21. I've noticed that the response to Download Diff includes a Content-Disposition: inline: GET /r/1234/diff/raw/ HTTP/1.1 Content-Type: text/x-patch ... Content-Disposition: *inline*; filename=some.patch Shouldn't that be: Content-Disposition: *attachment*; filename=some.patch

Re: After installation of reviewboard, I am not able to see the site instead I can see only the directory structure

2014-05-22 Thread Christian Hammond
Also, how are you accessing it? Can you show your Apache configuration? Your entry for the "Root Path" that you've shown is not a path. You also selected sqlite3, which will only support a single user at a time. You need to install bindings for MySQL. What Linux distro are you using? Christian

Error posting review from ClearCase

2014-05-22 Thread Igor Litmanovich
Hi, I'm trying to create a new review with rbt post and get an error "The file was not found in the repository (HTTP 400, API Error 207)" My ClearCase client is a Windows machine, while RB server is on Linux, hence the CC path is different. So I wonder if it is possible in general to work with

Re: After installation of reviewboard, I am not able to see the site instead I can see only the directory structure

2014-05-22 Thread markdbeyer
Manoj, did you restart httpd and memcached ? I didn't see it in your log. Mark Beyer On Thursday, May 22, 2014 2:34:23 AM UTC-7, Manoj Kumar wrote: > > Following are the steps that I have performed while setting up the > site.But I am unable to access the site. > > > > * Welcome to the Review B

Re: Problems upgrading from RB1.5 to RB2.0RC3

2014-05-22 Thread Paul Fee
Thank you Christian and Stephen, I'm now able to upgrade my RB1.5 database to RB2.0 using the packages from Fedora Rawhide. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let u

Re: Problems upgrading from RB1.5 to RB2.0RC3

2014-05-22 Thread Stephen Gallagher
On 05/21/2014 09:09 PM, Christian Hammond wrote: > Thanks for the info, everyone! > > I just put out a Django Evolution 0.7.1 release, which should fix this > issue. You can upgrade with: > > easy_install -U django_evolution > > Or, if using RPMs, Stephen will get to it soon! :) Updated py

Broken Link on Main Page

2014-05-22 Thread Stein, Ruben
Hi, the link to the Python API on the main page (http://www.reviewboard.org) is broken: http://www.reviewboard.org/docs/rbtools/dev/api/ Regards Ruben -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommon

After installation of reviewboard, I am not able to see the site instead I can see only the directory structure

2014-05-22 Thread Manoj Kumar
Following are the steps that I have performed while setting up the site.But I am unable to access the site. * Welcome to the Review Board site installation wizard This will prepare a Review Board site installation in: /var/www/sdk..com We need to know a few things before we

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Ok. Anyway, thanks a lot for your time, you saved ours a lot. Let the reviews begin ;) Nicolas. Le jeudi 22 mai 2014 10:57:08 UTC+2, Christian Hammond a écrit : > > While it's technically safer to have it on than off, most Linux > distributions do not have it on by default, as it's very strict.

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
While it's technically safer to have it on than off, most Linux distributions do not have it on by default, as it's very strict. You should be fine to turn it off, so long as this box is otherwise secured from the outside world. I believe the RPMs have SELinux rules that you can use if you want to

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
It actually worked !! I had to reboot the machine. Thanks a lot. Is it safe to let the SELinux off? Le jeudi 22 mai 2014 10:23:21 UTC+2, Nicolas Comet a écrit : > > Disabling it did not change a thing :( > > I'll try to get in touch with the sysadmin, because it should't ask for a > passphrase

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Disabling it did not change a thing :( I'll try to get in touch with the sysadmin, because it should't ask for a passphrase when loggin in to the svn, but it does in command line. Weird. Le jeudi 22 mai 2014 10:18:04 UTC+2, Nicolas Comet a écrit : > > $ cat /etc/sysconfig/selinux > > # This fi

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
$ cat /etc/sysconfig/selinux # This file controls the state of SELinux on the system. # SELINUX= can take one of these three values: # enforcing - SELinux security policy is enforced. # permissive - SELinux prints warnings instead of enforcing. # disabled - No SELinux policy is loaded

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
Okay, those look fine. You asked if the key could be passphrase-less, as in not having a passphrase? That's completely fine, and in fact required, since we can't prompt for the passphrase. Another thing to check... Do you have SELinux enabled? It's possible it's trying to run rbssh, and can't run

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Here it is : data : .ssh : id_rsa :

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
Just to verify, can you show me the permissions and ownership of /var/www/reviewboard/data/, .ssh within that, and then the contents within that? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, May

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Here is what I get in reviewboard.log : 2014-05-22 07:55:38,620 - INFO - - Reloading logging settings 2014-05-22 07:55:38,980 - DEBUG - - Cache miss for key jsi18n-djangojs-reviewboard_djblets-fr-1400577976. 2014-05-22 07:57:12,670 - DEBUG - - Cache miss for key jsi18n-djangojs-reviewboard_dj

Re: "[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Christian Hammond
Hi, Can you enable logging in the Logging Settings, repeat this (you may need to reload Apache first), and then see what errors appear in reviewboard.log? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com O

"[Errno 13] Permission denied" when trying to add ssh+svn repository

2014-05-22 Thread Nicolas Comet
Hi there, I've successfully upgraded from reviewboard 1.7 to 2.0, (I did not had a repository configured before). When trying to add a repository, with a ssh RSA private key added to the SSH configuration section, I get the following error :