Re: skipping or excluding versions within a range

2016-05-09 Thread Griffin Myers
Aaron, Here is how I do this for SVN, it's not the cleanest but it works. The key is not to post-review on the branch explicitly, but pseudo-post-review (for lack of a better term) on the branch relative to trunk. Make all your changes to your branch and commit, as you are doing. Eventually

Re: rbt diff with --include issue/help

2016-02-03 Thread Griffin Myers
I know in an older version of RBTools I had trouble with including files with absolute filesystem paths (see https://hellosplat.com/s/beanbag/tickets/3641/). As far as I know this has not been resolved, but I'm not sure if this is exactly what you are seeing as I don't recall running into an i

Re: Creating post-commit code review for new files

2016-01-04 Thread Griffin Myers
I've attempted to replicate your scenario and the following appears to work for me. >From the MyRepo directory, execute rbt post -I MyNewLib/ 10:50 On Monday, January 4, 2016 at 8:57:42 AM UTC-5, Carel Combrink wrote: > > Hi, > > I have an issue when creating a code review for files added in a

Re: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 80769: ordinal not in range(128)

2015-10-16 Thread Griffin Myers
Yes, I'm 99% certain this has been fixed in 7.0.5 as well. On Friday, October 16, 2015 at 5:11:02 PM UTC-4, Sam wrote: > > Thank you Christian for quick response. > We are also seeing followng error: > > *ERROR: Could not load SCM Client "git": [Errno 2] No such file or > directory* > > From oth

Tips and tricks for reviewing large changesets?

2015-09-29 Thread Griffin Myers
Today I found myself reviewing a large changeset with several hundred files that spanned 15+ pages in RB. This is C++ code so I often needed to move between related .cpp and .h files from adjacent inc and src folders which were on different pages with RB's alphabetical(?) ordering of files. F

Re: open issue without code comment?

2015-08-16 Thread Griffin Myers
..@chipx86.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > On Sat, Aug 15, 2015 at 12:00 PM, Griffin Myers > wrote: > >> I thought I would reopen this old thread to see if any innovations that >> I'm not aware of ha

Re: open issue without code comment?

2015-08-15 Thread Griffin Myers
I thought I would reopen this old thread to see if any innovations that I'm not aware of have occurred on this front or if others in the community have come up with new creative ways to address this problem. I've reached the conclusion that some folks really use the issue list as a crutch and h

Re: RbTools 0.7.4 - ERROR: The current directory does not contain a checkout from a supported source code repository.

2015-06-16 Thread Griffin Myers
I think that error message is a red herring and should already be fixed in 4678679 (https://github.com/reviewboard/rbtools/commit/4f344a9efb2c3534e46b117e6bad15856a3a7be9). On Tuesday, June 16, 2015 at 3:34:59 PM UTC-4, David Trowbridge wrote: > > > On Tue, Jun 16, 2015 at 3:33 AM, > wrote: > >>

Re: something wrong when i run "rbt setup-repo" in the svn source directory

2015-06-03 Thread Griffin Myers
As the error message says, you need to install GNU diff and ensure that it is in your system path. While the setup-repo command does not explicitly need the diff executable, other rbt commands, notably diff and post, do. The failure is arising due to common error checking utilized by all rbt

Re: CRITICAL: not well-formed (invalid token): line 3, column 28

2015-04-12 Thread Griffin Myers
t is a > problem with the way we run our linux cluster and/or svn repo here. > > Thanks so much Griffin. > > On Friday, 10 April 2015 02:51:29 UTC+1, Griffin Myers wrote: >> >> Hi Richard, >> >> Am I correct that "rbt diff" is prompting you for your

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-12 Thread Griffin Myers
7;t > risk not committing for that length of time. We all branch from trunk, > feature add, review and then merge back to trunk, hence having to use post > commit method. > > Cheers, Richard > > On Friday, 10 April 2015 02:02:33 UTC+1, Griffin Myers wrote: >> >> H

Re: CRITICAL: not well-formed (invalid token): line 3, column 28

2015-04-08 Thread Griffin Myers
Can you share the output of: svn log -r 12192 -l 1 --xml The less sanitized the better, although I guess line 3 will be the most critical. I suspect some sort of encoding issue, but I don't know why this is system dependent. Perhaps something to do with locales? On Tuesday, April 7, 2015 at

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-08 Thread Griffin Myers
Hi Richard, Your initial issue was a legitimate bug. I think this is something separate, but still likely due to moved/deleted files. I don't do very many post-commit reviews, but coincidentally I needed to do one today and I think I ran into the latest issue you are seeing. I fought with it

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-07 Thread Griffin Myers
I've posted a patch for review at https://reviews.reviewboard.org/r/7183/ which should resolve this issue. On Tuesday, April 7, 2015 at 2:18:43 PM UTC-4, Richard Parks wrote: > > Hi, I've used RBTools for several reviews with no problems but I've now > encountered a problem with a svn reposito

Re: Unable to installing Extensions on RB 2.0.3

2014-07-18 Thread Griffin Myers
We are also unable to get RBSeverity to work. I'm using Firefox 30.0 and I'm seeing roughly the same reports in their developer tools console: ReferenceError: RBSeverity is not defined diff:622 which roughly corresponds to the following code: new RBSeverity.Extension({ id: 'rbseve

What is the correct syntax for rbt diff?

2013-09-02 Thread Griffin Myers
I'm using RBTools 0.5.2 and I can not get rbt diff to execute correctly for an SVN repo. I'm running under Windows 7 with Python 2.7.3. Running rbt post works fine and gives me: *rbt post -d --server http://192.168.50.xxx/reviewboard .* DEBUG:root:Checking for a Subversion repository... > DEBUG

Re: Question about access controls for review groups

2013-08-30 Thread Griffin Myers
I'll see if I can find some time to investigate a patch on this one. Perhaps I'm just being paranoid about this being a legitimate problem. Part of the reason my company is considering RB is to increase participation in our currently informal code review process and I'd like to ensure that the

Re: Understanding the logic behind collapsible reviews

2013-08-30 Thread Griffin Myers
Christian, Thanks for the detailed replies. I imagine some of my concerns with collapsible reviews will dissipate once I have more mileage in working with RB. I'll eagerly await the upgrades you mention for the next major release as well as the solution to the "where did the comment go?" prob

Question about access controls for review groups

2013-08-30 Thread Griffin Myers
The users in these groups (those who are to be the actual reviewers or observers) shall be defined by the Manager and users shall not be able to opt themselves from being a member of this group. Thanks, Griffin Myers -- Want to help the Review Board project? Donate today at http://www.reviewboa

Understanding the logic behind collapsible reviews

2013-08-30 Thread Griffin Myers
igate between new comments, similar to what is available on the reviewing page. Again I'd be happy to open a feature request ticket if necessary. Thanks, Griffin Myers -- Want to help the Review Board project? Donate today at http://www.revi