Re: email notification

2010-09-16 Thread Timothy Pinet
Well that URL got mangled... http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#automating-post-review tim On Sep 16, 12:51 pm, "Tim Pinet" wrote: > Trying using the "submit-as" parameter. > > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#a... > ng-post-re

RE: Happy user

2010-08-27 Thread Timothy Pinet
is based on the Java command line client. After reducing the number of TFS commands per review request the performance is quite acceptable. Philipp On Aug 27, 12:26 pm, "Timothy Pinet" wrote: > I am quite interested to hear how you enabled TFS. Please share :) > > Tim > &

RE: Happy user

2010-08-27 Thread Timothy Pinet
I am quite interested to hear how you enabled TFS. Please share :) Tim -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Philipp Henkel Sent: August-27-10 4:34 AM To: reviewboard Subject: Happy user Dear Review Board developers, I w

ReviewBoard and TFS - working

2010-08-24 Thread Timothy Pinet
Good afternoon, It has taken me some time but I have ReviewBoard working with our TFS repository at my workplace. I want to post here so that others can get TFS working or refine my process. I have posted to my blog all of my findings. http://blogs.pinet.ca/tim/2010/08/24/code-review-goodness-wit

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-23 Thread Timothy Pinet
Thanks for the suggestion. I downloaded rbtools 0.2 stable from http://github.com/reviewboard/rbtools, made my changes to postreview.py, and reinstalled the package using "python setup.py install" at the rbtool root. In postreview.py I changed the "svn diff --diff-cmd=diff" to "svn diff --diff-cmd

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Timothy Pinet
I wanted to check post-review however since I am on Windows my Python26\Scripts\post-review.exe is a compiled executable and not a python file. Would it be enough to grab the post-review.py from the repo and delete the exe? Thanks, Tim On Aug 20, 12:54 pm, Chris Clark wrote: > > It actually isn'

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Timothy Pinet
In which file does reviewboard invoke the "svn diff --diff-cmd=diff" command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/ pysvn_prog_ref.html#pysvn_client_diff) and there is a

RE: Facing problem installing in Windows!

2010-08-20 Thread Timothy Pinet
That is good to hear! When in doubt on Windows, reboot :) Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this

RE: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-19 Thread Timothy Pinet
emember exactly what they were). It may be worth modifying your copy for now to remove that parameter, if it's blocking you. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Aug 19, 2010 at 5:42

RE: Facing problem installing in Windows!

2010-08-19 Thread Timothy Pinet
I installed 1.0.9 on Windows XP a couple of weeks ago successfully. I used http://www.reviewboard.org/docs/manual/1.0/admin/installation/windows/ and got it to work first attempt. Try installing using these instructions. Tim -Original Message- From: reviewboard@googlegroups.com [mailto:r

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-19 Thread Timothy Pinet
Alternatively, the diffutils docs (http://www.gnu.org/software/hello/ manual/diff.html#Binary) state: "Differing binary files are considered to cause trouble because the resulting diff output does not capture all the differences. This trouble causes diff to exit with status 2. However, this troubl