Hey Christian,
Upgraded. A grand 'thank you for all the work but in to this' from
here!
Have a nice weekend
- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
Correct me if I'm wrong, but your script is useful when you want to put
existing committed code as a whole up for review, right? Such as when you're
doing a post-commit review for the first time of some code?
Yup, correct. Having re-read the original question, I agree that if
you want to
post-review has the --revision-range argument, but this does not work
(as far as I remember - or rather, last time I checked this some while
ago), if you specify lower revision numbers than the initial. If you
want do put whole files up for review, you'd normally want something
ala:
svn diff -r
Try doing a post-review -d to better understand what is going on.
- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To
Ah - well, that's the risk of using upgrading to some latest
version :)
- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To
Try now (though, use the release, not a nightly. Need to rebuild nightlies.)
Yup, working fine.
Thanks for all the work you're putting in to this, Christian.
-- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
That reviewboard server url looks wrong. Try with
post-review -d --server=http://company.reviewboard.com
-- Jeppe
On Jul 2, 1:23 am, rquit rhondafquita...@gmail.com wrote:
Hello,
I am trying to set up a demo of RB on Windows and I am stuck at 'post-
review'.
I get the following error:
$
Are we sure this is resolved. Upgraded to 1.0.7, restarted apache and
memcached but still see this problems occasionally (refreshing with
shift+F5 seems to be a good way to reproduce). Have tried with both
chrome and firefox.
-- Jeppe
--
Want to help the Review Board project? Donate today at
Hmm, perhaps I was a bit too fast on this. Did some more re-starting/
force-reloading and it seems to work correctly now.
-- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
I can reproduce this too. Looks like a bug in the caching. I'll look into a
fix tonight. There will probably be a bug fix release soon.
Any update on this? We're running the latest released 1.0.6 and have
this problem as well.
-- Jeppe
--
Want to help the Review Board project? Donate today
Hi Christian,
First, thanks for your continued efforts building review-board. Your
work is mush appreciated.
I've just tried upgrading my 1.0.5.1 installation to 1.0.6. There
seems to be a problem with django/memcached excepting plain 'str'-keys
and rb/django now using unicode?
b...@b49864:~$
The problem looks similar to this old django bug:
http://code.djangoproject.com/ticket/4845
I had a look in my /usr/local/lib/python2.6/dist-packages/Django-1.1.1-
py2.6.egg/django/core/cache/backends/memcached.py
In all functions, the key was wrapped by the django smart_str type,
except for
Hi Christian,
As always, we're looking to fill out our page of Happy Users
(http://review-board.org/users/), so if you use Review Board and can give us
permission to list you, please let us know!
You can add Bang Olufsen to your list happy users.
-- Jeppe
Hi Christian,
Not around your neighborhood at that time; live in Denmark :). Have a
great party! Thanks for all your efforts in making review-board a very
valuable contribution to toolbox of stuff that make us all write
better code.
-- Jeppe
Got a few rb-site upgrade warnings that I usually do not see:
sudo rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.
/var/lib/python-support/python2.6/MySQLdb/__init__.py:34:
DeprecationWarning: the sets module is deprecated
from sets
I there some way to associate a default reviewer with a repository?
The file path seems to be relative to the repository url, making it
impossible to distinguish files from different repositories but with
same relative path
Example
repos1: https://repos1.com/
repos2: https://repos2.com/
review
You can go ahead and join groups with this method and still not
receive emails. We only email people individually if there is no
mailing list associated with the group. People can join the group but
not the mailing list and shouldn't see the emails.
We do not have an internal mailing list
As an alternative to sending out emails, which we are discussing in
another thered, I'd like to give this post a bump. Any inputs,
thoughts?
-- Jeppe
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard
I would find it useful to to be able to configure this independently
for groups and people, such that a user can choose to be member of a
particular group, but not receive any emails from review requests to
that group, but only get emails if a review request is directed at the
user (listed in
Found yet another bug in the get_files function:
--
def get_files(paths):
if not paths:
paths = [.]
files = []
for p in paths:
if os.path.isdir(p):
dir = p
else:
dir = os.path.dirname(p)
_files = execute([svn,
Hi Christian,
I believe IE6 is still the official company browser. However,
virtually no developers use it. It's not an unreasonable requirement
that users of reviewboard use a fairly new browser.
-- Jeppe
--~--~-~--~~~---~--~~
You received this message because
Hi,
I'm interested in this feature as well
On Apr 20, 10:04 am, Christian Hammond chip...@chipx86.com wrote:
If your goal to start with is to put whole existing files up for review,
you'd want to use a revision range of 0 to the latest version. Short of
modifying post-review for this, you
I couldn't really figure out how to do this the right way, but I
needed the feature now, so I created a small python script that
generates a unified diff directly, not using svn diff.
initial-review.py [path] [path] ... review.diff
Basically just like using post-review. Paths can be files or
Found a few bugs ...
#!/usr/bin/python
import sys
import os
import os.path
import subprocess
from optparse import OptionParser
DUMMY_FILENAME = __dummy_non_existing_file
def get_files(paths):
if not paths:
paths = [.]
files = []
for p in paths:
_files
Sorry, that probably should have been r1, actually.
Nope, it seems the FROM revision (svn diff -r FROM:TO) must at
minimum be the initial revision of the path diffs are gererated for.
This gives a problem when diffing multiple paths since these often
have different initial revisions. Then
Hi,
I've looked a bit on the existing feeds, and they seem to list only
all (feeds/rss/r/all), pending for a user (/feeds/rss/users/username)
or pending for a group (feeds/rss/groups/groupname).
Would it be possible to use rss feeds to inform about updates that
would normally go out via email
Filled http://code.google.com/p/reviewboard/issues/detail?id=1062
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe
Hi Christian,
Thanks for your reply. I am looking for a deployment that does not
require any form of install. I would simply like to put all scripts
and dependent tools (like gnu diffutils) in one folder -- that can be
run from this folder with no install, zip it and distribute it like
that.
Ended up with patching the python distribution we are using for our
scons build environment. Seemed like the easiest solution.
Thanks
-- Jeppe
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To
I cannot get screenshot commenting to work. I can drag a green
rectangle with the mouse, but no comment box appears as described
here:
http://review-board.org/docs/manual/dev/users/reviews/reviewing-screenshots/
If I do multiple click-and-drags with the mouse, I get multiple
rectangles, all
Hi,
My setup:
ubuntu 8.10
Reviewboard 1.0 beta2
apache2
pylucene 2.4.1 (downloaded source from apache and built)
python 2.5.2
Problem:
When executing a search in the web interface of reviewboard, apache
hangs/deadlocks, using 100% cpu. Issue 770 seems to be about the same
problem
31 matches
Mail list logo
