Hi Deepanshu,
Yes, it's expected. We don't do byte-for-byte diffing. We normalize all
newlines. This is a very important step, because diffs are never guaranteed
to use the same type of newline as the version in the repository. This is
because a repository may keep one version of a file (often
Hi Christian,
Review board is treating these two lines as same (present in different
files) and shows there is no difference between them.
File 1 -> String name;
File 2 -> String name;\r
Is this behavior expected?
Thanks,
Deepanshu
On Wed, Apr 10, 2019 at 10:19 AM Christian Hammond
wrote:
Hi,
Sorry, I'm not sure which issue you're referring to. Can you go into more
details on this?
Christian
On Tue, Apr 9, 2019 at 9:00 AM Deepanshu Arora
wrote:
> Hi Christian,
>
> Is this still an issue in RB v3.0.8? Just to clarify, I am facing an
> issue where reviewboard does not show \r in
Hi Christian,
Is this still an issue in RB v3.0.8? Just to clarify, I am facing an issue
where reviewboard does not show \r in diff? Is that known behvaiour?
Thanks,
Deepanshu
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review
Hi Christian,
Many thanks for your answer. The diff file were generated by codereview, so
I expected it to be compatible with reviewboard. I will ask my colleagues
to check what end of line character they are using.
Best regards,
Jean-Noël
--
Want to help the Review Board project? Donate
]
Skipping patch.
patch: malformed patch at line 36:
the diff files contains /r/r/n at the end of every lines.
however, if I remove the /r manually, the diff files are processed
correctly.
I joined a working and a not working file example.
Is there anything I can do against
:
the diff files contains /r/r/n at the end of every lines.
however, if I remove the /r manually, the diff files are processed
correctly.
I joined a working and a not working file example.
Is there anything I can do against such issue?
Best regards,
Jean-Noël
--
Want to help the Review Board
