Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-13 Thread Christian Hammond
On Fri, Sep 13, 2013 at 9:01 AM, Matthew Woehlke wrote: > On 2013-09-12 23:05, David Trowbridge wrote: > >> I'm not sure what that would look like. Comments are over a set of rows in >> the side-by-side diff rather than a set of lines from either the old or >> new >> file. While it's possible that

Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-13 Thread Matthew Woehlke
On 2013-09-12 23:05, David Trowbridge wrote: I'm not sure what that would look like. Comments are over a set of rows in the side-by-side diff rather than a set of lines from either the old or new file. While it's possible that we could just pull out the relevant lines from the changed revision of

Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-12 Thread David Trowbridge
I'm not sure what that would look like. Comments are over a set of rows in the side-by-side diff rather than a set of lines from either the old or new file. While it's possible that we could just pull out the relevant lines from the changed revision of the file, it's likely that doing so would lose

Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-12 Thread sankar . curiosity
On Tuesday, September 10, 2013 11:16:21 AM UTC+5:30, David Trowbridge wrote: > > Can you define what you mean by "patch snippets"? The sections of code > that users comment on should be included in the HTML emails. > > Sorry for the late reply. Somehow did not get this email notification. The mai

Re: Displaying patch code snippets inline in the reviewboard notification mails

2013-09-09 Thread David Trowbridge
Can you define what you mean by "patch snippets"? The sections of code that users comment on should be included in the HTML emails. -David On Mon, Sep 9, 2013 at 10:37 PM, wrote: > Hi, > > We are using ReviewBoard in our organization. Thanks for this nice project. > > The reviewboard in our or

Displaying patch code snippets inline in the reviewboard notification mails

2013-09-09 Thread sankar . curiosity
Hi, We are using ReviewBoard in our organization. Thanks for this nice project. The reviewboard in our org is configured to send email notifications for any new patches and patch review comments. However, the review comments and the patches display a reviewboard url instead of the actual patch