Aw: Re: GitHub-style review flow

2016-02-02 Thread Veit Guna
Hi Christian.   Sounds promising! I'll check that later on. Thanks!   Cheers Veit   Gesendet: Dienstag, 02. Februar 2016 um 00:01 Uhr Von: "Christian Hammond" An: "reviewboard@googlegroups.com" Betreff: Re: GitHub-style review flow Hi Veit,   As far as I can tell,

Re: GitHub-style review flow

2016-02-01 Thread Christian Hammond
'm quite sure, that this also happened with the account the > >> review requests belong to. > >> > >> Cheers > >> Veit > >> > >> *Gesendet:* Freitag, 18. Dezember 2015 um 00:36 Uhr > >> *Von:* "Christian Hammond" > >> *An:*

Re: GitHub-style review flow

2016-01-23 Thread Veit Guna
published. >> But I'm quite sure, that this also happened with the account the >> review requests belong to. >> >> Cheers >> Veit >> >> *Gesendet:* Freitag, 18. Dezember 2015 um 00:36 Uhr >> *Von:* "Christian Hammond" >>

Re: GitHub-style review flow

2015-12-23 Thread Veit Guna
. > But I'm quite sure, that this also happened with the account the > review requests belong to. > > Cheers > Veit > > *Gesendet:* Freitag, 18. Dezember 2015 um 00:36 Uhr > *Von:* "Christian Hammond" > *An:* "reviewboard@googlegroups.com" >

Aw: Re: GitHub-style review flow

2015-12-18 Thread Veit Guna
um 00:36 Uhr Von: "Christian Hammond" An: "reviewboard@googlegroups.com" Betreff: Re: GitHub-style review flow Hi Veit,   That definitely seems wrong. These are published review requests, not drafts?   Christian   --  Christian Hammond - christ...@beanbaginc

Re: GitHub-style review flow

2015-12-17 Thread Christian Hammond
Hi Veit, That definitely seems wrong. These are published review requests, not drafts? Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. - https://www.beanbaginc.com On Thu, Dec 17, 2015 at 2:46 PM, Veit Guna wrote: > Hi Christ

Re: GitHub-style review flow

2015-12-17 Thread Veit Guna
Hi Christian. I've applied your patch to my rbt and it seems to work, thanks for that :)! But looking at /review-requests/ shows the requests, but the attributes "branch" and "bugs" are always empty, although these attributes are set on the request. I also changed to values through the UI, but wi

Aw: Re: GitHub-style review flow

2015-12-17 Thread Veit Guna
Wow, thanks Christian - that was quick :)!   I'll take a look at the github hook. Thanks!   Gesendet: Donnerstag, 17. Dezember 2015 um 11:47 Uhr Von: "Christian Hammond" An: "reviewboard@googlegroups.com" Betreff: Re: GitHub-style review flow

Re: GitHub-style review flow

2015-12-17 Thread Christian Hammond
Just for you, Veit: https://reviews.reviewboard.org/r/7812/ I know this isn't a full answer to everything in your e-mail (it's nearly 3AM and I'm about to crash), but this should let you at least use api-get without a local checkout by passing --server=. To answer your last question, the old-styl

GitHub-style review flow

2015-12-17 Thread Veit Guna
Hi. In a project we're using subversion as our SCM. Since I like the GitHub review style very much, I would like to do the same with reviewboard. For this the planned process would look like the following: - The "master" branch is trunk - All code changes are done within separate feature branche