How to deal with a found bug in post-review

2013-01-23 Thread Hyunil Shin
Dear all (This is my first message here). I will use post review (committed in Subversion). While reviewing if I find a bug how can I indicate that a review has a bug? I want to close the review with a kind of bug-tag. for example, I need another close status, bug (currently two status -

Re: How to deal with a found bug in post-review

2013-01-23 Thread David Trowbridge
Do you mean that the posted code has a bug? The intent behind review requests is that they remain open and iterate until the code is either committed or discarded. If you want to indicate that the review request has a bug, post a review with an open issue. The poster then has the opportunity to

Re: How to deal with a found bug in post-review

2013-01-23 Thread Matthew Woehlke
On 2013-01-23 02:48, Hyunil Shin wrote: I will use post review (committed in Subversion). While reviewing if I find a bug how can I indicate that a review has a bug? I want to close the review with a kind of bug-tag. for example, I need another close status, bug (currently two status -

Re: How to deal with a found bug in post-review

2013-01-23 Thread Hyunil Shin
Thank for your reply. yes. My case is to review posted code. So, you mean that if a posted code (review request) has a bug, just still open the request and add an issue. That's good idea. Additionally, I want to distinguish between not-reviewed request and request with a bug. (I have regular

Re: How to deal with a found bug in post-review

2013-01-23 Thread David Trowbridge
We have an open feature request for adding a column which would display the open issues. For now, the best way is probably to add the dashboard column which lists the number of reviews--at least then, you'll be able to see when something has been looked at or not. -David On Wed, Jan 23, 2013

Re: How to deal with a found bug in post-review

2013-01-23 Thread Hyunil Shin
Thank you~ Using the number of reviews may be good. I will discuss with other developers. On Thursday, January 24, 2013 9:12:25 AM UTC+9, David Trowbridge wrote: We have an open feature request for adding a column which would display the open issues. For now, the best way is probably to add