Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread James McDougall
We have previously been using WinDiff (see http://en.wikipedia.org/wiki/File:WinDiff_demonstration.png for example of output) and I have had several folk asking if there are alternatives to the side-by-side approach taken by ReviewBoard - specifically the format used by WinDiff. It's not clear to

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Noah Campbell
I think the short answer is no, but the masters of RB should chime in. The reason being the view and diff technology are unique to RB. -Noah On Mon, Mar 22, 2010 at 4:56 AM, James McDougall wrote: > We have previously been using WinDiff (see > http://en.wikipedia.org/wiki/File:WinDiff_demonstra

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Christian Hammond
Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a

RE: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Dana Lacoste
e release J From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Monday, March 22, 2010 12:00 PM To: reviewboard@googlegroups.com Subject: Re: Is there any flexibility to change the "diff" format for a review? Right, we have our o

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Christian Hammond
legroups.com [mailto:reviewbo...@googlegroups.com] > *On Behalf Of *Christian Hammond > *Sent:* Monday, March 22, 2010 12:00 PM > *To:* reviewboard@googlegroups.com > *Subject:* Re: Is there any flexibility to change the "diff" format for a > review? > > > &g

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Noah Campbell
diffs (and, for the most part, the RB >> built in diff is 1239781092378912% easier to use for small changes anyways J >> ) >> >> >> >> Dana Lacoste >> >> >> >> PS: I know that “download the full file” is a feature on the backlog for >>

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-22 Thread Christian Hammond
imply download the full file, and then users > could > >> use any tool they desire to view the diffs (and, for the most part, the > RB > >> built in diff is 1239781092378912% easier to use for small changes > anyways J > >> ) > >> > >> > >>

Re: Is there any flexibility to change the "diff" format for a review?

2010-03-23 Thread James McDougall
t; >> use any tool they desire to view the diffs (and, for the most part, the > > RB > > >> built in diff is 1239781092378912% easier to use for small changes > > anyways J > > >> ) > > > >> Dana Lacoste > > > >> PS: I know that “down