Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff

2015-06-11 Thread David Trowbridge
You shouldn't have to modify the diff files even if the paths include . and .. For patches generated in the root of the repository, the base directory should never have been ./, but / A patch generated in a subdirectory but trying to give a full file path (such as ../../trunk/path/File.java) shou

Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff

2015-06-11 Thread Papaswede
Some more info here as well. If I generated a diff in /trunk/path and the patch file then ends up with ../../trunk/path/File.java in it, reviewboard is not liking the ../../ and I always get an error that says "../../trunk/path/File.java was not found in the repository", so it seems that it's n

Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff

2015-06-11 Thread Papaswede
Also got some more emails from other users that are generating paths from the IDE, so the path in those diffs may be something like ../root/path/to/File.java and when they try to submit a diff there is no way to get it to work. They were able to make things work in ReviewBoard 1.6.11 by using .

ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff

2015-06-11 Thread Papaswede
I recently upgraded our instance of ReviewBoard from 1.6.11 to 2.0.15. Quite a few people have been reporting issues with uploading diffs that contain ./ as the beginning of the file path and also using ./ as the base directory. They just get an "Unknown Error" on the patch upload screen. For e