It looks like --parent works.
Not sure what I did before, but when I reran a test based on a series of
changes to a single test file, the diffs come out as expected. I didn't try
file deletions/additions just changes within a single file:
- Created a file with three lines
line1
line2
line3
1. interesting. I tried "parent" but it didn't seem to work the way I
expected. It should compare the current revision with the parent revision,
but didn't seem to do that. I suspect I probably did not set up the test
correctly. In any case, I'll give it another try.
On Sat, Oct 30, 2010 at 11:01
If I'm understanding you correctly, you're saying two things:
1. As a new changeset is created by the developer, the developer will update
the review request to be based at the same original revision but with the
set of changesets under review including all of the original changesets
under review +
On Thu, Oct 28, 2010 at 12:46 PM, Andrew Schwartz wrote:
> - have a "rollup" mechanism. As the additional revisions are added, the
> changes are rolled up into one aggregate diff. (I assume this would be very
> complicated code and so might not be doable without significant risk)
>
> What do you
On Thu, Oct 28, 2010 at 12:28 PM, J Arrizza wrote:
> Andrew,
>
> I am still new to RB, and we are looking for something similar as well. We
> have an SCR in our defect tracking system that aggregates all work for
> change. Developers create a series of changesets and then tag each of those
> with
Andrew,
I am still new to RB, and we are looking for something similar as well. We
have an SCR in our defect tracking system that aggregates all work for
change. Developers create a series of changesets and then tag each of those
with the SCR. When it's time to do a code review, we'd like to have
I think that what I'm talking about is the same thing that Eduardo called
"Remodelling diff versioning". Does that seem right to you?
On Tue, Oct 26, 2010 at 7:17 PM, Andrew Schwartz wrote:
> Christian,
>
> Sorry for letting this thread slide for so long.
>
> I'm talking about a review reques
Christian,
Sorry for letting this thread slide for so long.
I'm talking about a review request being for a series of changesets. In our
case, we often will split a single feature change into small, easily
reviewed changesets. It would be nice to be able to put all of these
changesets into a sin
I'm not sure I fully understand the functionality you're asking for, Andrew.
Are we just talking about creating new diffs to replace the old ones? Isn't
that what we have today? Are you asking for that + branch tracking?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://
Andrew,
I'm afraid that won't be possible with the code I'm writing. I'm
basing this on a post-commit style of review. In this scenario, you
would write a new commit E that fixes the issues mentioned on the
review, instead of rewriting the patches.
The model you are suggesting is harder to do on
N
On Tue, Jul 27, 2010 at 4:05 PM, Eduardo Felipe
wrote:
> Sure!
>
> I am working on making the support for DVCS better by implementing the
> following:
>
> Remote branch tracking:
>
> Based on the notion of feature branches one could build around the
> notion of long lived reviews that could be
Sure!
I am working on making the support for DVCS better by implementing the
following:
Remote branch tracking:
Based on the notion of feature branches one could build around the
notion of long lived reviews that could be updated as the code is
updated, all in the Web UI, without having to post
Eduardo, can you give a summary of what you're working on?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, Jul 27, 2010 at 12:33 PM, Andrew wrote:
> Hi all. Please let me know what's going on with DV
Hi all. Please let me know what's going on with DVCS and Review
Board. I know that there are ways to make it work (as we are in my
organization), but it would be nice for it to be better integrated in
the project with reviewing multiple changesets, etc. Thanks.
On Jul 20, 5:40 pm, Andrew wrote
I'm wondering if there has been any progress on the DVCS front. I'd
be very interested in the current design. Is one of the GSOC students
actively working on this?
On Jun 2, 6:08 pm, Christian Hammond wrote:
> Hi James,
>
> Today, each logical change is meant to have its own review request. If
Hi James,
Today, each logical change is meant to have its own review request. If you
have three things that are related but are separately worked on, each should
be put up for review separately. There's no notion of a review request that
encompasses several different changes. I personally think th
Hi, all,
My team now is using the ReviewBoard-1.0.6 which is running on the Cent-OS
server. And this is really fantastic software which help us a lot for code
review.
However, we also found some troubles when doing review.
First, In our project, we need to update the code in more than one compo
17 matches
Mail list logo
