Re: Stack trace when using post-review

2014-08-27 Thread Mehul Sanghvi
The latest version of rbtools does not work with 1.5.6 reviewboard from what I was told. I have tried using them though, and 'rbt post' gives the same "error 103, you're not logged in" message. That was when I was told to use 0.5.7 of rbtools as the latest one is known to not work with reviewbo

Re: Stack trace when using post-review

2014-08-26 Thread David Trowbridge
Can you try using the most recent version of rbtools (and use 'rbt post' instead of 'post-review')? -David On Tue, Aug 26, 2014 at 5:34 PM, Mehul Sanghvi wrote: > > I deleted both and re-tried. I still get the same errors. > > > On Tuesday, August 26, 2014 8:19:20 PM UTC-4, David Trowbridge w

Re: Stack trace when using post-review

2014-08-26 Thread Mehul Sanghvi
I deleted both and re-tried. I still get the same errors. On Tuesday, August 26, 2014 8:19:20 PM UTC-4, David Trowbridge wrote: > > Can you try deleting ~/.post-review-cookies.txt and ~/.rbtools-cookies.txt? > > -David > > > On Tue, Aug 26, 2014 at 5:13 PM, Mehul Sanghvi > wrote: > >> reviewbo

Re: Stack trace when using post-review

2014-08-26 Thread David Trowbridge
Can you try deleting ~/.post-review-cookies.txt and ~/.rbtools-cookies.txt? -David On Tue, Aug 26, 2014 at 5:13 PM, Mehul Sanghvi wrote: > reviewboard: 1.5.6 > rbtools: 0.5.7 > python: 2.7.8 > os: debian/testing > > I am trying to use post-review to create a diff that I can upload to RB. >

Stack trace when using post-review

2014-08-26 Thread Mehul Sanghvi
reviewboard: 1.5.6 rbtools: 0.5.7 python: 2.7.8 os: debian/testing I am trying to use post-review to create a diff that I can upload to RB. I do the following: bash% post-review -dn pom.xml and I get the following stack trace: >>> Python 2.7.8 (default, Aug 18 2014, 10:01:58) [GCC 4.

Re: Error using post-review and Reviewboard 1.7.25

2014-06-19 Thread Christian Hammond
(daniel.j.la...@googlemail.com) wrote: All, We are currently using post-review and Reviewboard 1.7.25 (RBtools 0.5.1). We added a new Repo to Reviewboard and its listed as repository 26. However when we try to post a new review to Reviewboard we get: DEBUG:root:repository info: Path: http://server

Error using post-review and Reviewboard 1.7.25

2014-06-18 Thread Daniel Laird
All, We are currently using post-review and Reviewboard 1.7.25 (RBtools 0.5.1). We added a new Repo to Reviewboard and its listed as repository 26. However when we try to post a new review to Reviewboard we get: DEBUG:root:repository info: Path: http://server/svn/repo_name, Base path: /trunk

Re: Authentication to Reviewboard Server using post-review from Client host

2013-11-18 Thread Christian Hammond
server=rbServer > --submit-as=user --target-people= users" > > > but of the client host rebooted ,then post-review has to authenticate to > RB server again using "post-review --tracking-branch branch_name > --server=rbServer --submit-as=user --target-people= users -*-use

Authentication to Reviewboard Server using post-review from Client host

2013-11-18 Thread Akshaya Samantaray
--target-people= users" but of the client host rebooted ,then post-review has to authenticate to RB server again using "post-review --tracking-branch branch_name --server=rbServer --submit-as=user --target-people= users -*-username= user_Unix_ID"* My question is how can client

Re: Reviewed Board-Not able to see diff files when submitted a review request using post-review with perforce on windows

2013-07-28 Thread RB
When i try to post a review request of already submitted changelist using post-review , the request is getting successfully posted. But when you view the review request on Review Board server i am getting diff currently unavailable next to file and whin i click the details i am getting the

Re: Reviewed Board-Not able to see diff files when submitted a review request using post-review with perforce on windows

2013-07-28 Thread RB
When i try to post a review request of already submitted changelist using post-review , the request is getting successfully posted. But when you view the review request on Review Board server i am getting diff currently unavailable next to file and whin i click the details i am getting the

Re: Reviewed Board-Not able to see diff files when submitted a review request using post-review with perforce on windows

2013-07-27 Thread Ajai Lanka
I have posted the pending changelist number only. When i was able to see the review request on review board why am i not able to see the diff files. Should i need to do some admin settings in Review Board server for the diffs to be visible. On Fri, Jul 26, 2013 at 11:39 PM, David Trowbridge wrote

Re: Reviewed Board-Not able to see diff files when submitted a review request using post-review with perforce on windows

2013-07-26 Thread David Trowbridge
Was the changelist you posted pending or submitted? The basic "post-review changelist" command syntax is really only useful for pending changes, and the more-complicated --revision-range parameter. -David On Fri, Jul 26, 2013 at 2:15 AM, RB wrote: > I have successfully set-up Bitnami review bo

Reviewed Board-Not able to see diff files when submitted a review request using post-review with perforce on windows

2013-07-26 Thread RB
I have successfully set-up Bitnami review board stack on windows 64-bit. I have added a perforce repository on admin panel. I ran *post-review changelist *command to post a review request . It is showing that the review request is successfully posted. When i log-in to Review Board server i am a

Re: Error using post-review or rbt post

2013-06-21 Thread David Trowbridge
Is there anything in the reviewboard log? -David On Fri, Jun 21, 2013 at 12:23 AM, Francisco José García Rico wrote: > Hi, > I am trying to set up review board to start to do code reviews in my > organization. I have already installed properly the review board site > server but right now I am

Error using post-review or rbt post

2013-06-21 Thread Francisco José García Rico
Hi, I am trying to set up review board to start to do code reviews in my organization. I have already installed properly the review board site server but right now I am having problems installing RBTools in my machine as developer. Every time I try to post a review using the commands "rbt post

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2013-03-04 Thread Nachiketh G
t;>> > > Hi Jonathan, >>> > >>> > > So the key part seems to be here: >>> > >>> > > >>> Using changenums onReviewBoard 1.5.2. Falling back to the >>> deprecated >>> > >>> > > 1.0 API >&g

Re: Using post-review --diff-filename

2012-12-11 Thread Yuriy Svystun
You can try (in Ubuntu): *1. Create diff file from existing 2 commits* (*f6f51483e608c1* - hash of 1-st commit (not full length), *b48fd401d27874* - hash of 2-nd commit (not full length)). devel3@devel3:~/$ git diff --full-index *f6f51483e608c1* *b48fd401d27874* > tmp.diff *2. Post to Review

Re: Error using post-review with git

2012-12-04 Thread Matthew Woehlke
On 2012-12-03 09:41, Paul Albertella wrote: I'm getting a confusing error when I try to run post-review Failed to execute command: ['git', 'config', 'core.bare'] I've tried running this command directly in the repository (a non-bare clone) and it simply returns. That could mean the value i

Re: Problem when using post-review to upload diff file

2012-12-03 Thread Ting Han Shen
www.reviewboard.org/docs/codebase/dev/getting-started/#rbtools TingHan On Monday, December 3, 2012 2:37:36 PM UTC+8, Ting Han Shen wrote: > > Hi, > > I have a problem looks like about base path when using post-review and I > cannot figure it out how to make > post-review using the r

Error using post-review with git

2012-12-03 Thread Paul Albertella
Hi, I'm getting a confusing error when I try to run post-review Failed to execute command: ['git', 'config', 'core.bare'] I've tried running this command directly in the repository (a non-bare clone) and it simply returns. I'm not sure what response the script is expecting. I'm using git ver

Problem when using post-review to upload diff file

2012-12-03 Thread Ting Han Shen
Hi, I have a problem looks like about base path when using post-review and I cannot figure it out how to make post-review using the right base path. I had tried to change the path of REPOSITORY to "http://svn.repos"; both in the configuration of ReviewBoard and .reviewboardrc, and

Re: Error 207 when using post-review with github

2012-10-22 Thread Bob Froehlig
We are having the same issues with review board 1.6.12 and mecurial repositories. It's especially prevalent when attempting to automate review requests from repositories receive updates to branches. Also, the file that is "missing" seems to be different on subsequent attempts. Bob Froehlig, Rapid

Re: Error 207 when using post-review with github

2012-10-22 Thread Michael Pechner
I have the same issue. Installed latest greatest today Yeah, XX and YY are masks to protect the innocent. [mpechner@mpechner-lt-1 svn]$ post-review --debug rooturl.properties > >>> RBTools 0.4.2 > >>> Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23) > [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] > >

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
On Wednesday, June 20, 2012 8:34:41 AM UTC+2, Christian Hammond wrote: > > Which version of RB though? This is important as GitHub made some major > changes recently that are only compatible with the latest 1.6.x releases. > > Christian > > Aha, we're still on 1.6.4.1. I'll ask our sysadmin to upd

Re: Error 207 when using post-review with github

2012-06-19 Thread Christian Hammond
Which version of RB though? This is important as GitHub made some major changes recently that are only compatible with the latest 1.6.x releases. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jun 19,

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
BTW, I just tried uploading the diff manually (no parent diff) and I get exactly the same error message about the file not being in the repo. The only thing I can think of is perhaps their are some Windows line endings in the file. Would that bother RB? -- Want to help the Review Board project

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
it and now I want to post a review request for the diff between my changeset and its parent on master. I'm probably doing something obviously wrong. Are there step-by-step instructions somewhere on how to post a review from github using post-review? On Tuesday, June 19, 2012 9:28:55 PM U

Re: Error 207 when using post-review with github

2012-06-19 Thread Christian Hammond
What version of Review Board are you using? Are you working off of a branch off origin/master, or another upstream branch? You can try --upstream-branch to specify the right one. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://

Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
I'm trying to post a review request for a changeset I created on a new branch of our public github repo. Since I already committed the change, I enter: $ post-review --parent 5f7fc000274abab9cbfb7a00a5b9602314ae6268 I'm getting the dreaded 207 (the file was not found in the repository) error.

Re: Using post-review with CVS commitinfo

2012-01-25 Thread Tom
I'm still interested in what you find. Looking through the source code for post-review, it appears that the CVS failure is occurring because post-review cannot find CVS/Root in the working directory. I can work around that issue -- there appear to be others -- in my commit hook script, but it make

Re: Using post-review with CVS commitinfo

2012-01-20 Thread zhibin wang
reviewed. just have a test. thank you. On 1月12日, 上午4时52分, Tom wrote: > I need help with a problem with post-review when it's invoked within > commitinfo under CVS. CVS and RB 1.6.3 are running on separate Linux > servers. RBtools are installed on the CVS server. I have an apparently > valid repos

Using post-review with CVS commitinfo

2012-01-13 Thread Tom
I need help with a problem with post-review when it's invoked within commitinfo under CVS. CVS and RB 1.6.3 are running on separate Linux servers. RBtools are installed on the CVS server. I have an apparently valid repository definition in the RB admin web interface, the path for which is: :pserve

Re: Using post-review --diff-filename

2011-10-10 Thread Christian Hammond
Hi, Review Board requires that you have a repository backing any given diff. You won't be able to do a review of any arbitrary uploaded diff. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Oct 10, 201

Using post-review --diff-filename

2011-10-10 Thread Mikhail
Hi, I was looking for a way to use review board for reviewing changes not associated with any of the repositories. post-review --diff-filename was the first thing I tried, however it seems to require a repository both to upload and process the diff. Does anyone know if there are any other options

Re: Using post-review and a git repository with different developer / anonymous GIT URL?

2011-08-06 Thread Christian Hammond
Hi Reinhold, Assuming all review requests will be made against the main repository, what you want to do is have the Path be the anonymous URL, and then to have the .reviewboardrc using the name you configure for the repository. This is done with the REPOSITORY setting: http://www.reviewboard.org/

Using post-review and a git repository with different developer / anonymous GIT URL?

2011-08-06 Thread Reinhold Kainhofer
I'm currently evaluating Reviewboard for use by lilypond, which uses the gnu.org GIT server (savannah.gnu.org). Unfortunately, there are different git URLs for anonymous access and for developers: The anonymous GIT URL is: git://git.sv.gnu.org/lilypond.git The URL used by developers with pu

Re: Using post-review

2011-07-15 Thread Joe Lencioni
I think I figured this out. Essentially, we were using git without a centralized repository. I believe that reviewboard doesn't like this. So, I set up a directory on our server to act as a central repository and then cloned our repositories into there using the --bare option: cd /path/to/new/

Re: Using post-review

2011-07-15 Thread Joe Lencioni
I am having the exact issue that Rajat was. I'm guessing that it is simply a matter of me not understanding exactly how reviewboard works. Here's what post-review --debug gives me: post-review --debug >>> RBTools 0.3.2 >>> Home = /path/to/home/dir >>> svn info >>> git rev-parse --git-dir >>> git

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-06-03 Thread Nilesh Jaiswal
;>> Using changenums onReviewBoard 1.5.2. Falling back to the >> deprecated >> > >> > > 1.0 API >> > >> > > It almost looks like it's still running 1.5.2. Can you go >> tohttp://yoursite/reviews/api/info/andsee what version the API is cla

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-06-02 Thread Christian Hammond
ch what you see when going to the web UI? > > > > > Christian > > > > > -- > > > Christian Hammond - chip...@chipx86.com > > >ReviewBoard -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > > On Wed, A

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-06-01 Thread nileshritu
> > > Christian > > > -- > > Christian Hammond - chip...@chipx86.com > >ReviewBoard -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > On Wed, Apr 20, 2011 at 4:19 AM, Jonathan > > > wrote: > > > Hi there, > &

There was an error when I using post-review with perforce(p4v)

2011-06-01 Thread jh5774....@samsung.com
Well, Good evening, everybody(I'm live in GMT+9). I found an error about post-review in Linux os. (But maybe windows have same error) The situation is, Using perforce (P4V), and tool's status is not logged on. In this time, trying to use 'Post-review', then 'Post-review' is frozen. I need som

Re: Can't post subversion diff using post-review

2011-05-18 Thread Tucker
There appears to have been an auth problem with my installation. Since this is still in testing, I blew it away and started over. I'll likely step through the same changes I made prior and see if I can nail down what caused the actual issue. If I figure it out, I'll post here so that there's an a

Can't post subversion diff using post-review

2011-05-17 Thread junk
I'm working on a brand new instance of Review Board that I'd like to demo. I got Review Board 1.6 beta 2 up and running but I can't get post-review to work. The server is configured to use LDAP auth (working) and fastcgi. Here's the trace I'm getting when trying to run post-review: """ $ post-r

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-04-25 Thread Jonathan
om my Python site-packages directory and reinstalling 1.6 beta 1 but I still get the same problem using post-review with the "Using changenums on Review Board 1.5.2. Falling back to the deprecated 1.0 API" message. I'm probably going to revert back to our previous Review Board installa

Re: Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-04-20 Thread Christian Hammond
of Review Board V1.5.2 but > curiosity got the better of me and I attempted to upgrade to V1.6 > Beta1. Everything seemed to work great (btw collapsible reviews are > awesome) until we tried to post reviews using post-review (RBTools > V0.3.2) as Perforce is our SCM tool. Command prompt

Page not found (404) when using post-review after upgrade to V1.6 Beta1

2011-04-20 Thread Jonathan
Hi there, We had a perfectly good Windows install of Review Board V1.5.2 but curiosity got the better of me and I attempted to upgrade to V1.6 Beta1. Everything seemed to work great (btw collapsible reviews are awesome) until we tried to post reviews using post-review (RBTools V0.3.2) as Perforce

Re: Using post-review in git's bare repository

2011-03-28 Thread Jan Koprowski
Dan, I'm aware of post-review's purpose. Never the less I need something running git-hook. I'm already writing a patch which looks work fine. I hope I finish this - maybe today. Greetings, Jan On Tue, Mar 29, 2011 at 4:50 AM, Dan Savilonis wrote: > Hi Jan, > > The intent of the post-review def

Re: Using post-review in git's bare repository

2011-03-28 Thread Dan Savilonis
Hi Jan, The intent of the post-review default behavior is to attempt to automatically produce a diff of the user's current work. So, it will look for commits not merged into the tracking branch for the current branch. For a bare repository, this no longer makes sense. I would think only the explic

Re: Using post-review in git's bare repository

2011-03-24 Thread Christian Hammond
Really? I'm curious about this because I couldn't even generate a diff in a bare repository, and from a google search, it seemed other people were also under the impression that you needed an actual checkout. If it can be made to work, I'm definitely all for including it. That'd be much better tha

Re: Using post-review in git's bare repository

2011-03-24 Thread Jan Koprowski
Isn't true. I already wrote little (3 lines?) patch which allow generate diffs for parent branch from bare-repo but I want to test it in fire of war before I send code to review. Everything looks good so it is possible. Will be good in future if post-review will be tested and modified to work al

Re: Using post-review in git's bare repository

2011-03-24 Thread Christian Hammond
Hi Jan, post-review needs to generate diffs from code in the tree. If it's a bare tree, there's not really much to generate. It doesn't have the objects for which to generate those diffs. If you try to run 'git diff', I think you'll hit the same problems. Christian -- Christian Hammond - chip..

Re: Using post-review in git's bare repository

2011-03-23 Thread Jan Koprowski
Hi! Because I must figure out how use post-review with git bare repositories I start working on it. Running post-review inside bare-repository ands with: $post-review -n -d --parent b --server http://localhost:8080/ >>> svn info >>> git rev-parse --git-dir >>> git symbolic-ref -q HEAD Failed t

Using post-review in git's bare repository

2011-03-11 Thread Jan Koprowski
Hi! Is there way to use post-review inside bare repository not working copy? Greetings from Poland! -- ><> Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~---

Re: Weird problem using post-review tool on windows

2010-11-10 Thread Christian Hammond
Can you run with --debug and provide the results? It'll help to see what exactly is being accessed. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Nov 10, 2010 at 5:20 PM, asawhney wrote: > Running t

Weird problem using post-review tool on windows

2010-11-10 Thread asawhney
Running the post-review tool on my Windows Vista 64 bit machine gives me error "HTTP 404" or "HTTP 503". But, if I execute the same command with "Fiddler" running then it executes fine. I have tried disabling the firewall as well, but, doesn't help. Moreover, I can work with ReviewBoard via the bro

Re: How to post an brand-new file for reviewing using post-review

2010-10-07 Thread gauri.khandekar
Reviewboard. > > How can I send this new file for reviewing using post-review ? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~---

How to post an brand-new file for reviewing using post-review

2010-10-06 Thread gauri.khandekar
I have to add a new file into perforce. (I am adding it for the first time, NO old traces of the file available in Perforce) Before I add and commit the file to perforce, I want to get it reviewed using Reviewboard. How can I send this new file for reviewing using post-review ? -- Want to

Re: Using post-review

2010-09-14 Thread Christian Hammond
Run post-review with the --debug parameter and paste the output. It should provide some additional information. What happens if you run 'git config remote.origin.url' in that directory? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. -

Re: Error creating review request using post-review

2010-08-10 Thread ReviewBoard User
Hi Christian I managed to get it working as below (just in case these tips come handy for anyone else) My working env is 1) ReviewBoard 1.5 installed on RHEL4 with Python 2.4, Subversion 1.4 server, Apache 2.2, Django 1.2 2) Tortoise SVN Client on Windows (1.6) to access SVN over https only. (http:

Re: Error creating review request using post-review

2010-08-10 Thread Christian Hammond
What happens if you use a fully-qualified domain? Say, server.yourdomain.com. This sounds like a cookie storage issue. I don't believe Python's HTTP library stores cookies for non-fully-qualified domains, though I'd hope it would at least work for that session... Christian -- Christian Hammond -

Error creating review request using post-review

2010-08-09 Thread ReviewBoard User
1. ReviewBoard 1.5 2. Apache 2.2 3. SVN 1.4 4. Python 2.4 Am trying to post a review on a post-commit hook from subversion Running the below command /usr/bin/post-review --server=http://server/reviewboard/ --repository- url=file:///var/svn/repositories/sandbox/ --username=svn '-- password=svn' '--

Re: Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread LukeRobison
Patch submitted as http://reviews.reviewboard.org/r/1393/ The change was almost too simple. I only updated documentation and changed the logic that verifies the options have been specified correctly. -Luke On Feb 5, 4:12 pm, Christian Hammond wrote: > Hi Luke, > > The --repository-url paramete

Re: Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread Christian Hammond
Hi Luke, The --repository-url parameter was implemented for the purpose of post-commit support. It was also before the addition of --diff-filename (a very recent option). I'd be more than happy to have support for --diff-filename with --repository-url. We'll likely need a patch for it, though, as

Using post-review outside of a working copy to upload a diff file

2010-02-05 Thread LukeRobison
First off, I'm using svn on linux. Second, google seems to refuse to let me search this newsgroup (500: server error), so I apologize if this question has been asked before/recently. I'm attempting to use the post-review tool to upload diff files from outside a working copy. I tried to simply u

Re: Access is denied using post-review with ClearCase under Cygwin

2010-01-27 Thread Jan Koprowski
Maybe someone want to know. Actually I not pretty sure which change made that all start working. I just describe my configuration. I use Vobs which location is somewhere in company's network on clearcase servers. I use Python 2.5.4 and made my changes in C: \Python25\Lib\site-packages\RBTools-0.

Re: Access is denied using post-review with ClearCase under Cygwin

2010-01-26 Thread Jan Koprowski
After use dynamic view and made changes in ClearCaseClient class in postreview I stop getting this problem. On Jan 25, 5:14 pm, Jan Koprowski wrote: > Hi! > >   On the beginning I want to say that ReviewBoard is great tool. The > best I have ever seen. Excellent job! >   I'am trying to use Review

Re: Problems using post-review to upload diff

2009-12-20 Thread Christian Hammond
t; This post is related to another titled "Problems using API to load > > > diff" on 12/16/2009. > > > As in that post, I'm trying to create an automated post-commit review > > > monitor. > > > In this post I document the approach of using post-revi

Re: Problems using post-review to upload diff

2009-12-20 Thread Jim0000001
rg > VMware, Inc. -http://www.vmware.com > > > > On Sat, Dec 19, 2009 at 1:17 PM, Jim001 wrote: > > This post is related to another titled "Problems using API to load > > diff" on 12/16/2009. > > As in that post, I'm trying to create an automated

Re: Problems using post-review to upload diff

2009-12-19 Thread Christian Hammond
, Dec 19, 2009 at 1:17 PM, Jim001 wrote: > This post is related to another titled "Problems using API to load > diff" on 12/16/2009. > As in that post, I'm trying to create an automated post-commit review > monitor. > In this post I document the approach of using post-r

Problems using post-review to upload diff

2009-12-19 Thread Jim0000001
This post is related to another titled "Problems using API to load diff" on 12/16/2009. As in that post, I'm trying to create an automated post-commit review monitor. In this post I document the approach of using post-review to generate my reviews. I'm using ReviewBoard 1.0.4 w

Using post-review to post a review for a path and revision

2009-08-24 Thread Dave Hocker
We use Perforce. Normally, we post reviews by change list. However, while reading through the online documentation for post-review use with Perforce, I noticed a section about "Posting Paths". The ability to post a review on a range of revisions (say for file rev 10 to 15) would be useful. The tex

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Finally it worked. I've carefully read the automatingpost-review section, but I misunderstood some permission. I still don't think I understand it now, but at least, when I assign everything to the logged user (who submits on be half of another user), it worked. Some suggestions: 1. The permi

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Christian Hammond
Looks like we're not properly checking whether there's an error and assuming it's a draft. Certainly a bug. If you can file this backtrace in a bug report, that would be helpful. The problem is that the user specified doesn't have permission to modify that review request. The code that checks that

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Oops, I didn't realize that ReviewBoard sent me an email. Notice that I'm NOT using the nightly built ReviewBoard (I just used easy_install ReviewBoard). Is that because attribute "target_groups" has been renamed? - Rujia = Email begins == Title: [Django] Error (EXTERNAL IP

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Christian Hammond
Hi Rujia, You can get more detailed debugging information by setting DEBUG = True in Review Board's conf/settings_local.py. Then restart the web server and try again. You'll get an HTML error dump with a backtrace. We can take a look at the error dump if the problem isn't obvious. It would be goo

Re: Using post-review in svn's post-commit hook

2009-08-20 Thread Rujia Liu
Hi! Thanks, Christian. I've updated to the newest nightly build. Now I have found the reason. Thanks to the -d option, I saw the last command that post-review has executed: svn diff --diff-cmd=diff http://mysvnserver/@xxx http://mysvnserver/@HEAD I manually executed it and it asked me for the pa

Re: Using post-review in svn's post-commit hook

2009-08-19 Thread Christian Hammond
Hi Rujia, This might be fixed in the nightlies. Can you try a nightly build from http://downloads.review-board.org/nightlies/ and see if this fixes the problem? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com

Using post-review in svn's post-commit hook

2009-08-19 Thread rujia
Hi! I'm writing a script to automatically post a review request for every revision, using svn's post-commit hook. When I run this: post-review -d -p --server=http://myrbserver --target-group=xxx -- revision-range=xxx --submit-as=someone --username=submitter -- password=submitter --repository-url

Re: Using post-review with git and gitosis

2009-08-12 Thread Christian Hammond
Mware, Inc. - http://www.vmware.com On Wed, Aug 12, 2009 at 3:26 PM, Kate Ebneter wrote: > Hi, > > We're evaluating Review Board and we're having trouble using post-review > with git repositories. Basically, we keep getting an error that looks like > this: > > >&g

Using post-review with git and gitosis

2009-08-12 Thread Kate Ebneter
Hi, We're evaluating Review Board and we're having trouble using post-review with git repositories. Basically, we keep getting an error that looks like this: >>> HTTP POSTing to http://reviews.ninginc.com/api/json/reviewrequests/new/: {'repository_path': '

Re: 'git svn info' when using post-review and git?

2009-07-10 Thread Dan Savilonis
Are you using post-review on a regular git repository? The check is there to determine if it is a git-svn repository (git repository that synchronizes with svn). I think it needs to come first because you can't directly check that a repository is pure git. Since git-svn is a perl scri

'git svn info' when using post-review and git?

2009-07-08 Thread Petter Måhlén
Hi, Using post-review feels like it is a bit slower than necessary, and when using the --debug flag, it seems as if one of the main culprits is the execution of 'git svn info'. It takes several seconds to run for me. I am guessing it is used for 'git on top of SVN'?

Re: Using post-review

2009-06-27 Thread Dmitry Portnoy
I figured out that post-review gets the repository path from .hg/hgrc, so I changed the entry in that file to match the repo path specified in reviewboard and everything works. On Jun 25, 11:06 am, Dmitry Portnoy wrote: > After playing around with post-review, here's some more information > that

Re: Using post-review

2009-06-25 Thread Dmitry Portnoy
After playing around with post-review, here's some more information that may be helpful in solving the problem. I have 3 different repos set up on the server (one is the trunk and two are user branches). URLLocal Path http://12.245.678.912/h

Re: Using post-review

2009-06-24 Thread Dmitry Portnoy
It says (with the ip replaced): >>> svn info >>> hg root >>> hg svn info >>> repository info: Path: http://12.345.678.912/hg, Base path: , Supports >>> changesets: False >>> hg diff -r 8e4c07f8e1b8 -r tip >>> Looking for '12.345.678.912 /reviews/' cookie in >>> /home/dportnoy/.post-review-cooki

Re: Using post-review

2009-06-24 Thread Christian Hammond
Can you run post-review with --debug? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Jun 24, 2009 at 9:23 PM, Dmitry Portnoy wrote: > > 'hg root' exactly matches the Path entry for the repo on the s

Re: Using post-review

2009-06-24 Thread Dmitry Portnoy
'hg root' exactly matches the Path entry for the repo on the server. On Jun 25, 12:11 am, Christian Hammond wrote: > Hi, > > The result of 'hg root' needs to match either the Path or Mirror Path > entries for the Repository on the server in order to work. You'll want to > make sure they're ident

Re: Using post-review

2009-06-24 Thread Christian Hammond
Hi, The result of 'hg root' needs to match either the Path or Mirror Path entries for the Repository on the server in order to work. You'll want to make sure they're identical. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://

Using post-review

2009-06-24 Thread Dmitry Portnoy
I'm trying to get post-review working, but whenever I run it, I get "Error creating review request: The repository path specified is not in the list of known repositories (code 206)". The exact command I run is: post-review --username=XXX --password=XXX --server=XXX --revision- range=XXX:XXX I

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-30 Thread Sandy Armstrong
Stefan, I'm not entirely sure what you're trying to do. My patch is designed to allow reviews for changes to release branches on SVN. So let's say new development is in trunk, and 1.0 maintainenece is in a "1.0" branch on SVN. You have a Reviewboard server configured with your SVN repository,

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-30 Thread housemaister
Hi, I'm in a similar (but not completely same) situation and I tried your patch, but it did not work for me. I have to admit I'm quite new to reviewboard and git, too, and I'm not sure if I use it the right way. My situation is the following: I have a svn trunk, a svn branch (let's call it mybra

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-29 Thread Sandy Armstrong
I think I have reduced this to a much simpler explanation in the following new issue, if anybody is interested: http://code.google.com/p/reviewboard/issues/detail?id=999 Conclusion: either --parent is slightly broken in how the server processes it, or I'm using it wrong in the first place. If I

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-24 Thread Sandy Armstrong
On Mar 23, 6:07 pm, Christian Hammond wrote: > Hey Sandy, > > Couple questions. First, is "git-svn/branches/post-1.0-research" the name of > the actual branch in git? Yes, that is the name that shows up when I do "git branch -a". > The filename in that path definitely seems screwed up. It shows

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-23 Thread Christian Hammond
Hey Sandy, Couple questions. First, is "git-svn/branches/post-1.0-research" the name of the actual branch in git? The filename in that path definitely seems screwed up. It shows the filename as the parent directory of itself. So maybe there's some processing that's broken there. That parent diff

Re: Problem using post-review when parent_diff has "deleted" files

2009-03-23 Thread Sandy Armstrong
On Mar 23, 5:26 pm, Sandy Armstrong wrote: > I am going to try merging the latest trunk changes into the branch > again and see if I still have this problem.  Otherwise I'm not really > sure what to do. Well, I did the merge, so the file is no longer missing in the branch, and I've worked around

Problem using post-review when parent_diff has "deleted" files

2009-03-23 Thread Sandy Armstrong
Hello, I'm testing out the use of git-svn with an instance of Review Board 1.0 Alpha 4. I'm currently getting an error from the server if my parent_diff contains the deletion of a file (because the file only exists in trunk/master, not in the branch/remote). I don't have enough access to debug