can't add comments

2013-04-25 Thread Matthew Woehlke
When I go to https://git.reviewboard.kde.org/r/110059/ and click 'review' or 'add comment', nothing happens. Looking at a web console, I see: SyntaxError: Unexpected token ';' /r/110059/:40 ReferenceError: Can't find variable: gReviewRequestId /static/rb/js/reviews.min.8dcc237657b9.js:112

Re: can't add comments

2013-04-25 Thread Christian Hammond
Hi Matthew, There was a report just a few days ago about this. What's odd is that nothing around these lines have changed in about 6 months. I do, however, see why it's causing a javascript error. The code to set the default for gOpenAnIssue is not being set. Why this is suddenly happening, I

Re: can't add comments

2013-04-25 Thread Matthew Woehlke
On 2013-04-25 15:03, Christian Hammond wrote: There was a report just a few days ago about this. What's odd is that nothing around these lines have changed in about 6 months. I do, however, see why it's causing a javascript error. The code to set the default for gOpenAnIssue is not being set.

Re: can't add comments

2013-04-25 Thread Christian Hammond
On Thu, Apr 25, 2013 at 12:08 PM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-04-25 15:03, Christian Hammond wrote: There was a report just a few days ago about this. What's odd is that nothing around these lines have changed in about 6 months. I do, however, see why it's causing

Re: can't add comments

2013-04-25 Thread Matthew Woehlke
On 2013-04-25 15:16, Christian Hammond wrote: Very strange. It'd be one thing if I saw any reports of this back when the related feature was shipped (1 year ago!), but to just start seeing them now... Well, I also probably have not logged in for that long :-). Maybe it is only affecting users

Re: can't add comments

2013-04-25 Thread Christian Hammond
On Thu, Apr 25, 2013 at 12:40 PM, Matthew Woehlke mwoehlke.fl...@gmail.comwrote: On 2013-04-25 15:16, Christian Hammond wrote: Very strange. It'd be one thing if I saw any reports of this back when the related feature was shipped (1 year ago!), but to just start seeing them now... Well, I