Re: Issue 1488 in reviewboard: Storing review request number in .git/config

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: component-RBTools Comment #1 on issue 1488 by chipx86: Storing review request number in .git/config http://code.google.com/p/reviewboard/issues/detail?id=1488 I could see this as being useful. The trick will be to not leave IDs around

Re: Issue 1485 in reviewboard: Newby issues: RB 1.1 alpha 2

2010-02-21 Thread reviewboard
Updates: Status: NotABug Owner: chipx86 Labels: -Type-Defect Type-Support Comment #1 on issue 1485 by chipx86: Newby issues: RB 1.1 alpha 2 http://code.google.com/p/reviewboard/issues/detail?id=1485 This is best sent to the mailing list, but to answer your questions: 1)

Re: Issue 1486 in reviewboard: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change

2010-02-21 Thread reviewboard
Updates: Labels: -Priority-Medium Priority-High Milestone-Release1.5 Component-DiffViewer Interdiffs Comment #1 on issue 1486 by chipx86: Diff viewer displays incorrectly diffs for files which were removed in later revision of the change

Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode

2010-02-21 Thread reviewboard
Updates: Labels: Milestone-Release1.5 Comment #13 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail?id=1476 (No comment was entered for this change.) -- You received this message because you

Re: Issue 1491 in reviewboard: LDAP group support

2010-02-21 Thread reviewboard
Updates: Labels: Component-Accounts Component-Reviews Comment #1 on issue 1491 by chipx86: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 This is pretty specific to certain setups and is certainly not something we'd want to make default. If we do this,

Re: Issue 768 in reviewboard: When you upload multiple diffs before publishing a review request, discard all diffs except the last one

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 768 by chipx86: When you upload multiple diffs before publishing a review request, discard all diffs except the last one http://code.google.com/p/reviewboard/issues/detail?id=768 This hasn't been a problem for a while. It's fixed these days.

Re: Issue 1502 in reviewboard: post-review.py generated review request notification emails have wrong sender and signature

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Component-EMail Comment #1 on issue 1502 by chipx86: post-review.py generated review request notification emails have wrong sender and signature http://code.google.com/p/reviewboard/issues/detail?id=1502 Makes sense. --

Re: Issue 1501 in reviewboard: Download diff for changesets containing changes to only one file are missing diff headers

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Component-DiffParser Milestone-Release1.5 Comment #3 on issue 1501 by chipx86: Download diff for changesets containing changes to only one file are missing diff headers http://code.google.com/p/reviewboard/issues/detail?id=1501 This is

Re: Issue 1501 in reviewboard: Download diff for changesets containing changes to only one file are missing diff headers

2010-02-21 Thread reviewboard
Updates: Status: WontFix Comment #4 on issue 1501 by chipx86: Download diff for changesets containing changes to only one file are missing diff headers http://code.google.com/p/reviewboard/issues/detail?id=1501 Scratch that. We only put the headers there if it's an empty file (to

Re: Issue 1499 in reviewboard: post-review tool can't use some forms of CVS/Root entries

2010-02-21 Thread reviewboard
Updates: Status: NeedInfo Labels: Component-RBTools Comment #2 on issue 1499 by chipx86: post-review tool can't use some forms of CVS/Root entries http://code.google.com/p/reviewboard/issues/detail?id=1499 Can you submit a patch to http://reviews.reviewboard.org/ ? -- You

Re: Issue 1497 in reviewboard: post-review tool doesn't support certain CVS formats

2010-02-21 Thread reviewboard
Updates: Status: Invalid Comment #1 on issue 1497 by chipx86: post-review tool doesn't support certain CVS formats http://code.google.com/p/reviewboard/issues/detail?id=1497 There's no info in here about what's wrong or why. Assuming this is replaced by bug 1499. Otherwise, please

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #1 on issue 1494 by chipx86: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 Upgrade to

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1279 Comment #2 on issue 1494 by chipx86: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 (No comment was

Re: Issue 1279 in reviewboard: post-review on windows assumes pre-vista hard coded path

2010-02-21 Thread reviewboard
Comment #6 on issue 1279 by chipx86: post-review on windows assumes pre-vista hard coded path http://code.google.com/p/reviewboard/issues/detail?id=1279 Issue 1494 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue,

Re: Issue 1473 in reviewboard: Upload diff including binary file failed with postreview.py

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #1 on issue 1473 by chipx86: Upload diff including binary file failed with postreview.py http://code.google.com/p/reviewboard/issues/detail?id=1473 It sounds like your version of RBTools/post-review is quite old. Please

Re: Issue 1468 in reviewboard: rb-site install giving error make sure you are running as administrator

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Comment #2 on issue 1468 by chipx86: rb-site install giving error make sure you are running as administrator http://code.google.com/p/reviewboard/issues/detail?id=1468 The error should be changed. Basically it wants to

Re: Issue 1471 in reviewboard: Groups page has a error

2010-02-21 Thread reviewboard
Comment #2 on issue 1471 by chipx86: Groups page has a error http://code.google.com/p/reviewboard/issues/detail?id=1471 Issue 1464 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue.

Re: Issue 1464 in reviewboard: All Groups button crashes app if no starred entry

2010-02-21 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1471 Comment #2 on issue 1464 by chipx86: All Groups button crashes app if no starred entry http://code.google.com/p/reviewboard/issues/detail?id=1464 (No comment was entered for this change.) -- You received this message because you

Re: Issue 1460 in reviewboard: post-review fails when current branch is called tracking remote branch

2010-02-21 Thread reviewboard
Updates: Status: Fixed Labels: Component-RBTools Comment #2 on issue 1460 by chipx86: post-review fails when current branch is called tracking remote branch http://code.google.com/p/reviewboard/issues/detail?id=1460 This should be fixed in RC1. -- You received this message

Re: Issue 1458 in reviewboard: User View on site button has broken path

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: -Priority-Medium Priority-Low Milestone-Release1.5 Component-Admin Comment #1 on issue 1458 by chipx86: User View on site button has broken path http://code.google.com/p/reviewboard/issues/detail?id=1458 (No comment was entered for this

Re: Issue 1450 in reviewboard: Attempt to mark closed review submitted again yields Internal error: 200 OK

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 Component-Reviews Comment #1 on issue 1450 by chipx86: Attempt to mark closed review submitted again yields Internal error: 200 OK http://code.google.com/p/reviewboard/issues/detail?id=1450 (No comment was entered for

Re: Issue 1455 in reviewboard: rb-site install giving error make sure you are running as administrator

2010-02-21 Thread reviewboard
Updates: Status: UserError Comment #3 on issue 1455 by chipx86: rb-site install giving error make sure you are running as administrator http://code.google.com/p/reviewboard/issues/detail?id=1455 (No comment was entered for this change.) -- You received this message because you are

Re: Issue 1451 in reviewboard: Base field should be stripped before using

2010-02-21 Thread reviewboard
Updates: Status: Confirmed Labels: Milestone-Release1.5 EasyFix Component-Reviews Comment #1 on issue 1451 by chipx86: Base field should be stripped before using http://code.google.com/p/reviewboard/issues/detail?id=1451 Should be an easy fix. -- You received this message

Re: Issue 1459 in reviewboard: post-review produces error /reviewboard/api/json/accounts/login/ not found

2010-02-21 Thread reviewboard
Updates: Status: NeedInfo Labels: -Type-Defect Type-Support Comment #1 on issue 1459 by chipx86: post-review produces error /reviewboard/api/json/accounts/login/ not found http://code.google.com/p/reviewboard/issues/detail?id=1459 Sounds like that's not the right path on that

Re: Issue 1423 in reviewboard: post-review expects an array internally and a string is returned

2010-02-21 Thread reviewboard
Updates: Status: Fixed Owner: chipx86 Comment #4 on issue 1423 by chipx86: post-review expects an array internally and a string is returned http://code.google.com/p/reviewboard/issues/detail?id=1423 Committed to master as 24b1e9d. In the future, please post patches to our

Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command

2010-02-21 Thread reviewboard
Comment #3 on issue 1494 by gfbett: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 Thanks, I will upgrade -- You received this message because you are listed

Re: Issue 1358 in reviewboard: New review request fails

2010-02-21 Thread reviewboard
Comment #3 on issue 1358 by justin.d.teems: New review request fails http://code.google.com/p/reviewboard/issues/detail?id=1358 thanks. will do. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your

Re: Issue 1500 in reviewboard: xx lines hidden [Expand] link stopped working

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 1500 by trowbrds: xx lines hidden [Expand] link stopped working http://code.google.com/p/reviewboard/issues/detail?id=1500 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC

Re: Issue 583 in reviewboard: ReviewBoard does not verify patch when uploading

2010-02-21 Thread reviewboard
Updates: Status: Fixed Comment #9 on issue 583 by chipx86: ReviewBoard does not verify patch when uploading http://code.google.com/p/reviewboard/issues/detail?id=583 This appears to be fixed these days. I don't know when, but certainly in 1.5 it's no longer a problem. -- You

Re: Issue 821 in reviewboard: Updating a diff with a diff + parent diff does not work.

2010-02-21 Thread reviewboard
Comment #8 on issue 821 by chipx86: Updating a diff with a diff + parent diff does not work. http://code.google.com/p/reviewboard/issues/detail?id=821 The error display part of this bug is fixed on master (ab7ae7d) -- You received this message because you are listed in the owner or CC