Issue 2036 in reviewboard: Provide diff statistics (diffstat output) on review requests

2011-03-20 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2036 by arthur.h...@gmail.com: Provide diff statistics (diffstat output) on review requests http://code.google.com/p/reviewboard/issues/detail?id=2036 Reviewboard 1.5.4 does not show the diffstat of the submitted diffs

Re: Issue 2036 in reviewboard: Provide diff statistics (diffstat output) on review requests

2011-03-20 Thread reviewboard
Comment #1 on issue 2036 by arthur.h...@gmail.com: Provide diff statistics (diffstat output) on review requests http://code.google.com/p/reviewboard/issues/detail?id=2036 Duplicate of issue 48 - http://code.google.com/p/reviewboard/issues/detail?id=48 -- You received this message becaus

Issue 2037 in reviewboard: Inter-patch dependency support

2011-03-20 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2037 by arthur.h...@gmail.com: Inter-patch dependency support http://code.google.com/p/reviewboard/issues/detail?id=2037 It will happen that people submit several patches that are interdependant. Linux Kernel workflow is

Re: Issue 281 in reviewboard: Wanted: support for changeset dependencies

2011-03-20 Thread reviewboard
Updates: Labels: -ExtensionIdea -Priority-Low Priority-High Milestone-Release1.7 Comment #7 on issue 281 by chip...@gmail.com: Wanted: support for changeset dependencies http://code.google.com/p/reviewboard/issues/detail?id=281 I think it makes sense to schedule this. -- You received

Re: Issue 2037 in reviewboard: Inter-patch dependency support

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 281 Comment #1 on issue 2037 by chip...@gmail.com: Inter-patch dependency support http://code.google.com/p/reviewboard/issues/detail?id=2037 We may go the route of having full-on patch management where a review request can represent mul

Re: Issue 281 in reviewboard: Wanted: support for changeset dependencies

2011-03-20 Thread reviewboard
Comment #8 on issue 281 by chip...@gmail.com: Wanted: support for changeset dependencies http://code.google.com/p/reviewboard/issues/detail?id=281 Issue 2037 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" gr

Re: Issue 2037 in reviewboard: Inter-patch dependency support

2011-03-20 Thread reviewboard
Comment #2 on issue 2037 by arthur.h...@gmail.com: Inter-patch dependency support http://code.google.com/p/reviewboard/issues/detail?id=2037 Sorry for not picking up on the duplicate myself. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" gr

Re: Issue 2036 in reviewboard: Provide diff statistics (diffstat output) on review requests

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 48 Comment #2 on issue 2036 by trowb...@gmail.com: Provide diff statistics (diffstat output) on review requests http://code.google.com/p/reviewboard/issues/detail?id=2036 (No comment was entered for this change.) -- You received this mes

Re: Issue 48 in reviewboard: Add "number of lines changed" to dashboard view

2011-03-20 Thread reviewboard
Comment #5 on issue 48 by trowb...@gmail.com: Add "number of lines changed" to dashboard view http://code.google.com/p/reviewboard/issues/detail?id=48 Issue 2036 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues

Re: Issue 2032 in reviewboard: Incoming group count is not update after updating the review request

2011-03-20 Thread reviewboard
Updates: Status: Confirmed Comment #3 on issue 2032 by trowb...@gmail.com: Incoming group count is not update after updating the review request http://code.google.com/p/reviewboard/issues/detail?id=2032 Had to revert the change, because it breaks unit tests (and isn't entirely corre

Re: Issue 1949 in reviewboard: RBtools intermittently not submitting review requests.

2011-03-20 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 1949 by trowb...@gmail.com: RBtools intermittently not submitting review requests. http://code.google.com/p/reviewboard/issues/detail?id=1949 Can you determine what the bad line it's receiving is? -- You received this message because you

Re: Issue 1939 in reviewboard: .sj Files are being displayed as binary files (despite being text format files) in review board

2011-03-20 Thread reviewboard
Updates: Status: SetupIssue Comment #5 on issue 1939 by trowb...@gmail.com: .sj Files are being displayed as binary files (despite being text format files) in review board http://code.google.com/p/reviewboard/issues/detail?id=1939 (No comment was entered for this change.) -- You rece

Re: Issue 1955 in reviewboard: post-review can't post when https proxy is setup on MAC OSX

2011-03-20 Thread reviewboard
Updates: Status: UserError Comment #1 on issue 1955 by trowb...@gmail.com: post-review can't post when https proxy is setup on MAC OSX http://code.google.com/p/reviewboard/issues/detail?id=1955 Evidently your proxy exceptions rule isn't correct. Some HTTP libraries want *.abc.com, a

Re: Issue 1689 in reviewboard: post-review --guess-summary should trim internal newlines

2011-03-20 Thread reviewboard
Comment #2 on issue 1689 by trowb...@gmail.com: post-review --guess-summary should trim internal newlines http://code.google.com/p/reviewboard/issues/detail?id=1689 Issue 1987 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "revi

Re: Issue 1987 in reviewboard: Summary containing newline fails to send email

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1689 Comment #4 on issue 1987 by trowb...@gmail.com: Summary containing newline fails to send email http://code.google.com/p/reviewboard/issues/detail?id=1987 (No comment was entered for this change.) -- You received this message because

Re: Issue 1706 in reviewboard: View Diff causes un-saved changes to Description to be dropped

2011-03-20 Thread reviewboard
Comment #1 on issue 1706 by trowb...@gmail.com: View Diff causes un-saved changes to Description to be dropped http://code.google.com/p/reviewboard/issues/detail?id=1706 Issue 1957 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups

Re: Issue 1957 in reviewboard: review description lost when navigating away from page

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1706 Comment #2 on issue 1957 by trowb...@gmail.com: review description lost when navigating away from page http://code.google.com/p/reviewboard/issues/detail?id=1957 (No comment was entered for this change.) -- You received this message

Re: Issue 774 in reviewboard: Review tracker for user

2011-03-20 Thread reviewboard
Comment #6 on issue 774 by trowb...@gmail.com: Review tracker for user http://code.google.com/p/reviewboard/issues/detail?id=774 Issue 1275 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this

Re: Issue 1275 in reviewboard: Add capabilites for tracking reviews in progress, and for marking that a review has been read and reacted to

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 774 Comment #3 on issue 1275 by trowb...@gmail.com: Add capabilites for tracking reviews in progress, and for marking that a review has been read and reacted to http://code.google.com/p/reviewboard/issues/detail?id=1275 I think we're go

Re: Issue 1395 in reviewboard: Exporting review comments

2011-03-20 Thread reviewboard
Updates: Summary: Exporting review comments Comment #6 on issue 1395 by trowb...@gmail.com: Exporting review comments http://code.google.com/p/reviewboard/issues/detail?id=1395 (No comment was entered for this change.) -- You received this message because you are subscribed to the Googl

Re: Issue 1395 in reviewboard: Exporting review comments

2011-03-20 Thread reviewboard
Comment #7 on issue 1395 by trowb...@gmail.com: Exporting review comments http://code.google.com/p/reviewboard/issues/detail?id=1395 Issue 1950 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to t

Re: Issue 1950 in reviewboard: Exporting reviews to external file

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1395 Comment #2 on issue 1950 by trowb...@gmail.com: Exporting reviews to external file http://code.google.com/p/reviewboard/issues/detail?id=1950 (No comment was entered for this change.) -- You received this message because you are sub

Re: Issue 1767 in reviewboard: Diff engine incorrectly interprets block moves

2011-03-20 Thread reviewboard
Updates: Status: WontFix Comment #2 on issue 1767 by trowb...@gmail.com: Diff engine incorrectly interprets block moves http://code.google.com/p/reviewboard/issues/detail?id=1767 It's not worth messing with this right now. -- You received this message because you are subscribed to th

Re: Issue 2018 in reviewboard: saved message lost if I goto the "View Reviews" page

2011-03-20 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2018 by trowb...@gmail.com: saved message lost if I goto the "View Reviews" page http://code.google.com/p/reviewboard/issues/detail?id=2018 Can you include screenshots of the reproduction process? I'm not entirely sure I understand what'

Re: Issue 2011 in reviewboard: search return HTTP 500 error

2011-03-20 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2011 by trowb...@gmail.com: search return HTTP 500 error http://code.google.com/p/reviewboard/issues/detail?id=2011 Make sure that apache's library path (and pythonpath) contain the directory where jvm.dll lives. -- You received this mess

Re: Issue 1632 in reviewboard: Alphabetial sorting of review requests should not be case sensitive

2011-03-20 Thread reviewboard
Updates: Status: ThirdParty Comment #9 on issue 1632 by trowb...@gmail.com: Alphabetial sorting of review requests should not be case sensitive http://code.google.com/p/reviewboard/issues/detail?id=1632 This is actually a problem in sqlite. MySQL and other databases work fine. -- You

Re: Issue 1999 in reviewboard: Irregular entry in database causes crash

2011-03-20 Thread reviewboard
Updates: Status: Incomplete Comment #2 on issue 1999 by trowb...@gmail.com: Irregular entry in database causes crash http://code.google.com/p/reviewboard/issues/detail?id=1999 (No comment was entered for this change.) -- You received this message because you are subscribed to the Goo

Re: Issue 1581 in reviewboard: Diff veivew error on RBTools 0.2rc1

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #5 on issue 1581 by trowb...@gmail.com: Diff veivew error on RBTools 0.2rc1 http://code.google.com/p/reviewboard/issues/detail?id=1581 We haven't seen this in >=1.5. Please reopen if you disagree (make sure it's with a newly posted diff, too). -- You

Re: Issue 1642 in reviewboard: Non-intuitive error message when typoing a git repo path

2011-03-20 Thread reviewboard
Updates: Status: ThirdParty Comment #5 on issue 1642 by trowb...@gmail.com: Non-intuitive error message when typoing a git repo path http://code.google.com/p/reviewboard/issues/detail?id=1642 I used to see this a lot with django 1.1 but haven't seen it with newer releases. -- You

Re: Issue 1670 in reviewboard: post-review does not support UTF-8 in patch files

2011-03-20 Thread reviewboard
Updates: Status: Incomplete Comment #7 on issue 1670 by trowb...@gmail.com: post-review does not support UTF-8 in patch files http://code.google.com/p/reviewboard/issues/detail?id=1670 (No comment was entered for this change.) -- You received this message because you are subscribed t

Re: Issue 1893 in reviewboard: Fields shouldn't become editable when selecting text.

2011-03-20 Thread reviewboard
Updates: Summary: Fields shouldn't become editable when selecting text. Status: New Labels: Component-Reviews Usability Comment #7 on issue 1893 by trowb...@gmail.com: Fields shouldn't become editable when selecting text. http://code.google.com/p/reviewboard/issues/deta

Re: Issue 1845 in reviewboard: bazaar bzr+ssh is not working

2011-03-20 Thread reviewboard
Comment #7 on issue 1845 by trowb...@gmail.com: bazaar bzr+ssh is not working http://code.google.com/p/reviewboard/issues/detail?id=1845 Please check your apache path configuration and make sure that /usr/local/bin is in the exec path. -- You received this message because you are subscrib

Re: Issue 953 in reviewboard: Hg SCMTool doesn't support old mercurial installs

2011-03-20 Thread reviewboard
Updates: Status: WontFix Comment #5 on issue 953 by trowb...@gmail.com: Hg SCMTool doesn't support old mercurial installs http://code.google.com/p/reviewboard/issues/detail?id=953 #2 is tracked in bug 547. As far as older hg, I don't think it's worth it now. -- You received this m

Re: Issue 1846 in reviewboard: Smilies

2011-03-20 Thread reviewboard
Updates: Status: WontFix Comment #3 on issue 1846 by trowb...@gmail.com: Smilies http://code.google.com/p/reviewboard/issues/detail?id=1846 Not really worth it right now. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to

Re: Issue 1964 in reviewboard: Enhance filter possibilities for reviewboard emails

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 1964 by trowb...@gmail.com: Enhance filter possibilities for reviewboard emails http://code.google.com/p/reviewboard/issues/detail?id=1964 Fixed in master (1.6) as 2383b5c. -- You received this message because you are subscribed to the Googl

Re: Issue 1868 in reviewboard: List of users to assign in admin panel group view

2011-03-20 Thread reviewboard
Updates: Status: ThirdParty Comment #2 on issue 1868 by trowb...@gmail.com: List of users to assign in admin panel group view http://code.google.com/p/reviewboard/issues/detail?id=1868 Auth groups aren't particularly useful in review board, and this UI comes from the django admin im

Re: Issue 1951 in reviewboard: Admin-specified fields in addition to comments

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1277 Comment #1 on issue 1951 by trowb...@gmail.com: Admin-specified fields in addition to comments http://code.google.com/p/reviewboard/issues/detail?id=1951 (No comment was entered for this change.) -- You received this message because

Re: Issue 1277 in reviewboard: Comment Types

2011-03-20 Thread reviewboard
Comment #8 on issue 1277 by trowb...@gmail.com: Comment Types http://code.google.com/p/reviewboard/issues/detail?id=1277 Issue 1951 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, s

Re: Issue 1906 in reviewboard: Highlight new comments and replies to comments

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #1 on issue 1906 by trowb...@gmail.com: Highlight new comments and replies to comments http://code.google.com/p/reviewboard/issues/detail?id=1906 1.6 has collapsed reviews that do exactly this. -- You received this message because you are subscribed to

Re: Issue 1955 in reviewboard: post-review can't post when https proxy is setup on MAC OSX

2011-03-20 Thread reviewboard
Comment #2 on issue 1955 by speedfirst: post-review can't post when https proxy is setup on MAC OSX http://code.google.com/p/reviewboard/issues/detail?id=1955 I've tried the "reviewboard.abc.com" and it doesn't work either. -- You received this message because you are subscribed to the Googl

Re: Issue 1941 in reviewboard: Code comments should have quick "done" button.

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1277 Comment #1 on issue 1941 by trowb...@gmail.com: Code comments should have quick "done" button. http://code.google.com/p/reviewboard/issues/detail?id=1941 Will be handled by the issues change. -- You received this message because you

Re: Issue 1277 in reviewboard: Comment Types

2011-03-20 Thread reviewboard
Comment #9 on issue 1277 by trowb...@gmail.com: Comment Types http://code.google.com/p/reviewboard/issues/detail?id=1277 Issue 1941 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, s

Re: Issue 1337 in reviewboard: Better UI for very long code lines.

2011-03-20 Thread reviewboard
Updates: Status: WontFix Comment #2 on issue 1337 by trowb...@gmail.com: Better UI for very long code lines. http://code.google.com/p/reviewboard/issues/detail?id=1337 In most code it's actually pretty rare to have files with no breakable characters in them. Occasionally it happens

Re: Issue 1443 in reviewboard: process hangs when generating diff for large file with 1 line (e.g. minified .js file)

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 1443 by trowb...@gmail.com: process hangs when generating diff for large file with 1 line (e.g. minified .js file) http://code.google.com/p/reviewboard/issues/detail?id=1443 I just committed a contributed change to time out when pygments take

Re: Issue 1284 in reviewboard: allow users to delete a review that they have drafted, without having to publish it first

2011-03-20 Thread reviewboard
Updates: Status: WontFix Comment #5 on issue 1284 by trowb...@gmail.com: allow users to delete a review that they have drafted, without having to publish it first http://code.google.com/p/reviewboard/issues/detail?id=1284 Actually, I don't think this is super necessary. "Delete" is on

Re: Issue 1742 in reviewboard: Awkward workflow when reviewing code.

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #5 on issue 1742 by trowb...@gmail.com: Awkward workflow when reviewing code. http://code.google.com/p/reviewboard/issues/detail?id=1742 I think the one-click ship-it that's in 1.6 addresses this. -- You received this message because you are subscribed

Re: Issue 2018 in reviewboard: saved message lost if I goto the "View Reviews" page

2011-03-20 Thread reviewboard
Comment #2 on issue 2018 by zhangton...@gmail.com: saved message lost if I goto the "View Reviews" page http://code.google.com/p/reviewboard/issues/detail?id=2018 Is there any testing environment for reproducing? I'm working in a product environment, and not sure all steps can be snapshot.

Re: Issue 2018 in reviewboard: saved message lost if I goto the "View Reviews" page

2011-03-20 Thread reviewboard
Comment #3 on issue 2018 by trowb...@gmail.com: saved message lost if I goto the "View Reviews" page http://code.google.com/p/reviewboard/issues/detail?id=2018 You can try on demo.reviewboard.org -- You received this message because you are subscribed to the Google Groups "reviewboard-issue

Re: Issue 1984 in reviewboard: the mails sent place the description where the summary should be

2011-03-20 Thread reviewboard
Updates: Status: NotABug Comment #1 on issue 1984 by trowb...@gmail.com: the mails sent place the description where the summary should be http://code.google.com/p/reviewboard/issues/detail?id=1984 That's actually how we expect the text emails to look. -- You received this message bec

Issue 2038 in reviewboard: Automatic hyperlink regexes are broken

2011-03-20 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2038 by sbress...@gmail.com: Automatic hyperlink regexes are broken http://code.google.com/p/reviewboard/issues/detail?id=2038 * NOTE: Do not post confidential information in this bug report. * * If you need immediate

Re: Issue 1998 in reviewboard: Error when visiting user profile page: [Django] Error (EXTERNAL IP): /users/

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #1 on issue 1998 by trowb...@gmail.com: Error when visiting user profile page: [Django] Error (EXTERNAL IP): /users/ http://code.google.com/p/reviewboard/issues/detail?id=1998 Oops, this page was doing something monumentally silly. Fixed in master e38

Re: Issue 2038 in reviewboard: Automatic hyperlink regexes are broken

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 2002 Comment #1 on issue 2038 by trowb...@gmail.com: Automatic hyperlink regexes are broken http://code.google.com/p/reviewboard/issues/detail?id=2038 (No comment was entered for this change.) -- You received this message because you are

Re: Issue 2002 in reviewboard: linkified URL has succeeding parenthesis included in link's target URL

2011-03-20 Thread reviewboard
Comment #1 on issue 2002 by trowb...@gmail.com: linkified URL has succeeding parenthesis included in link's target URL http://code.google.com/p/reviewboard/issues/detail?id=2002 Issue 2038 has been merged into this issue. -- You received this message because you are subscribed to the Google

Re: Issue 1648 in reviewboard: post-review throws an exception for Perforce changesets with huge descriptions.

2011-03-20 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 1481 Comment #2 on issue 1648 by trowb...@gmail.com: post-review throws an exception for Perforce changesets with huge descriptions. http://code.google.com/p/reviewboard/issues/detail?id=1648 (No comment was entered for this change.) --

Re: Issue 1481 in reviewboard: Review Board 500 error if testing done is over 65535 characters (or a bit smaller)

2011-03-20 Thread reviewboard
Comment #4 on issue 1481 by trowb...@gmail.com: Review Board 500 error if testing done is over 65535 characters (or a bit smaller) http://code.google.com/p/reviewboard/issues/detail?id=1481 Issue 1648 has been merged into this issue. -- You received this message because you are subscribed to

Re: Issue 2024 in reviewboard: MultipleObjectsReturned: get() returned more than one ReviewRequest

2011-03-20 Thread reviewboard
Updates: Status: Fixed Comment #1 on issue 2024 by trowb...@gmail.com: MultipleObjectsReturned: get() returned more than one ReviewRequest http://code.google.com/p/reviewboard/issues/detail?id=2024 Fixed in release-1.5.x. This will ship with 1.5.5. -- You received this message becaus