Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense

2011-09-15 Thread reviewboard
Comment #7 on issue 2252 by e.ta...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 True. Something like "changes between r0 and r2". But we don't have r0. -- You received this message because you are subscribed to the Google

Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense

2011-09-15 Thread reviewboard
Comment #6 on issue 2252 by chip...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 Not trunk, just the base revision listed in the diff (which may be different in any particular diff revision). -- You received this message

Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense

2011-09-15 Thread reviewboard
Comment #5 on issue 2252 by o...@humblebundle.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 FWIW, the way it works currently as I understand it: "Jump to revision x" shows you diffs between revision x and trunk "Changes between re

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2011-09-15 Thread reviewboard
Comment #15 on issue 46 by bernard3...@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 One way I did something similar was to create a hidden div with 80 letters that had the same CSS styles and measure the width. I know some JS toolkits

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2011-09-15 Thread reviewboard
Comment #14 on issue 46 by shankar@gmail.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 The trick is to figure out *where* the 80th column is [...] For fixed-width fonts, this determination should be easy, shouldn't it? Style a vertical

Re: Issue 2252 in reviewboard: changes between r2 and 2 doesn't make sense

2011-09-15 Thread reviewboard
Comment #4 on issue 2252 by e.ta...@gmail.com: changes between r2 and 2 doesn't make sense http://code.google.com/p/reviewboard/issues/detail?id=2252 I'd like to see changes between "trunk" and latest revision too. In this way it would be possible to aggregate commits for a task in the same

Re: Issue 46 in reviewboard: 80-column indicator in diff view

2011-09-15 Thread reviewboard
Comment #13 on issue 46 by ju...@tuenti.com: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Some companies use other number of columns (ie: 100) so this should be configurable also -- You received this message because you are subscribed to the Go

Re: Issue 2289 in reviewboard: cannot make a review request using post-review utility

2011-09-15 Thread reviewboard
Comment #1 on issue 2289 by daniil.i...@gmail.com: cannot make a review request using post-review utility http://code.google.com/p/reviewboard/issues/detail?id=2289 Sorry, I didn't notice link leads to a bugtracker for the ReviewBoard project, not our instance. Please invalidate this bug.

Issue 2289 in reviewboard: cannot make a review request using post-review utility

2011-09-15 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2289 by daniil.i...@gmail.com: cannot make a review request using post-review utility http://code.google.com/p/reviewboard/issues/detail?id=2289 Hi! I was trying to use post-review command line tool and got the following