Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-30 Thread reviewboard
Comment #5 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Agreed. Thanks for looking into this. -- You received this message because you are subscribed to the Google Groups

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-30 Thread reviewboard
Updates: Status: SetupIssue Comment #6 on issue 2878 by trowb...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 (No comment was entered for this change.) -- You received this message because you are

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-29 Thread reviewboard
Comment #3 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 The code for handling keywords in diffs is the same between 1.6.13 and 1.7.x, and none of our unit tests have broken. I also

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-29 Thread reviewboard
Comment #4 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 According to the SVN documentation, svn:keywords is intended now to be case-sensitive, though for now, some (Id being one) is

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-27 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Sudhir, We have unit tests that should cover this exact case, and I tried your example

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-27 Thread reviewboard
Comment #2 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Christian, I think below is what you are asking. Yes it is listed. $ svn propget svn:keywords hello_world.c id FYI, I