Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-15 Thread reviewboard
Comment #6 on issue 3966 by griffin@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 I observed the same behavior this morning with 2.0.19 and Firefox (I don't have the FF version in

Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-11 Thread reviewboard
Comment #5 on issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 It looks like once I've looked at diff/2 and diff/1-2, they get cached in a cookie. When I update

Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard
Comment #4 on issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 Some new info. This appears to be a Chrome- or at least browser-related issue. I cleared Chrome's

Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 What version are you running? Reviewboard 2.0.19

Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard
Comment #3 on issue 3966 by physicss...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 I looked up how to flush memcached and ended up running echo 'flush_all' | nc localhost 11211 This

Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard
Updates: Status: NeedInfo Comment #2 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 As a test, what happens if you clear the server cache? Does the problem

Re: Issue 3966 in reviewboard: Uploading a revision to a CR twice before publishing creates bad partial diffs

2015-09-10 Thread reviewboard
Comment #1 on issue 3966 by chip...@gmail.com: Uploading a revision to a CR twice before publishing creates bad partial diffs https://code.google.com/p/reviewboard/issues/detail?id=3966 Thanks for the detailed reproduction steps! We generate the changes between diffs on-the-fly by patching