Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45519/#review126271 ---

Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-30 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45522/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs:

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45519/ --- (Updated March 31, 2016, 2:07 a.m.) Review request for Ambari, Dmytro

Re: Review Request 45516: AMBARI-15639. Expose MariaDB option for Hive, Oozie and Ranger

2016-03-30 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45516/#review126237 --- Ship it! Ship It! - Alejandro Fernandez On March 31, 2016,

Re: Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45519/#review126236 ---

Review Request 45519: AMBARI-15637. BRANCH-2.2 If RU/EU is paused, services are restarted on the older version. EU is more complex since stopping services should use the original version.

2016-03-30 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45519/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan

Review Request 45518: AMBARI-15638 : AMS Sum Calculation Incorrect

2016-03-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45518/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Review Request 45516: AMBARI-15639. Expose MariaDB option for Hive, Oozie and Ranger

2016-03-30 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45516/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-15639

Re: Review Request 45442: Orphaned Host Alerts Cause Stale Alert Notifications After Removing Hosts

2016-03-30 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45442/#review126231 ---

Review Request 45507: Enhance blueprint support for using references

2016-03-30 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45507/ --- Review request for Ambari and Robert Nettleton. Bugs: AMBARI-15395 and

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/ --- (Updated March 30, 2016, 2:46 p.m.) Review request for Ambari, Ajit Kumar,

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45470/#review126192 --- Ship it! Ship It! - Juanjo Marron On March 30, 2016, 5:15

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Jayush Luniya
> On March 30, 2016, 6:02 p.m., Juanjo Marron wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, > > line 107 > > > > > > Is it rolling_upgrade related or the version

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Nahappan Somasundaram
> On March 29, 2016, 12:20 p.m., Ajit Kumar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java, > > line 211 > > > > > > Do we need to add if condition on cluster name

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Nahappan Somasundaram
> On March 30, 2016, 10:20 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java, > > line 357 > > > > > > Expensive to construct; use an injected

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45470/#review126157 ---

Re: Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

2016-03-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45447/ --- (Updated March 30, 2016, 5:51 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic

2016-03-30 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/#review126147 --- - Can you add some more description in the Apache JIRA about

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/#review126144 --- Fix it, then Ship it!

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Jayush Luniya
> On March 30, 2016, 2:57 p.m., Sumit Mohanty wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py, > > line 62 > > > > > > OK, for now but should not this be in the stack

Re: Review Request 45447: AMBARI-15621 : Cluster Second aggregator taking more than 2 mins to execute on large clusters, thereby causing lag.

2016-03-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45447/#review126140 --- Fix it, then Ship it!

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review126138 --- Ship it! Ship It! - Nate Cole On March 30, 2016, 11:20

Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45347/#review126131 --- Ship it!

Re: Review Request 45459: AMBARI-15622. 'phoenix.query.spoolThresholdBytes' property doesn't have a description on UI

2016-03-30 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45459/#review126134 --- Ship it! Ship It! - Sumit Mohanty On March 29, 2016, 11:41

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Sebastian Toader
> On March 29, 2016, 6:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 45465: Support distributed aggregation for multiple AMS instances

2016-03-30 Thread Sid Wagle
> On March 30, 2016, 5:15 a.m., Sumit Mohanty wrote: > > ambari-metrics/ambari-metrics-timelineservice/pom.xml, line 268 > > > > > > Understand that ZK version hardly changes but should this be > > parameterized as

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 3:20 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
> On March 30, 2016, 2:05 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapUtils.java, > > line 62 > > > > > > `full` is never `null`? No, during

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 30, 2016, 3:25 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45458/#review126112 ---

Re: Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Nate Cole
> On March 30, 2016, 10:21 a.m., Jonathan Hurley wrote: > > contrib/version-builder/version_builder.py, line 231 > > > > > > Should this be a member of the class; seems like it's only called in > > the context of

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45458/#review126113 --- Ship it! One minor question - probably future work item. Ship

Re: Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45487/#review126107 --- Ship it! argparse is my only real concern; I don't know how it

Review Request 45486: AMBARI-15628 Ranger: update code for jdbc according to new logic

2016-03-30 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45486/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley,

Re: Review Request 45485: Ambari2400: ambari-server install fails on Rhel7

2016-03-30 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45485/#review126102 --- Ship it! Ship It! - Dmitro Lisnichenko On March 30, 2016,

Review Request 45487: VDF creation script should be callable as an importable module

2016-03-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45487/ --- Review request for Ambari and Jonathan Hurley. Bugs: AMBARI-15631

Re: Review Request 45485: Ambari2400: ambari-server install fails on Rhel7

2016-03-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45485/#review126101 --- Ship it! Ship It! - Dmytro Grinenko On March 30, 2016, 1:37

Review Request 45485: Ambari2400: ambari-server install fails on Rhel7

2016-03-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45485/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-15629

Re: Review Request 45379: Introduce "Copy Path to clipboard" feature for Files browser view UI

2016-03-30 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45379/#review126093 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 30, 2016,

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 29, 2016, 4:58 du, Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java, > > line 65 > > > > > > Can these be bound by annotation? It would make it

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 29, 2016, 4:33 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
> On márc. 8, 2016, 5:05 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 801-816 > > > > > > A problem with this approach is

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-30 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 12:44 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45432: App Timeline Web UI Warning Alert is always present after Disabling security a few times

2016-03-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/#review126079 --- Ship it! Ship It! - Andrew Onischuk On March 30, 2016,

Re: Review Request 45432: App Timeline Web UI Warning Alert is always present after Disabling security a few times

2016-03-30 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45432/ --- (Updated Березень 30, 2016, 10:43 до полудня) Review request for Ambari,

Re: Review Request 45208: Cleanup LDAP sync process

2016-03-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45208/ --- (Updated March 30, 2016, 9:28 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 45379: Introduce "Copy Path to clipboard" feature for Files browser view UI

2016-03-30 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45379/ --- (Updated March 30, 2016, 7:12 a.m.) Review request for Ambari, DIPAYAN