Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

2016-04-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46183/#review128828 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/con

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review128826 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/packa

Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

2016-04-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46183/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/#review128823 --- Ship it! ambari-server/src/main/resources/common-services/HAWQ

Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

2016-04-13 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46186/ --- Review request for Ambari. Bugs: AMBARI-15852 https://issues.apache.org/jir

Re: Review Request 46169: Add dryrun method on request object

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46169/#review128807 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 46181: Activate HAWQ standby wizard fails to delete previous hawq standby master

2016-04-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46181/#review128799 --- Ship it! Ship It! - Alexander Denissov On April 13, 2016, 11

Review Request 46181: Activate HAWQ standby wizard fails to delete previous hawq standby master

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46181/ --- Review request for Ambari and Alexander Denissov. Bugs: AMBARI-15849 https:

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46176/#review128794 --- Ship it! Ship It! - Alejandro Fernandez On April 13, 2016, 1

Re: Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file writes for AMS HBase tables

2016-04-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46178/#review128792 --- Ship it! Ship It! - Sid Wagle On April 13, 2016, 10:52 p.m.,

Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file writes for AMS HBase tables

2016-04-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46178/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46176/#review128782 --- Ship it! Ship It! - Matt On April 13, 2016, 3:41 p.m., Alexa

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46176/#review128778 --- Ship it! Ship It! - Goutam Tadi On April 13, 2016, 10:41 p.m

Review Request 46176: Update group for postgres proxy user to * from hadoop

2016-04-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46176/ --- Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam Tadi,

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-13 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/#review128771 --- Ship it! Ship It! - Matt On April 13, 2016, 2:55 p.m., Lav J

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-13 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/#review128763 --- Ship it! Ship It! - Goutam Tadi On April 13, 2016, 9:55 p.m.

Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

2016-04-13 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46170/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi,

Re: Review Request 46127: Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/ --- (Updated April 13, 2016, 9:45 p.m.) Review request for Ambari, Dmytro Grinenko,

Review Request 46169: Add dryrun method on request object

2016-04-13 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46169/ --- Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty. Bugs: A

Re: Review Request 46159: VDF with newlines preventing valid repo files

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46159/ --- (Updated April 13, 2016, 3:45 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46159: VDF with newlines preventing valid repo files

2016-04-13 Thread Nate Cole
> On April 13, 2016, 3:14 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java, > > line 161 > > > > > > Is the version required in the XSD

Re: Review Request 46159: VDF with newlines preventing valid repo files

2016-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46159/#review128736 --- Ship it! Ship It! - Alejandro Fernandez On April 13, 2016, 6

Re: Review Request 46159: VDF with newlines preventing valid repo files

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46159/#review128734 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128733 --- Ship it! Ship It! - Jayush Luniya On April 13, 2016, 1:03 a.

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Jayush Luniya
> On April 13, 2016, 4:50 a.m., Jayush Luniya wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 40 > > > > > > @Alejandro, lets talk about this before we make

Review Request 46159: VDF with newlines preventing valid repo files

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46159/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46155/#review128726 --- Ship it! Ship It! - Nate Cole On April 13, 2016, 1:17 p.m.,

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

2016-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46155/#review128713 --- Ship it! Ship It! - Alejandro Fernandez On April 13, 2016, 5

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46155/#review128710 --- ambari-common/src/main/python/resource_management/libraries/funct

Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46155/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs: AMBARI-1586

Re: Review Request 46126: Activate HAWQ standby wizard fails to delete previous hawq standby master

2016-04-13 Thread Alexander Denissov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46126/#review128707 --- ambari-server/src/main/resources/common-services/HAWQ/2.0.0/packa

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-13 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/#review128699 --- ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org

Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

2016-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleto

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/ --- (Updated April 13, 2016, 3:51 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
> On April 13, 2016, 2:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java, > > line 128 > > > > > > Does this cause an empt

Re: Review Request 46148: NPE when deleting a host

2016-04-13 Thread Daniel Gergely
> On ápr. 13, 2016, 3:05 du, Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java, > > line 914 > > > > > > Can you provide a test for that case when the hostn

Re: Review Request 46148: NPE when deleting a host

2016-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/#review128689 --- ambari-server/src/main/java/org/apache/ambari/server/state/cluste

Re: Review Request 46148: NPE when deleting a host

2016-04-13 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/ --- (Updated ápr. 13, 2016, 3:04 du) Review request for Ambari, Laszlo Puskas, Oliv

Review Request 46148: NPE when deleting a host

2016-04-13 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46148/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Seba

Re: Review Request 46136: Unit Test Coverage For Alert Caching

2016-04-13 Thread Jonathan Hurley
> On April 13, 2016, 10:45 a.m., Robert Levas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java, > > line 47 > > > > > > Why not `extend` `EasyMockSupport`? Initially,

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128685 --- ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128686 --- Ship it! Ship It! - Jonathan Hurley On April 12, 2016, 9:03

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128684 --- Ship it! Minor question on returned resources when no service i

Re: Review Request 46136: Unit Test Coverage For Alert Caching

2016-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46136/#review128682 --- Ship it! ambari-server/src/test/java/org/apache/ambari/server/

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128679 --- Ship it! I'll let you and Jayush work out the details of his is

Re: Review Request 46136: Unit Test Coverage For Alert Caching

2016-04-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46136/#review128678 --- Ship it! Ship It! - Nate Cole On April 12, 2016, 11:28 p.m.,

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128676 --- Ship it! Ship It! - Oliver Szabo On April 13, 2016, 2:28 p.m

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128675 --- Ship it! Ship It! - Sumit Mohanty On April 13, 2016, 2:28 p.

Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty. Bu

Re: Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

2016-04-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46144/#review128669 --- Ship it! Ship It! - Alexandr Antonenko On April 13, 2016, 1:

Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

2016-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46144/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-15844 https:

Re: Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

2016-04-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46143/#review128663 --- Ship it! Ship It! - Andrew Onischuk On April 13, 2016, 1:40

Re: Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

2016-04-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46143/#review128664 --- Ship it! Ship It! - Dmytro Sen On Апрель 13, 2016, 1:40 п.п.

Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

2016-04-13 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46143/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.

Re: Review Request 46017: AMBARI-15760 Add show_logs routines to Ranger Tagsync start/stop

2016-04-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46017/#review128661 --- Ship it! please make sure UT pass. - Andrew Onischuk On Apri

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128659 --- Ship it! Ship It! - Sebastian Toader On April 13, 2016, 1:57

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/ --- (Updated April 13, 2016, 11:57 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 46141: Getting WARNING on ambari server setup + start

2016-04-13 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46141/#review128638 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 13, 2016,

Review Request 46141: Getting WARNING on ambari server setup + start

2016-04-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46141/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15856 https:

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128625 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016, 6:27

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128624 --- ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARC

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-13 Thread Akhil PB
> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js, > > line 19 > > > > > > Looks like you can delete this file.

Re: Review Request 44704: CapSched View: Revamping the old UI

2016-04-13 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/ --- (Updated April 13, 2016, 7:18 a.m.) Review request for Ambari and Sreenath Soma