Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49072/ --- (Updated June 28, 2016, 6:08 a.m.) Review request for Ambari, Alejandro Fernand

Review Request 49295: remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions property in HDP2.5 definition

2016-06-27 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49295/ --- Review request for Ambari, Jayush Luniya and Sumit Mohanty. Bugs: AMBARI-17459

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-06-27 Thread Masahiro Tanaka
> On June 28, 2016, 2:52 a.m., Sid Wagle wrote: > > hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be change to use > > the comma separated host:port field. Thank you for reviewing! I'll update the patch in a few days. - Masahiro -

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48628/#review139719 --- hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 Should also be chan

Re: Review Request 47705: AMBARI-16731 Should close file object in security.py

2016-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47705/#review139718 --- Ship it! Ship It! - Sid Wagle On May 29, 2016, 2:55 a.m., Ma

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

2016-06-27 Thread Sid Wagle
> On June 28, 2016, 1:28 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1650 > > > > > > Should probably make a less generic name. Also, sho

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

2016-06-27 Thread Nahappan Somasundaram
> On June 27, 2016, 6:28 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1650 > > > > > > Should probably make a less generic name. Also, sho

Re: Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

2016-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49291/#review139711 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Review Request 49291: AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector after upgrade to 2.4.0

2016-06-27 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49291/ --- Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. Bug

Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

2016-06-27 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-17358

Re: Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

2016-06-27 Thread Sid Wagle
> On June 27, 2016, 11:16 p.m., Sid Wagle wrote: > > Ship It! The Jira title does not correctly describe the intended fix. - Sid --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49282/#review1

Re: Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

2016-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49282/#review139692 --- Ship it! Ship It! - Sid Wagle On June 27, 2016, 10:38 p.m.,

Review Request 49286: AmbariServer looks for ldap_url, container_dn in blueprint even for MIT security type

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49286/ --- Review request for Ambari, Alejandro Fernandez, Denys Buzhor, Jonathan Hurley, a

Re: Review Request 49249: AMBARI-17445: Storm metrics sink: expand metrics name to contain additional informations

2016-06-27 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49249/ --- (Updated 6 27, 2016, 11:02 오후) Review request for Ambari, Aravindan Vijayan, Pr

Review Request 49282: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents process shutdown

2016-06-27 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49282/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49188/ --- (Updated June 28, 2016, 12:37 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139675 --- Ship it! Ship It! - Sebastian Toader On June 27, 2016, 4:01

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

2016-06-27 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49221/#review139636 --- Ship it! Ship It! - Swapan Shridhar On June 25, 2016, 12:08

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

2016-06-27 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139635 --- Ship it! Ship It! - Srimanth Gunturi On June 27, 2016, 11:20

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

2016-06-27 Thread Alexandr Antonenko
> On June 24, 2016, 5:07 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thanks Alexandr. Can you help push it? done - Alexandr --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Alexandr Antonenko
> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote: > > As I understand there was no issue with the logic that you changed? > > If that is so, than why do we need this changes ? > > > > p.s. patch looks good and can be committed. > > Di Li wrote: > Hello Alex, > > Thx for t

Re: Review Request 49268: Put logsearch log level filter into smartconfigs

2016-06-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/#review139619 --- Ship it! Ship It! - Miklos Gergely On June 27, 2016, 3:39 p.

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

2016-06-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139617 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2016, 11

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Di Li
> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote: > > As I understand there was no issue with the logic that you changed? > > If that is so, than why do we need this changes ? > > > > p.s. patch looks good and can be committed. Hello Alex, Thx for the review. A feedback I got from my

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139611 --- ambari-server/src/main/java/org/apache/ambari/server/orm/dao/Host

Re: Review Request 49204: Incorrect error message for invalid category in Host Combo Search Box

2016-06-27 Thread Sangeeta Ravindran
> On June 24, 2016, 5:07 p.m., Alexandr Antonenko wrote: > > Ship It! Thanks Alexandr. Can you help push it? - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49204/#review139385 ---

Re: Review Request 49268: Put logsearch log level filter into smartconfigs

2016-06-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/#review139587 --- Ship it! Ship It! - Robert Nettleton On June 27, 2016, 3:39

Re: Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49267/#review139580 --- Ship it! As I understand there was no issue with the logic that

Review Request 49268: Put logsearch log level filter into smartconfigs

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49268/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Review Request 49267: AMBARI-17450: Host checks labels to be generated by the view instead of concat at the template level

2016-06-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49267/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-17450 https:

Re: Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/#review139578 --- Ship it! Ship It! - Laszlo Puskas On June 27, 2016, 2:01 p.m

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139577 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Review Request 49265: When querying host role command entities, the number of parameters should be limited

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49265/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit Mo

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139568 --- Ship it! Ship It! - Robert Levas On June 27, 2016, 9:36 a.m.

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139567 --- Ship it! Ship It! - Oliver Szabo On June 27, 2016, 12:42 p.m

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 1:36 p.m.) Review request for Ambari, Daniel Gergely, M

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
> On June 27, 2016, 12:42 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java, > > line 109 > > > > > > Why are we checking for

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139565 --- Ship it! Ship It! - Sandor Magyari On June 27, 2016, 12:42 p

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139564 --- Ship it! Ship It! - Robert Nettleton On June 27, 2016, 12:42

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/#review139563 --- Ship it! Ship It! - Daniel Gergely On jún. 27, 2016, 12:42 d

Re: Review Request 49263: Datanode start fails with umask 027 on ambari-server node

2016-06-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49263/#review139562 --- Ship it! Ship It! - Dmytro Sen On Июнь 27, 2016, 12:42 п.п.,

Review Request 49263: Datanode start fails with umask 027 on ambari-server node

2016-06-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49263/ --- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-17447 https://issues

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139560 --- Fix it, then Ship it! Ship It! ambari-server/src/main/java/or

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- (Updated June 27, 2016, 12:42 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49194: [Hive view] hiveserver service check fails for LDAP configured hive view

2016-06-27 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49194/ --- (Updated June 27, 2016, 12:28 p.m.) Review request for Ambari, DIPAYAN BHOWMICK

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49221/#review139559 --- Ship it! Ship It! - Robert Levas On June 24, 2016, 8:08 p.m.

Re: Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- (Updated June 27, 2016, 12:12 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139558 --- Ship it! Ship It! - Daniel Gergely On jún. 27, 2016, 11:59 d

Review Request 49260: Update desired states in case of service restarts

2016-06-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49260/ --- Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, and S

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139557 --- Ship it! Ship It! - Sandor Magyari On June 27, 2016, 11:59 a

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 11:59 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

2016-06-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/ --- (Updated June 27, 2016, 11:20 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/ --- (Updated June 27, 2016, 10:56 a.m.) Review request for Ambari, Don Bosco Durai,

Re: Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

2016-06-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/#review139548 --- Ship it! Ship It! - Miklos Gergely On June 27, 2016, 9:43 a.

Review Request 49256: Upload table- data after upload different from data shown in preview

2016-06-27 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49256/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 9:47 a.m.) Review request for Ambari, Daniel Gergely, M

Re: Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/#review139545 --- Ship it! Ship It! - Daniel Gergely On jún. 27, 2016, 9:43 de

Review Request 49255: Upgrade Solr version to 5.5.2 and use apache archive repo

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49255/ --- Review request for Ambari, Daniel Gergely, Miklos Gergely, Sandor Magyari, and S

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139544 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call

2016-06-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/ --- (Updated June 27, 2016, 9:43 a.m.) Review request for Ambari, Alejandro Fernand

Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- Review request for Ambari, Daniel Gergely, Miklos Gergely, Robert Levas, and San

Review Request 49249: AMBARI-17445: Storm metrics sink: expand metrics name to contain additional informations

2016-06-27 Thread Jungtaek Lim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49249/ --- Review request for Ambari, Aravindan Vijayan, Prajwal Rao, Sriharsha Chintalapan