Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-10-21 Thread Vishal Ghugare
> On Oct. 20, 2016, 6:36 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java, > > lines 171-189 > > > > > > There should be

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-10-21 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Oct. 21, 2016, 7:38 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 50803: [Ambari-17981] Integrate Druid With Ambari

2016-10-21 Thread Nishant Bangarwa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/ --- (Updated Oct. 22, 2016, 1:21 a.m.) Review request for Ambari, Renjith Kamath an

Review Request 53109: Manage Journal Node Wizard Initial UI

2016-10-21 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53109/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs:

Review Request 53106: Move HAWQ and PXF RCO from stacks to common-services

2016-10-21 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53106/ --- Review request for Ambari, Lav Jain and Roman Shaposhnik. Bugs: AMBARI-18666

Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

2016-10-21 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AM

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-10-21 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- (Updated Oct. 21, 2016, 9:30 p.m.) Review request for Ambari, Di Li, Venkat Ran

Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-10-21 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. Bugs: AM

Review Request 53101: While syncing with LDAP, username collisions should be handled based on configuration value

2016-10-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53101/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Oliver

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/#review153594 --- Ship it! Ship It! - Di Li On Oct. 21, 2016, 6:39 p.m., Tim T

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

2016-10-21 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153593 --- There are more changes we are working on (introducing Coordinator,

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/ --- (Updated Oct. 21, 2016, 6:39 p.m.) Review request for Ambari, Di Li, Jayush Lun

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

2016-10-21 Thread Sangeeta Ravindran
> On Oct. 21, 2016, 5:27 p.m., Di Li wrote: > > Ship It! Thanks Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153564

Re: Review Request 53091: Adding custom property to hive-site adds it to other 'Custom' panels on hive

2016-10-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53091/#review153571 --- Ship it! Ship It! - Yusaku Sako On Oct. 21, 2016, 3:58 p.m.,

Re: Review Request 52378: [AMBARI-18489] configs.sh has a spelling mistake inside the script.

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52378/#review153566 --- This change has been pushed: commit 5114bc9f7d4d8a246603e5d60dd52

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

2016-10-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153564 --- Ship it! Ship It! - Di Li On Oct. 20, 2016, 8:41 p.m., Sange

Re: Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53090/#review153558 --- Ship it! Ship It! - Jonathan Hurley On Oct. 21, 2016, 12:20

Re: Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53090/ --- (Updated Oct. 21, 2016, 7:20 p.m.) Review request for Ambari, Jonathan Hurley a

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153551 --- Ship it! Ship It! - Nate Cole On Oct. 19, 2016, 6:51 p.m., A

Re: Review Request 52378: [AMBARI-18489] configs.sh has a spelling mistake inside the script.

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52378/#review153553 --- What is the status of this review? It has 3 "Ship It"s - Nate Co

Review Request 53091: Adding custom property to hive-site adds it to other 'Custom' panels on hive

2016-10-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53091/ --- Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sak

Re: Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53090/#review153552 --- Ship it! Ship It! - Nate Cole On Oct. 21, 2016, 11:50 a.m.,

Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

2016-10-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53090/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-18663

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53060/#review153549 --- Ship it! Ship It! - Nate Cole On Oct. 20, 2016, 4:06 p.m., R

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/ --- (Updated Oct. 21, 2016, 3:34 p.m.) Review request for Ambari, Di Li, Jayush Lun

Re: Review Request 53089: AMBARI-18108 Allow spaces in templeton.hive.properties

2016-10-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53089/#review153547 --- Ship it! Ship It! - Sebastian Toader On Oct. 21, 2016, 5:18

Review Request 53089: AMBARI-18108 Allow spaces in templeton.hive.properties

2016-10-21 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53089/ --- Review request for Ambari and Sebastian Toader. Bugs: AMBARI-18108 https://

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52930/#review153545 --- Fix it, then Ship it! Ship It! ambari-metrics/ambari-metrics-

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/#review153544 --- Ship it! Ship It! - Di Li On Oct. 21, 2016, 12:45 p.m., Tim

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52930/ --- (Updated Окт. 21, 2016, 2:19 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 53087: Log Search schema meta data loader fix

2016-10-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/#review153542 --- Ship it! Ship It! - Oliver Szabo On Oct. 21, 2016, 1:52 p.m.

Re: Review Request 53087: Log Search schema meta data loader fix

2016-10-21 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/ --- (Updated Oct. 21, 2016, 1:52 p.m.) Review request for Ambari, Oliver Szabo, Rob

Re: Review Request 53087: Log Search schema meta data loader fix

2016-10-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/#review153537 --- ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache

Review Request 53087: Log Search schema meta data loader fix

2016-10-21 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. B

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/#review153536 --- Ship it! Ship It! - Dmytro Sen On Окт. 21, 2016, 11:29 д.п.,

Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/ --- Review request for Ambari, Di Li, Jayush Luniya, and Juanjo Marron. Bugs: AMBA

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-10-21 Thread Robert Levas
> On Oct. 20, 2016, 9:36 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java, > > lines 171-189 > > > > > > There should be

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-10-21 Thread Robert Levas
> On Oct. 20, 2016, 9:36 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java, > > lines 171-189 > > > > > > There should be

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-10-21 Thread Robert Levas
> On Oct. 7, 2016, 1:55 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java, > > line 817 > > > > > > Since this is called each time Ambari starts up

Re: Review Request 53052: Move ATLAS role command order to common-services/ATLAS

2016-10-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53052/ --- (Updated Oct. 21, 2016, 11:29 a.m.) Review request for Ambari and Vitalyi Brode

Re: Review Request 53068: Alert Targets Cannot Be Updated Due To Transaction / Cache Timing Issues

2016-10-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53068/#review153525 --- Ship it! Ship It! - Robert Levas On Oct. 20, 2016, 1:02 p.m.