Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- (Updated Dec. 15, 2016, 7:44 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159234 ---

Re: Review Request 54480: Spark 2.x interpreter confgurations in Zeppelin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54480/#review159260 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 14, 2016, 5:16

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- (Updated Dec. 15, 2016, 1:02 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159251 ---

Review Request 54760: Add common log rotation settings to HDFS configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54760/ --- Review request for Ambari, Andrii Voloshyn and Sumit Mohanty. Bugs:

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- (Updated Dec. 14, 2016, 10:53 p.m.) Review request for Ambari, Jonathan

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- (Updated Dec. 14, 2016, 10:52 p.m.) Review request for Ambari, Jonathan

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 14, 2016, 7:37 p.m., Alejandro Fernandez wrote: > > ambari-server/checkstyle.xml, line 33 > > > > > > I think it's good to have a code style, but I'm not in favor of having > > a code checker for

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/ --- (Updated Dec. 14, 2016, 9:19 p.m.) Review request for Ambari, Attila

Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/ --- Review request for Ambari, Jonathan Hurley, Miklos Gergely, Oliver Szabo, and

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159201 --- -1 for this patch ambari-server/checkstyle.xml (line 33)

Re: Review Request 54733: Alerts: Create new Alerts Notification type for SNMP to handle Ambari MIB

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54733/#review159203 --- Ship it! Ship It! - Jaimin Jetly On Dec. 14, 2016, 8:46

Re: Review Request 54747: Deployed Views Throw Exceptions On Ambari Server Startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54747/#review159199 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 14, 2016,

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159197 --- ambari-agent/pom.xml (line 56)

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review159194 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 13, 2016,

Re: Review Request 54480: Spark 2.x interpreter confgurations in Zeppelin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54480/#review159193 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 14, 2016,

Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support for Hive2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54706/#review159192 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 14, 2016,

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review159191 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 14, 2016,

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review159182 --- Ship it! Ship It! - Tim Thorpe On Dec. 13, 2016, 10:38

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159179 --- 1 notes here: maybe in the near future we should consider to

Re: Review Request 54480: Spark 2.x interpreter confgurations in Zeppelin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54480/ --- (Updated Dec. 14, 2016, 5:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review159177 --- Ship it! Ship It! - Nate Cole On Dec. 13, 2016, 5:38 p.m.,

Re: Review Request 54747: Deployed Views Throw Exceptions On Ambari Server Startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54747/#review159176 --- Ship it! Ship It! - Nate Cole On Dec. 14, 2016, 10:22 a.m.,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 14, 2016, 9:06 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/Closeables.java, > > lines 30-36 > > > > > > Should we consider logging in any way? I don't think it's

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159170 --- Fix it, then Ship it!

Re: Review Request 54750: LLAP app package cleanup fails after Hive Interactive start failure in non-root

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54750/#review159167 --- Ship it! Ship It! - Sumit Mohanty On Dec. 14, 2016, 4:24

Re: Review Request 54749: Devdeploy: Database check failed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54749/#review159165 --- Ship it! Ship It! - Andrew Onischuk On Dec. 14, 2016, 4:04

Re: Review Request 54750: LLAP app package cleanup fails after Hive Interactive start failure in non-root

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54750/#review159164 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 14, 2016,

Review Request 54750: LLAP app package cleanup fails after Hive Interactive start failure in non-root

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54750/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19203

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159162 --- Fix it, then Ship it!

Re: Review Request 54748: Ambari agent can't start when TLSv1 is disabled in Java security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54748/#review159161 --- Ship it! Ship It! - Robert Levas On Dec. 14, 2016, 10:48

Re: Review Request 54749: Devdeploy: Database check failed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54749/#review159160 --- Ship it! Ship It! - Dmytro Sen On Дек. 14, 2016, 4:04 п.п.,

Review Request 54748: Ambari agent can't start when TLSv1 is disabled in Java security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54748/ --- Review request for Ambari, Andrew Onischuk and Robert Levas. Bugs:

Re: Review Request 54747: Deployed Views Throw Exceptions On Ambari Server Startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54747/#review159159 --- Ship it! Ship It! - Robert Levas On Dec. 14, 2016, 10:22

Review Request 54747: Deployed Views Throw Exceptions On Ambari Server Startup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54747/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-19194

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159152 --- Ship it! Ship It! - Miklos Gergely On Dec. 14, 2016, 11:30

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

> On Dec. 14, 2016, 2:06 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/Closeables.java, > > lines 30-36 > > > > > > Should we consider logging in any way? I don't think it's

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159146 --- Fix it, then Ship it!

Re: Review Request 54742: Turning OFF maintenance mode shows a popup on all hosts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54742/#review159147 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 14, 2016,

Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support for Hive2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54706/#review159145 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 14, 2016, 1:26

Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley,

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/ --- (Updated Dec. 14, 2016, 1:30 p.m.) Review request for Ambari, Attila

Re: Review Request 54706: AMBARI-19188 :: Provide Atlas Hook support for Hive2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54706/ --- (Updated Dec. 14, 2016, 1:26 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 9:24 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 3018 > > > > > > Why `public`? (same for

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 12:33 p.m., Oliver Szabo wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 138 > > > > > > server is not really correct name here, use

Review Request 54742: Turning OFF maintenance mode shows a popup on all hosts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54742/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-19200

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 12:33 p.m., Oliver Szabo wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 138 > > > > > > server is not really correct name here, use

Re: Review Request 54698: Disable security hook

> On Dec. 14, 2016, 12:33 p.m., Oliver Szabo wrote: > > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java, > > line 138 > > > > > > server is not really correct name here, use

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159135 ---

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/ --- (Updated Dec. 14, 2016, 12:14 p.m.) Review request for Ambari, Attila

Review Request 54738: Kerberos advanced tab. Page wasn't refreshed after save changes. Save button is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54738/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19197

Re: Review Request 54736: AMS config types created by upgrade were never marked as selected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54736/#review159133 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 14, 2016,

Re: Review Request 54737: Oozie Restart is not prompted on changing MapReduce2 properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54737/#review159132 --- Ship it! Ship It! - Dmytro Sen On Дек. 14, 2016, 11:33

Review Request 54737: Oozie Restart is not prompted on changing MapReduce2 properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54737/ --- Review request for Ambari, Dmitro Lisnichenko and Dmytro Sen. Bugs:

Review Request 54736: AMS config types created by upgrade were never marked as selected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54736/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.

Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Miklos Gergely, and

Re: Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54413/ --- (Updated Dec. 14, 2016, 10:23 a.m.) Review request for Ambari, DIPAYAN

Re: Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/#review159127 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 14, 2016,

Re: Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/#review159128 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 14, 2016,

Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii

Re: Review Request 54477: Update zeppelin configuration for ambari 2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54477/#review159126 --- Ship it! Ship It! - Renjith Kamath On Dec. 14, 2016, 7:27

Re: Review Request 54698: Disable security hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159121 --- ambari-agent/pom.xml

Review Request 54733: Alerts: Create new Alerts Notification type for SNMP to handle Ambari MIB

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54733/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review159123 --- Ship it! Ship It! - Gautam Borad On Dec. 13, 2016, 12:40