Review Request 55163: ambai-web action to download all client configs of host

2017-01-03 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55163/ --- Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/ --- (Updated Jan. 4, 2017, 7:16 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55012/ --- (Updated Jan. 4, 2017, 7:15 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/ --- (Updated Jan. 4, 2017, 7:14 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/#review160467 --- Ship it! Ship It! - Gaurav Nagar On Jan. 4, 2017, 5:55 a.m.,

Re: Review Request 55087: Zeppelin stop failed during EU while deleting pid file with customized service user

2017-01-03 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55087/#review160466 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 29, 2016, 5:09 p

Re: Review Request 55087: Zeppelin stop failed during EU while deleting pid file with customized service user

2017-01-03 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55087/#review160465 --- Ship it! Ship It! - Rohit Choudhary On Dec. 29, 2016, 5:09 p

Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/ --- (Updated Jan. 4, 2017, 5:55 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55012/ --- (Updated Jan. 4, 2017, 5:54 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/ --- (Updated Jan. 4, 2017, 5:54 a.m.) Review request for Ambari, Gaurav Nagar, Niti

Re: Review Request 55144: Infra Solr Client logging is not working

2017-01-03 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55144/#review160462 --- Ship it! Ship It! - Miklos Gergely On Jan. 3, 2017, 5:10 p.m

Review Request 55159: AMBARI-19348 - Version number is incorrect when upgrade wizard is opened from Upgrade History

2017-01-03 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55159/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-19348 https://issues.ap

Re: Review Request 55153: Previous Upgrade In Progress Pre-Req Check Incorrectly Detects ABORTED Upgrade

2017-01-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55153/ --- (Updated Jan. 3, 2017, 8:04 p.m.) Review request for Ambari, Dmitro Lisnichenko

Review Request 55153: Previous Upgrade In Progress Pre-Req Check Incorrectly Detects ABORTED Upgrade

2017-01-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55153/ --- Review request for Ambari, Dmitro Lisnichenko and Nate Cole. Bugs: AMBARI-19347

Re: Review Request 55144: Infra Solr Client logging is not working

2017-01-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55144/#review160414 --- Ship it! Ship It! - Robert Nettleton On Jan. 3, 2017, 5:10 p

Re: Review Request 55073: Stack advisor doesn't recommend distributed mode for AMS HA clusters

2017-01-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55073/#review160413 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 28, 2016, 2:13

Re: Review Request 55146: Add log rotation settings to Oozie

2017-01-03 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55146/#review160408 --- Ship it! Ship It! - Sumit Mohanty On Jan. 3, 2017, 5:53 p.m.

Re: Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55136/#review160406 --- Ship it! Ship It! - Sid Wagle On Jan. 3, 2017, 12:13 p.m., D

Re: Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Dmytro Sen
> On Янв. 3, 2017, 5:55 п.п., Sid Wagle wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 129 > > > > > > Does the stack have correct default of 1024? It's 512 in stac

Re: Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55136/#review160401 --- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_

Re: Review Request 55119: Store LogSearch truststore/keystore passwords in file

2017-01-03 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55119/#review160400 --- Ship it! Ship It! - Robert Levas On Jan. 3, 2017, 10:50 a.m.

Review Request 55146: Add log rotation settings to Oozie

2017-01-03 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55146/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19343 https://iss

Review Request 55144: Infra Solr Client logging is not working

2017-01-03 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55144/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 55107: LogSearch upgrade support 2.4 -> 2.5

2017-01-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55107/#review160393 --- Fix it, then Ship it! The patch looks fine to me, just a minor

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-03 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54970/#review160392 --- Ship it! Ship It! - Di Li On Dec. 24, 2016, 7:12 a.m., ping

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-03 Thread Jonathan Hurley
> On Dec. 28, 2016, 9:36 a.m., Jonathan Hurley wrote: > > Although I do not see anything wrong with this implementation, I'm curious > > why we simply can't use a single lock for this. Why do we need specific > > locks per component? > > > > Shouldn't it be enough to have a single lock which

Re: Review Request 55119: Store LogSearch truststore/keystore passwords in file

2017-01-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55119/#review160386 --- Ship it! This looks fine to me. Could you also add rlevas to t

Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.

2017-01-03 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/#review160384 --- Ship it! Ship It! - Sumit Mohanty On Jan. 3, 2017, 8:41 a.m.

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-03 Thread Attila Doroszlai
> On Dec. 28, 2016, 3:36 p.m., Jonathan Hurley wrote: > > Although I do not see anything wrong with this implementation, I'm curious > > why we simply can't use a single lock for this. Why do we need specific > > locks per component? > > > > Shouldn't it be enough to have a single lock which

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-03 Thread Jonathan Hurley
> On Dec. 28, 2016, 9:36 a.m., Jonathan Hurley wrote: > > Although I do not see anything wrong with this implementation, I'm curious > > why we simply can't use a single lock for this. Why do we need specific > > locks per component? > > > > Shouldn't it be enough to have a single lock which

Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.

2017-01-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/#review160381 --- Ship it! Ship It! - Jonathan Hurley On Jan. 3, 2017, 3:41 a.

Review Request 55141: Not able to update the role for a given user

2017-01-03 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55141/ --- Review request for Ambari, Andrew Onischuk, Robert Levas, and Vitalyi Brodetskyi

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-03 Thread Attila Doroszlai
> On Dec. 28, 2016, 3:36 p.m., Jonathan Hurley wrote: > > Although I do not see anything wrong with this implementation, I'm curious > > why we simply can't use a single lock for this. Why do we need specific > > locks per component? > > > > Shouldn't it be enough to have a single lock which

Re: Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

2017-01-03 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55137/#review160379 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 3, 2017, 1:16 p.

Re: Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55137/#review160378 --- Ship it! Ship It! - Gaurav Nagar On Jan. 3, 2017, 1:16 p.m.,

Re: Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

2017-01-03 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55137/#review160377 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 3, 2017, 1:04 p

Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

2017-01-03 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55137/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, and Rohit Choudhar

Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes

2017-01-03 Thread Ashwin Rajeev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/#review160375 --- Ship it! Ship It! - Ashwin Rajeev On Jan. 3, 2017, 9:25 a.m.

Review Request 55136: AM sizing for LLAP - min container size changes

2017-01-03 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55136/ --- Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. Bu

Re: Review Request 55099: Disable auto start before RU/EU and enable during finalization phase

2017-01-03 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55099/#review160374 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 30, 2016, 11

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/#review160371 --- Ship it! Ship It! - Gaurav Nagar On Jan. 3, 2017, 9:18 a.m.,

Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes

2017-01-03 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/#review160369 --- Ship it! Ship It! - Rohit Choudhary On Jan. 3, 2017, 9:25 a.

Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/#review160366 --- Ship it! Ship It! contrib/views/wfmanager/src/main/java/org/a

Re: Review Request 55014: AMBARI-19292: Asset Manager/Asset Upload/Asset import from DB

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55014/#review160365 --- Ship it! Ship It! - Gaurav Nagar On Dec. 23, 2016, 12:01 p.m

Re: Review Request 55014: AMBARI-19292: Asset Manager/Asset Upload/Asset import from DB

2017-01-03 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55014/#review160364 --- Ship it! Ship It! - Pallav Kulshreshtha On Dec. 23, 2016, 12

Re: Review Request 55119: Store LogSearch truststore/keystore passwords in file

2017-01-03 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55119/#review160363 --- Ship it! Ship It! - Miklos Gergely On Jan. 2, 2017, 12:22 p.

Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2017-01-03 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55012/#review160362 --- Ship it! Ship It! - Nitiraj Rathore On Dec. 23, 2016, 10:53

Re: Review Request 55126: Need to support permission in string format for FS action node

2017-01-03 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55126/#review160360 --- Ship it! Ship It! - Renjith Kamath On Jan. 3, 2017, 9:38 a.m

Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshth

Re: Review Request 55126: Need to support permission in string format for FS action node

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55126/#review160358 --- Ship it! Ship It! - Gaurav Nagar On Jan. 3, 2017, 9:38 a.m.,

Re: Review Request 55126: Need to support permission in string format for FS action node

2017-01-03 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55126/ --- (Updated Jan. 3, 2017, 9:38 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes

2017-01-03 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/#review160357 --- Ship it! Ship It! - Gaurav Nagar On Jan. 3, 2017, 9:25 a.m.,

Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2017-01-03 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55012/#review160356 --- Ship it! Ship It! - Pallav Kulshreshtha On Dec. 23, 2016, 10

Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin

2017-01-03 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54857/#review160354 --- Ship it! Ship It! - Rohit Choudhary On Jan. 2, 2017, 2:23 p.

Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

2017-01-03 Thread belliraj hb
> On Dec. 27, 2016, 7:34 a.m., Nitiraj Rathore wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js, > > line 57 > > > > > > you should send some status code from server side and ch

Re: Review Request 55082: Change IFrame container layout for the Ambari Views from fixed to fluid

2017-01-03 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55082/#review160355 --- Ship it! Ship It! - Rohit Choudhary On Dec. 29, 2016, 12:23

Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes

2017-01-03 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/ --- (Updated Jan. 3, 2017, 9:25 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate

2017-01-03 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshth

Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.

2017-01-03 Thread Jay SenSharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and