Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/ --- (Updated March 31, 2017, 9:16 p.m.) Review request for Ambari, Alejandro

Review Request 58129: HDP 3.0 TP - add Pig client: configs, metainfo, descriptors, service advisor and etc

2017-03-31 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58129/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-20652

Review Request 58124: AMBARI-20651 - When in Upgrade paused state, links should be disabled for less privileged user

2017-03-31 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58124/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-20651

Review Request 58122: Blueprint export fails if config-type is not mapped to any service after upgrade

2017-03-31 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58122/ --- Review request for Ambari, Di Li and Robert Nettleton. Bugs: AMBARI-20551

Re: Review Request 58106: AMBARI-20636 Allow users to add custom configs for Ranger service in all plugins

2017-03-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58106/#review170795 --- Ship it! Ship It! - Alejandro Fernandez On March 31, 2017,

Re: Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-03-31 Thread Alejandro Fernandez
> On March 28, 2017, 9:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java > > Lines 161 (patched) > > > > > > Are these all removed

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Jonathan Hurley
> On March 31, 2017, 5:07 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > > Lines 184-185 (original), 153-154 (patched) > > > > > > By using a more comple

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/#review170773 --- Ship it! Ship It!

Re: Review Request 58051: Misc fixes for ambari-server swagger integration prototype

2017-03-31 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58051/#review170768 --- Ship it! Ship It! - Oliver Szabo On March 29, 2017, 10:51

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170765 ---

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170759 --- Ship it! I tested out the patch. Nice job. - Robert Levas

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Attila Magyar
> On March 31, 2017, 5:45 p.m., Robert Levas wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py > > Lines 877 (patched) > > > > > > It is not a good idea to chmod 600 the

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/ --- (Updated March 31, 2017, 3:02 p.m.) Review request for Ambari, Alejandro

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170747 --- Fix it, then Ship it! Ship It!

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/#review170746 --- Ship it! Ship It! - Alejandro Fernandez On March 31, 2017,

Re: Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/ --- (Updated March 31, 2017, 1:22 p.m.) Review request for Ambari, Alejandro

Review Request 58109: Large Long Running Requests Can Slow Down the ActionScheduler

2017-03-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58109/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170736 --- Ship it! Ship It! - Sebastian Toader On March 31, 2017,

Re: Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-03-31 Thread Di Li
> On March 28, 2017, 9:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java > > Lines 161 (patched) > > > > > > Are these all removed

Re: Review Request 58079: Cleanup temporary files needed for downloading client configurations response

2017-03-31 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/ --- (Updated March 31, 2017, 3:57 p.m.) Review request for Ambari, Attila

Re: Review Request 58092: Upgrade server-side actions should be performed only one time per group (ncole)

2017-03-31 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58092/#review170724 --- Ship it! Just the nit about the logging. I agree about not

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170721 --- Ship it! Patch looks fine, just a minor suggestion for a

Review Request 58107: Integrate coilmq stomp server as a mock server for ambari-agent unittests.

2017-03-31 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58107/ --- Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. Bugs:

Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/ --- (Updated March 31, 2017, 8:02 p.m.) Review request for Ambari, Attila

Re: Review Request 58105: Ambari Log Search Web - fix some build npm errors

2017-03-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58105/#review170716 --- Ship it! Ship It! - Robert Nettleton On March 31, 2017,

Re: Review Request 58105: Ambari Log Search Web - fix some build npm errors

2017-03-31 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58105/#review170713 --- Ship it! Ship It! - Miklos Gergely On March 31, 2017, 11:21

Re: Review Request 58079: Add stronger file permissions to temporary files generated by downloading client configurations

2017-03-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/#review170711 --- Ship it! Ship It! - Sebastian Toader On March 31, 2017,

Review Request 58079: Add stronger file permissions to temporary files generated by downloading client configurations

2017-03-31 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58079/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo Puskas,

Review Request 58105: Ambari Log Search Web - fix some build npm errors

2017-03-31 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58105/ --- Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 31, 2017, 10:15 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170686 --- Ship it! Ship It! - Renjith Kamath On March 31, 2017, 6:57

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/#review170685 --- Ship it! Ship It! - Sebastian Toader On March 30, 2017,

Re: Review Request 58083: AMBARI-20625. Hadoop QA javac warnings increase check is broken -- fix for ambari-server

2017-03-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58083/#review170684 --- Ship it! Ship It! - Sebastian Toader On March 30, 2017, 6

Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170683 --- Ship it! Ship It! - Gaurav Nagar On March 31, 2017, 6:57

Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170682 --- Ship it! Ship It! - Pallav Kulshreshtha On March 31, 2017,

Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170681 --- Ship it! Ship It! - Rohit Choudhary On March 31, 2017, 6:57

Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter

2017-03-31 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN