Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172586 ---

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/#review172567 --- Ship it! Ship It! - Jaimin Jetly On April 21, 2017, 12:09

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/ --- (Updated April 21, 2017, 12:09 a.m.) Review request for Ambari, Jaimin Jetly

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/#review172560 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On April 20,

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/ --- (Updated April 20, 2017, 10:43 p.m.) Review request for Ambari, Jaimin Jetly

Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/ --- Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.

Re: Review Request 58592: Upgrade is not taking care of AMBARI-15677

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58592/#review172552 --- Ship it! Ship It! - Alejandro Fernandez On April 20, 2017,

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172549 ---

Review Request 58592: Upgrade is not taking care of AMBARI-15677

2017-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58592/ --- Review request for Ambari, Dmitro Lisnichenko and Nate Cole. Bugs:

Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser

2017-04-20 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58591/ --- Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172542 --- Has upgrade been tested? - Tim Thorpe On April 20, 2017, 7:53

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-20 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/ --- (Updated April 20, 2017, 7:53 p.m.) Review request for Ambari, Di Li and Tim

Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE

2017-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58583/#review172537 --- Ship it! Can we write a simple unit test to verify that on a

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-20 Thread Vitalyi Brodetskyi
> On Квітень 20, 2017, 6:11 після полудня, Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > > Lines 430 (patched) > > > > > > Why does core-site need

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Miklos Gergely
> On April 20, 2017, 6:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py > > Lines 30 (patched) > > > > > > Is Logsearch Server

Re: Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58579/#review172530 --- Ship it! Ship It! - Robert Nettleton On April 20, 2017,

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58562/#review172529 --- Ship it! Ship It! - Robert Nettleton On April 20, 2017,

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58568/#review172528 ---

Re: Review Request 58576: AMBARI-20792 : Atlas admin username and password should be configurable through ambari

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58576/#review172527 --- Ship it! Ship It! - Alejandro Fernandez On April 20, 2017,

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58562/#review172525 ---

Re: Review Request 58555: Ambari agent should log how it determines it's FQDN

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58555/#review172524 --- Ship it! Ship It! - Alejandro Fernandez On April 20, 2017,

Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE

2017-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58583/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-20811

Re: Review Request 58444: Log Feeder fill cluster name if it is not set

2017-04-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58444/#review172522 --- Ship it! Ship It! - Robert Nettleton On April 14, 2017,

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/#review172521 --- Fix it, then Ship it!

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

2017-04-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58577/#review172515 ---

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-20 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58568/#review172516 --- Ship it! Hi Vitaly, Please make note that for trunk,

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

2017-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58577/#review172514 --- Fix it, then Ship it!

Re: Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

2017-04-20 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58579/#review172512 --- Ship it! Ship It! - Miklos Gergely On April 20, 2017, 4:13

Re: Review Request 58578: Log Search REST API calls for configuration should send proper error responses

2017-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58578/#review172510 --- Ship it! Ship It! - Oliver Szabo On April 20, 2017, 4:21

Review Request 58578: Log Search REST API calls for configuration should send proper error responses

2017-04-20 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58578/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

2017-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58579/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

2017-04-20 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57610/#review172506 --- I've suggested using the thread local but overall looking at the

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/#review172500 --- Ship it! Ship It! - Sebastian Toader On April 20, 2017,

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/ --- (Updated April 20, 2017, 3:51 p.m.) Review request for Ambari, Attila

Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

2017-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58577/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-20805

Re: Review Request 58569: Ambari fails to upgrade from 2.4.2.0 to 2.5.1.0 during schema upgrade with NPE

2017-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58569/#review172498 --- Ship it! Ship It! - Nate Cole On April 20, 2017, 8:59 a.m.,

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/#review172497 ---

Re: Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

2017-04-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58565/#review172494 --- Ship it! Ship It! - Laszlo Puskas On April 20, 2017, 2:53

Re: Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/#review172491 --- Ship it! Ship It! - Robert Levas On April 20, 2017, 10:28

Re: Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

2017-04-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58565/#review172492 --- Ship it! Ship It! - Sebastian Toader On April 20, 2017,

Review Request 58576: AMBARI-20792 : Atlas admin username and password should be configurable through ambari

2017-04-20 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58576/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj,

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58568/#review172489 --- Ship it! Ship It! - Sumit Mohanty On April 20, 2017, 2:19

Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

2017-04-20 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58575/ --- Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.

Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

2017-04-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58565/ --- Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit

Review Request 58574: BE: Characters used in usernames should be constrained

2017-04-20 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58574/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas,

Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager

2017-04-20 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58564/#review172484 --- Ship it! Ship It! - belliraj hb On April 20, 2017, 12:01

Re: Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

2017-04-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58566/#review172480 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 20, 2017,

Re: Review Request 58571: Devdeploy: Logsearch service check fails

2017-04-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58571/#review172479 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 20, 2017,

Review Request 58571: Devdeploy: Logsearch service check fails

2017-04-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58571/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-20803

Review Request 58569: Ambari fails to upgrade from 2.4.2.0 to 2.5.1.0 during schema upgrade with NPE

2017-04-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58569/ --- Review request for Ambari, Dmytro Grinenko and Nate Cole. Bugs: AMBARI-20799

Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

2017-04-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58568/ --- Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty. Bugs:

Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager

2017-04-20 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58564/#review172475 --- Ship it! Ship It! - venkat sairam On April 20, 2017, 12:01

Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

2017-04-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58566/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-20801

Review Request 58564: Need to change the arrangement of the action buttons in project manager

2017-04-20 Thread Supreeth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58564/ --- Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58562/ --- (Updated April 20, 2017, 11:51 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Keta Patel
> On April 20, 2017, 4:44 p.m., Oliver Szabo wrote: > > Ship It! > > Keta Patel wrote: > Thank you! > Could you please help me with pushing in the change? > > Oliver Szabo wrote: > thanks for the contribution. > patches are merged: > - trunk:

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

2017-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58562/#review172471 --- Ship it! Ship It! - Oliver Szabo On April 20, 2017, 11:40

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Keta Patel
> On April 20, 2017, 4:44 p.m., Oliver Szabo wrote: > > Ship It! Thank you! Could you please help me with pushing in the change? - Keta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58493/#review172467 --- Ship it! Ship It! - Oliver Szabo On April 20, 2017, 11:13

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Keta Patel
> On April 20, 2017, 3:22 p.m., Miklos Gergely wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java > > Line 126 (original), 126 (patched) > >

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Keta Patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58493/ --- (Updated April 20, 2017, 4:43 p.m.) Review request for Ambari, Di Li, Miklos

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

2017-04-20 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58493/#review172460 --- Fix it, then Ship it! Ship It!

Re: Review Request 58555: Ambari agent should log how it determines it's FQDN

2017-04-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58555/#review172458 --- Ship it! Ship It! - Attila Doroszlai On April 20, 2017,

Re: Review Request 58551: Miscellaneous fixes to support HDP 3.0 Tech Preview

2017-04-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58551/#review172457 --- Ship it! Ship It! - Dmitro Lisnichenko On April 20, 2017,

Review Request 58555: Ambari agent should log how it determines it's FQDN

2017-04-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58555/ --- Review request for Ambari, Attila Doroszlai and Andrew Onischuk. Bugs: