Re: Review Request 59741: File View : Download using Concatenate results in incorrect data

2017-06-01 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/#review176738 --- Ship it! Ship It! - Gaurav Nagar On June 2, 2017, 6:25 a.m.,

Review Request 59741: File View : Download using Concatenate results in incorrect data

2017-06-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59741/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-01 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59701/#review176733 --- Ship it! Ship It! - Mugdha Varadkar On June 1, 2017, 5:04 a.

Re: Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.

2017-06-01 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59679/#review176727 --- Fix it, then Ship it! Ship It! contrib/views/commons/src/main

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/ --- (Updated 六月 2, 2017, 1:31 a.m.) Review request for Ambari, Alejandro Fernandez,

Re: Review Request 59648: Add a flag to indicate NN restart is rolling

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59648/#review176690 --- ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/p

Re: Review Request 59475: Provide additional logging for config audit log

2017-06-01 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59475/#review176689 --- Ship it! Ship It! - Sid Wagle On June 1, 2017, 9:57 p.m., Al

Re: Review Request 59475: Provide additional logging for config audit log

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59475/#review176685 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Re: Review Request 59475: Provide additional logging for config audit log

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59475/ --- (Updated June 1, 2017, 9:57 p.m.) Review request for Ambari, Sumit Mohanty, Swa

Re: Review Request 59684: Log more info about heartbeat message/response when server - agent communication gets out of sync

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59684/#review176680 --- Ship it! Ship It! - Alejandro Fernandez On May 31, 2017, 1:4

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/#review176659 --- ambari-server/src/main/java/org/apache/ambari/server/stageplanner

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/ --- (Updated June 1, 2017, 8:35 p.m.) Review request for Ambari and Tim Thorpe. B

Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-21161 https://issues

Re: Review Request 59649: Delete view privileges from the Users page

2017-06-01 Thread Di Li
> On June 1, 2017, 5:39 p.m., Di Li wrote: > > Ship It! > > Anita Jebaraj wrote: > Can you please help in pushing the changes? done, you can close this request now - Di --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-06-01 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59639/ --- (Updated June 1, 2017, 7:56 p.m.) Review request for Ambari, Di Li and Robert N

Re: Review Request 59609: Export cluster_name in the cluster template file

2017-06-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59609/#review176649 --- please close this one if it has been committed - Di Li On May 3

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-01 Thread Qin Liu
> On May 18, 2017, 9:54 a.m., Dmytro Sen wrote: > > Please check if changes from ambari-server/src/main/resources/stacks/HDP/* > > need to be duplicated for services that has been flattened for stack 3.0 > > Qin Liu wrote: > Hi Dmytro, > > Thank you for reviewing! > > I wa

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-01 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59149/ --- (Updated June 1, 2017, 6:52 p.m.) Review request for Ambari, Aravindan Vijayan,

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176642 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176640 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 59649: Delete view privileges from the Users page

2017-06-01 Thread Anita Jebaraj
> On June 1, 2017, 5:39 p.m., Di Li wrote: > > Ship It! Can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/#review176633 ---

Re: Review Request 59649: Delete view privileges from the Users page

2017-06-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/#review176633 --- Ship it! Ship It! - Di Li On May 30, 2017, 8:10 p.m., Anita

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-06-01 Thread Tim Thorpe
> On June 1, 2017, 5:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > > Line 351 (original) > > > > > > If we remove this block, it will create a

Re: Review Request 59649: Delete view privileges from the Users page

2017-06-01 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/#review176628 --- Ship it! Ship It! - Alexandr Antonenko On May 30, 2017, 8:10

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/#review176625 --- ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/m

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/#review176624 --- Ship it! Address review comment and commit - Jayush Luniya O

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/#review176623 --- ambari-common/src/main/python/ambari_commons/inet_utils.py Lines

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59520/#review176621 --- Ship it! Ship It! - Alejandro Fernandez On May 30, 2017, 1:1

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176619 --- ambari-server/src/main/java/org/apache/ambari/server/orm/entities

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Dmitro Lisnichenko
> On June 1, 2017, 6:22 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/python/ambari-server.py > > Line 800 (original) > > > > > > Why is this added back? The upgrade stack option should be removed > > sinc

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176616 --- ambari-server/src/main/python/ambari-server.py Line 800 (original

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Jonathan Hurley
> On June 1, 2017, 10:23 a.m., Dmitro Lisnichenko wrote: > > Yeah - a result of the bulk-merging we had to do. Sometimes Eclipse picked the wrong imports I guess. Thanks for finding these! - Jonathan --- This is an automatically genera

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/ --- (Updated Червень 1, 2017, 3:03 після полудня) Review request for Ambari, Andrew

Re: Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/#review176613 --- Ship it! Ship It! - Jayush Luniya On June 1, 2017, 1:46 p.m.

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176612 --- ambari-server/src/main/java/org/apache/ambari/server/orm/entities

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/ --- (Updated June 1, 2017, 5:22 p.m.) Review request for Ambari, Jonathan Hurley an

Review Request 59718: mpack install fails when using https links

2017-06-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/ --- Review request for Ambari, Andrew Onischuk and Jayush Luniya. Bugs: AMBARI-2116

Re: Review Request 59682: AMBARI-19149. Code cleanup: concatenation in debug messages, unnecessary toString calls

2017-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59682/#review176610 --- Ship it! Ship It! - Nate Cole On May 31, 2017, 7:07 a.m., At

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
> On 六月 1, 2017, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer: > >

Re: Review Request 59693: Upgrade Execution Commands Are Missing Service/Component For Action Commands

2017-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59693/ --- (Updated June 1, 2017, 9:04 a.m.) Review request for Ambari, Dmytro Grinenko, J

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176608 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
> On 六月 1, 2017, 12:10 p.m., Tim Thorpe wrote: > > Ship It! Thanks a lot - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176601

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176601 --- Ship it! Ship It! - Tim Thorpe On June 1, 2017, 1:37 a.m., y

Review Request 59711: Register with server and changes to events format and handle graceful stop or threads

2017-06-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59711/ --- Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid W

Re: Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv

2017-06-01 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/#review176598 --- Ship it! Ship It! - Gaurav Nagar On June 1, 2017, 8:02 a.m.,

Re: Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv

2017-06-01 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/#review176593 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 1, 2017, 8:02 a

Re: Review Request 59694: Enabling Kerberos should use cluster stack id

2017-06-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59694/#review176590 --- Ship it! Ship It! - Dmitro Lisnichenko On June 1, 2017, 12:2

Re: Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv

2017-06-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/ --- (Updated June 1, 2017, 8:02 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Review Request 59704: Hive view not exporting/downloading the worksheet with entire number of rows to csv

2017-06-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59704/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,