Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-12 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/ --- (Updated June 13, 2017, 5:44 a.m.) Review request for Ambari and Sumit Mohanty.

Review Request 60033: Ambari data purging

2017-06-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60033/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo Puskas,

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-12 Thread Saisai Shao
> On June 12, 2017, 3:12 p.m., Sumit Mohanty wrote: > > I do not think we need changes to 2.3-2.5 upgrade XMLs as these new configs > > in HDP-2.6 are auto added as they did not exist in older versions. You can > > confirm this with Jonathan Hurley or Nate Cole as well. SO only change > > need

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

2017-06-12 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 12, 2017, 10:09 p.m.) Review request for Ambari, Attila Doroszlai

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-12 Thread Aravindan Vijayan
> On June 9, 2017, 11:13 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetricMetadata.java > > Lines 165 (patched) > > > > > > Else con

Re: Review Request 59948: AMBARI-20853. Service Advisor - Allow Service to define its Advisor Type as Python or Java

2017-06-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59948/ --- (Updated June 12, 2017, 8:03 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Sebastian Toader
> On June 12, 2017, 4:06 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > > Line 483 (original), 524 (patched) > > > > > > Should this method be

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-12 Thread Sid Wagle
> On June 9, 2017, 11:13 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java > > Lines 436 (patched) > >

Re: Review Request 60011: Remove Zookeeper as a required service from YARN

2017-06-12 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60011/#review177664 --- Ship it! Ship It! - Di Li On June 12, 2017, 5:44 p.m., Tim T

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-12 Thread Aravindan Vijayan
> On June 9, 2017, 11:13 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java > > Lines 436 (patched) > >

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Robert Levas
> On June 12, 2017, 10:06 a.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java > > Lines 97 (patched) > > > > > > I think cascading should be removed here (

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Sebastian Toader
> On June 12, 2017, 4:06 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java > > Lines 97 (patched) > > > > > > I think cascading should be removed here (A

Re: Review Request 60011: Remove Zookeeper as a required service from YARN

2017-06-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60011/#review177649 --- Ship it! Ship It! - Alejandro Fernandez On June 12, 2017, 5:

Review Request 60011: Remove Zookeeper as a required service from YARN

2017-06-12 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60011/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, and Nate

Re: Review Request 59997: AMBARI-21227 Updating Ranger install.properties file

2017-06-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59997/#review177648 --- Ship it! Ship It! - Alejandro Fernandez On June 12, 2017, 10

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59956/ --- (Updated June 12, 2017, 1:15 p.m.) Review request for Ambari, Attila Magyar, Ba

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Robert Levas
> On June 12, 2017, 10:06 a.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > > Line 483 (original), 524 (patched) > > > > > > Should this method be

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Robert Levas
> On June 12, 2017, 10:06 a.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java > > Lines 97 (patched) > > > > > > I think cascading should be removed here (

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review177633 --- Ship it! Ship It! - Nate Cole On June 12, 2017, 9:38 a.m., D

Re: Review Request 59948: AMBARI-20853. Service Advisor - Allow Service to define its Advisor Type as Python or Java

2017-06-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59948/#review177629 --- Fix it, then Ship it! ambari-server/src/test/java/org/apache/a

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/#review177628 --- Ship it! Ship It! - Sebastian Toader On June 12, 2017, 2:44

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/#review177624 --- Ship it! Ship It! - Robert Nettleton On June 12, 2017, 12:44

Re: Review Request 60007: Rename userconfig resource to event history in Log Search Portal

2017-06-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60007/#review177623 --- Ship it! Ship It! - Robert Nettleton On June 12, 2017, 3:17

Review Request 60007: Rename userconfig resource to event history in Log Search Portal

2017-06-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60007/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: AMBARI-21

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/#review177621 --- I do not think we need changes to 2.3-2.5 upgrade XMLs as these ne

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/#review177619 --- ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/co

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-12 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59956/#review177610 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/ --- (Updated June 12, 2017, 4:38 p.m.) Review request for Ambari, Jonathan Hurley a

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/#review177609 --- Ship it! Ship It! - Robert Levas On June 12, 2017, 8:44 a.m.

Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert Nett

Re: Review Request 59945: Missing os_family causes a warning during host check

2017-06-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59945/#review177603 --- Ship it! Ship It! - Attila Doroszlai On June 9, 2017, 3:13 p

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

2017-06-12 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/#review177602 --- Fix it, then Ship it! Nice. utility/pom.xml Lines 42 (patched

Review Request 59997: AMBARI-21227 Updating Ranger install.properties file

2017-06-12 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59997/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Velmurugan Per

Re: Review Request 59979: RU: Oozie LR job failed

2017-06-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59979/#review177594 --- Ship it! Ship It! - Dmitro Lisnichenko On June 11, 2017, 4:0

Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-12 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-21226 https://iss