Re: Review Request 61197: Log Feeder properties should be handled by one class

2017-08-01 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61197/ --- (Updated Aug. 2, 2017, 4:30 a.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181936 ---

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181928 ---

Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro

Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Sumit Mohanty, Sid Wagle,

Re: Review Request 61209: Log Search should stop using deprecated API for solr

2017-08-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61209/#review181908 --- Ship it! Ship It! - Alejandro Fernandez On July 28, 2017,

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-01 Thread Jayush Luniya
> On Aug. 1, 2017, 5:51 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > > Lines 234 (patched) > > > > > > Shouldn't this be

Re: Review Request 61276: Replace Hard Coded conf-select Structures

2017-08-01 Thread Jonathan Hurley
> On Aug. 1, 2017, 1:12 p.m., Dmitro Lisnichenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > > Line 24 (original), 24 (patched) > > > > > > I think we usually do

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-01 Thread Swapan Shridhar
> On Aug. 1, 2017, 5:51 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > > Lines 234 (patched) > > > > > > Shouldn't this be

Re: Review Request 61276: Replace Hard Coded conf-select Structures

2017-08-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61276/#review181903 --- Fix it, then Ship it!

Re: Review Request 61209: Log Search should stop using deprecated API for solr

2017-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61209/#review181902 --- Ship it! Ship It! - Oliver Szabo On July 28, 2017, 12:25

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181897 --- Ship it! Ship It! - Sebastian Toader On Aug. 1, 2017, 4:56

Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

2017-08-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/#review181896 ---

Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

2017-08-01 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/ --- (Updated Aug. 1, 2017, 2:56 p.m.) Review request for Ambari, Balázs Bence

Review Request 61276: Replace Hard Coded conf-select Structures

2017-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61276/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/#review181893 --- Ship it! Ship It! - Robert Nettleton On Aug. 1, 2017, 7:04

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181891 --- This looks great. I like the concept.

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/#review181889 --- Ship it! Ship It! - Jonathan Hurley On Aug. 1, 2017, 3:04

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181888 ---

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/#review181887 --- Ship it! Ship It! - Sebastian Toader On Aug. 1, 2017, 9:04

Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/ --- Review request for Ambari, Balázs Bence Sári, Robert Levas, and Sebastian

Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/ --- Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.

Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/ --- Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian