Re: Review Request 64111: AMBARI-22527: Error while viewing topology details - Storm View

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64111/#review192100 --- Ship it! Ship It! - Sriharsha Chintalapani On Nov. 28, 2017

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62801/#review187474 --- Ship it! Ship It! - Sriharsha Chintalapani On Oct. 6, 2017

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62801/#review187475 --- Ship it! Ship It! - Sriharsha Chintalapani On Oct. 6, 2017

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

Storm. - Sriharsha Chintalapani On Sept. 14, 2017, 7:11 a.m., Sanket Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

10.x onwards - Sriharsha Chintalapani On July 4, 2017, 6:53 p.m., Ambud Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 59612: AMBARI-21136: Upgrading Ambari to 2.5.1 stops Storm's nimbus in secure mode.

e.org/r/59612/diff/1/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

iff/9/ Changes: https://reviews.apache.org/r/59459/diff/8-9/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

https://reviews.apache.org/r/59459/diff/7-8/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

https://reviews.apache.org/r/59459/diff/6-7/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14 ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 Diff: https://reviews.apache.org/r/59459/diff/6/ Changes: https://reviews.apache.org/r/59459/diff/5-6/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14 ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 Diff: https://reviews.apache.org/r/59459/diff/5/ Changes: https://reviews.apache.org/r/59459/diff/4-5/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14 ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 Diff: https://reviews.apache.org/r/59459/diff/4/ Changes: https://reviews.apache.org/r/59459/diff/3-4/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.

tacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14 ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 Diff: https://reviews.apache.org/r/59459/diff/3/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57139/#review167793 --- Ship it! Ship It! - Sriharsha Chintalapani On March 2, 2017

Re: Review Request 57139: AMBARI-20208 : Atlas kafka servers should be configured using kafka listeners.

or test manually if the protocol is SASL_PLAINTEXT. As per the code it looks like handling it but good to test this part. - Sriharsha Chintalapani On March 1, 2017, 12:36 p.m., Vishal Suvagia wrote: > > --- > This is an auto

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53597/#review155880 --- Ship it! Ship It! - Sriharsha Chintalapani On Nov. 15, 2016

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53597/#review155876 --- Minor nit pick. once fixed ship it. - Sriharsha Chintalapani

Re: Review Request 53597: Allow Ambari to manage Kafka's Custom JAAS Config.

/configuration/kafka_client_jaas_conf.xml (line 34) <https://reviews.apache.org/r/53597/#comment225978> we don't need client section here for kafka_client_jaas - Sriharsha Chintalapani On Nov. 9, 2016, 6:22 a.m., Sumit Mo

Re: Review Request 50529: Kafka brokers went down after Ambari upgrade due to IllegalArgumentException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50529/#review143796 --- Ship it! Ship It! - Sriharsha Chintalapani On July 27, 2016

Re: Review Request 50479: AMBARI-17909 AMS Storm Sink: apply change of Storm metrics improvement - worker level aggregation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50479/#review143768 --- Ship it! Ship It! - Sriharsha Chintalapani On July 27, 2016

Re: Review Request 50479: AMBARI-17909 AMS Storm Sink: apply change of Storm metrics improvement - worker level aggregation

cally generated e-mail. To reply, visit: > https://reviews.apache.org/r/50479/ > --- > > (Updated July 27, 2016, 1:58 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid > Wagle. > > > Bugs: AMBARI-17909 > https://iss

Re: Review Request 50479: AMBARI-17909 AMS Storm Sink: apply change of Storm metrics improvement - worker level aggregation

/0.1.0/configuration/storm-site.xml (line 54) <https://reviews.apache.org/r/50479/#comment209508> we should make this as true on-upgrade no? - Sriharsha Chintalapani On July 27, 2016, 1:58 a.m., Jungtaek Lim wrote: > > -

Re: Review Request 50063: AMBARI-17725: AMS Storm Sink: Storm topology level metrics should have prefix to distinguish cluster level metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50063/#review142955 --- Ship it! Ship It! - Sriharsha Chintalapani On July 15, 2016

Re: Review Request 50220: AMBARI-17724 AMS Storm sink: Set metrics filter to reduce large amount of built-in Storm metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50220/#review142954 --- Ship it! Ship It! - Sriharsha Chintalapani On July 20, 2016

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50180/#review142848 --- Ship it! Ship It! - Sriharsha Chintalapani On July 19, 2016

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

/reviews.apache.org/r/50180/ > --- > > (Updated July 19, 2016, 6:41 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid > Wagle. > > > Bugs: AMBARI-17784 > https://issues.apache.org/jira/browse

Re: Review Request 49908: Storm Ambari View should provide a config page & make calls to Storm Rest API

.jsx 7486948 contrib/views/storm/src/main/resources/styles/style.css e4f5be2 contrib/views/storm/src/main/resources/view.xml cbcf4ff Diff: https://reviews.apache.org/r/49908/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 48973: AMBARI-17324. kafka should set zookeeper.set.acl to true when kerberos enabled

: https://reviews.apache.org/r/48973/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 48973: AMBARI-17324. kafka should set zookeeper.set.acl to true when kerberos enabled

kerberos enabled Diffs - ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json eaa3d9d Diff: https://reviews.apache.org/r/48973/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

iew140857 --- On June 20, 2016, 10:47 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

> On July 1, 2016, 5:09 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml, > > line 40 > > > > > > Does the parallelism = 1, mean 1 bolt get

Re: Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

/kerberos.json (line 17) <https://reviews.apache.org/r/48973/#comment203897> we shouldn't be doing that. Will let customers know via a tech alert. - Sriharsha Chintalapani On June 20, 2016, 10:47 p.m., Sriharsha Chintal

Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 48735: Storm service check failed after Ambari upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48735/#review137810 --- Ship it! Ship It! - Sriharsha Chintalapani On June 15, 2016

Review Request 48532: AMBARI-17157 Storm 1.0 log4j config update

/src/main/resources/common-services/STORM/1.0.1/configuration/storm-worker-log4j.xml PRE-CREATION Diff: https://reviews.apache.org/r/48532/diff/ Testing --- Installed storm 1.0 using Ambari. Tested if the logs are being written in new format. Thanks, Sriharsha Chintalapani

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

query with wildcards & > series function to aggregate metrics into one and Grafana can show that. > That's what I want to address to AMS. > > Aravindan Vijayan wrote: > Jungtaek, there is also another level of classification called > "instancedId" Every a

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136767 --- Ship it! Ship It! - Sriharsha Chintalapani On June 9, 2016

Re: Review Request 48379: EU - HDP 2.4 to 2.5 fails restarting DRPC server on a kerberized cluster, need to use org.apache.storm.security.auth.KerberosPrincipalToLocal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48379/#review136560 --- Ship it! Ship It! - Sriharsha Chintalapani On June 7, 2016

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

0/#review136411 --- On June 7, 2016, 6:14 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48030/ > -

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48065/#review136402 --- Ship it! Ship It! - Sriharsha Chintalapani On June 3, 2016

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136400 --- Ship it! Ship It! - Sriharsha Chintalapani On May 30, 2016

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a7dbba3 Diff: https://reviews.apache.org/r/47332/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

well and its intentional. - Sriharsha Chintalapani On May 20, 2016, 7:17 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

------- On May 20, 2016, 7:17 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47332/ > -

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a7dbba3 Diff: https://reviews.apache.org/r/47332/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a7dbba3 Diff: https://reviews.apache.org/r/47332/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25

/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

e at 2.5 we dont' need to call this again. - Sriharsha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47332/#review133459 ----

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

a7dbba3 Diff: https://reviews.apache.org/r/47332/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

/storm-site.xml 19d4961 Diff: https://reviews.apache.org/r/47153/diff/ Testing --- Thanks, Sriharsha Chintalapani

Review Request 47153: Storm - When kerberos enabled storm.thrift.transport is being set to wrong config

--- Storm - When kerberos enabled storm.thrift.transport is being set to wrong config Diffs - ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml 19d4961 Diff: https://reviews.apache.org/r/47153/diff/ Testing --- Thanks, Sriharsha

Re: Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

ed e-mail. To reply, visit: https://reviews.apache.org/r/46927/#review131767 --- On May 5, 2016, 12:32 a.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically ge

Re: Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml a296bfa Diff: https://reviews.apache.org/r/46927/diff/ Testing --- Deployed a 3 node cluster and ran sample topologies. Also kerbeorized the cluster. Thanks, Sriharsha Chintalapani

Re: Review Request 46976: AMBARI-16250: Create STORM service versions in common-services

1.0 with Ambari 2.4 that needs to be part of this patch as well. - Sriharsha Chintalapani On May 4, 2016, 11:21 p.m., Jayush Luniya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://review

Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

, Sriharsha Chintalapani

Review Request 46068: Kafka tools-log4j template missing when upgraded

://reviews.apache.org/r/46068/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

-CREATION Diff: https://reviews.apache.org/r/45835/diff/ Testing --- Deployed Storm & Kafka with the above changes and noticed the nofiles and noproc values change. Thanks, Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

/scripts/params.py b18e62d Diff: https://reviews.apache.org/r/45837/diff/ Testing --- Thanks, Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

. To reply, visit: https://reviews.apache.org/r/45837/#review127481 --- On April 6, 2016, 9:12 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatic

Re: Review Request 45835: AMBARI-15635. Storm & Kafka should've default nproc , nofile values.

ff: https://reviews.apache.org/r/45835/diff/ Testing --- Deployed Storm & Kafka with the above changes and noticed the nofiles and noproc values change. Thanks, Sriharsha Chintalapani

Re: Review Request 45837: Kafka jaas files are not generated on a Kafa upgrade if security.inter.broker.protocol is set to SASL_PLAINTEXT

/scripts/params.py b18e62d Diff: https://reviews.apache.org/r/45837/diff/ Testing --- Thanks, Sriharsha Chintalapani