Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

2016-10-21 Thread Venkat Ranganathan
, bundle etc) and some further refactoring (the use of validator etc). Let me review thi a bit more carefully if there are intersections - Venkat Ranganathan On Oct. 21, 2016, 11:28 a.m., Sangeeta Ravindran wrote: > > --- > T

Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory

2016-09-13 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51863/#review148807 --- Ship it! Ship It! - Venkat Ranganathan On Sept. 13, 2016, 2

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-17 Thread Venkat Ranganathan
ld have troubles with customized > users/permissions/non root user. > > Venkat Ranganathan wrote: > Yes. This is only one and it is really not a JDBC driver. We just use > the download mechanism > > Vitalyi Brodetskyi wrote: > Ok, but anyway i think it will be go

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-17 Thread Venkat Ranganathan
il. To reply, visit: https://reviews.apache.org/r/50595/#review144469 ----------- On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generat

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan
file - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51154/#review145917 --- On Aug. 16, 2016, 4:19 p.m., Venkat Ra

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan
Total failures:0 OK Thanks, Venkat Ranganathan

Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan
failures:0 OK Thanks, Venkat Ranganathan

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-16 Thread Venkat Ranganathan
/package/scripts/oozie.py (line 378) <https://reviews.apache.org/r/51121/#comment212258> we need to kinit if needed here - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is a

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-16 Thread Venkat Ranganathan
/package/scripts/oozie.py (line 313) <https://reviews.apache.org/r/51121/#comment212256> Currently we don't support propeties file for action config files. This needs to go to sharelib also - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fern

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-16 Thread Venkat Ranganathan
/package/scripts/oozie.py (line 410) <https://reviews.apache.org/r/51121/#comment212255> We should do this before Oozie is started or you should run the following command oozie admin -oozie -sharelibupdate - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fer

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-16 Thread Venkat Ranganathan
/configuration/hive-site.xml (line 24) <https://reviews.apache.org/r/51121/#comment212231> Why do we need this file? - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is a

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-02 Thread Venkat Ranganathan
To reply, visit: https://reviews.apache.org/r/50595/#review144468 ------- On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote: > > --- > This is an automatical

Re: Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view

2016-08-02 Thread Venkat Ranganathan
://reviews.apache.org/r/50691/diff/ Testing --- All editors were tested and validated with a Oozie server Thanks, Venkat Ranganathan

Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view

2016-08-02 Thread Venkat Ranganathan
Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
eviews.apache.org/r/50595/#review144291 --- On Aug. 1, 2016, 10:38 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > ---

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-08-01 Thread Venkat Ranganathan
names Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
Falcon/Atlas component names Thanks, Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
line 211 > > <https://reviews.apache.org/r/50595/diff/1/?file=1457507#file1457507line211> > > > > Typo. will fix. thanks - Venkat --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan
component names Thanks, Venkat Ranganathan

Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-28 Thread Venkat Ranganathan
/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Venkat Ranganathan
f8ba3e9 Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-26 Thread Venkat Ranganathan
://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-25 Thread Venkat Ranganathan
Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan

Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas

2016-07-25 Thread Venkat Ranganathan
ebe3634 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 315020b Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Venkat Ranganathan
> On July 21, 2016, 8:56 a.m., Venkat Ranganathan wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 331 > > <https://reviews.apache.org/r/50287/diff/1/?file=1449672#file1449672line331> > > > >

Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions

2016-07-21 Thread Venkat Ranganathan
/diff/ Testing --- Validated the config Thanks, Venkat Ranganathan

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-21 Thread Venkat Ranganathan
/services/stack_advisor.py 315020b ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Venkat Ranganathan
/stack_advisor.py (line 331) <https://reviews.apache.org/r/50287/#comment208799> Do we need this. Isn't OOZIE added in HDP21StackAdvisor whose dictionary is merged in succeeding child classes? - Venkat Ranganathan On July 21, 2016, 3:19 a.m., Mugdha Var

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-20 Thread Venkat Ranganathan
/upgrades/FixOozieAdminUsersTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan

Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

2016-07-20 Thread Venkat Ranganathan
/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan

Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

2016-07-19 Thread Venkat Ranganathan
ll create a new bug to track this - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50178/#review142779 ------- On July

Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

2016-07-18 Thread Venkat Ranganathan
: https://reviews.apache.org/r/50178/diff/ Testing --- Implemented the changes in stack_advisor and ran a test to make sure the configuration changes for admin user is forced Thanks, Venkat Ranganathan

Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

2016-06-25 Thread Venkat Ranganathan
eviews.apache.org/r/49222/#review139471 --- On June 24, 2016, 6:27 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon

2016-06-24 Thread Venkat Ranganathan
/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 6cb4089 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/49222/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-23 Thread Venkat Ranganathan
----- On June 23, 2016, 12:05 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48609/ >

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-23 Thread Venkat Ranganathan
ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7499cdf Diff: https://reviews.apache.org/r/48609/diff/ Testing (updated) --- UT passes Thanks, Venkat Ranganathan

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Venkat Ranganathan
, visit: https://reviews.apache.org/r/48609/#review137377 ----------- On June 15, 2016, 10:51 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically gener

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-15 Thread Venkat Ranganathan
/FALCON/package/scripts/falcon.py 9a72af1 ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION Diff: https://reviews.apache.org/r/48609/diff/ Testing --- Thanks, Venkat Ranganathan

Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

2016-06-12 Thread Venkat Ranganathan
/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION Diff: https://reviews.apache.org/r/48609/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
/config-upgrade.xml 60cac05 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat

Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing (updated) --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan

Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5

2016-06-07 Thread Venkat Ranganathan
-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Thanks, Venkat Ranganathan

Re: Review Request 47009: Falcon server start fails

2016-05-11 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47009/#review132824 --- Ship it! Ship It! - Venkat Ranganathan On May 11, 2016, 1

Re: Review Request 47009: Falcon server start fails

2016-05-10 Thread Venkat Ranganathan
> On May 9, 2016, 2:49 p.m., Venkat Ranganathan wrote: > > We have committed a change as part of FALCON-1942 to add a environment variable called FALCON_EXTRA_CLASS_PATH - this will be appended to the Falcon server classpath. Please use it > On May 9, 2016, 2:49 p.m., Venkat

Re: Review Request 47009: Falcon server start fails

2016-05-09 Thread Venkat Ranganathan
/0.5.0.2.1/configuration/falcon-env.xml (line 162) <https://reviews.apache.org/r/47009/#comment196515> Don't we want the server classpath to be changed in falcon-config? - Venkat Ranganathan On May 5, 2016, 5:07 a.m., Tom Beer