Re: Review Request 44265: Basic Operational Audit Logging

> On March 29, 2016, 12:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review126138 --- Ship it! Ship It! - Nate Cole On March 30, 2016, 11:20 a.m.,

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review126137 --- Ship it! Ship It! - Jonathan Hurley On March 30, 2016, 11:20

Re: Review Request 44265: Basic Operational Audit Logging

> On March 29, 2016, 6:33 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 3:20 du) Review request for Ambari, Laszlo Puskas, Oli

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 29, 2016, 4:33 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > line 843 > > > > > > These work with the above cache, but do

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 29, 2016, 4:58 du, Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/audit/AuditLoggerModule.java, > > line 65 > > > > > > Can these be bound by annotation? It would make it easier

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 29, 2016, 4:33 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 134-139 > > > > > > I don't see these being cleared an

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 8, 2016, 5:05 du, Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 801-816 > > > > > > A problem with this approach is tha

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 30, 2016, 12:44 du) Review request for Ambari, Laszlo Puskas, Ol

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review125890 --- ambari-server/src/main/java/org/apache/ambari/server/api/services

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review125892 --- ambari-server/src/main/java/org/apache/ambari/server/actionmanage

Re: Review Request 44265: Basic Operational Audit Logging

Hi, If you have time, please review the latest changes on this issue. Thanks, Daniel On 2016.03.24 13:21, "Daniel Gergely" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/44265/ >

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 24, 2016, 12:20 du) Review request for Ambari, Laszlo Puskas, Ol

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review123422 --- -1 on this. DO NOT PUSH THIS CODE. This should be done in a feat

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 8, 2016, 5:24 du, Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/AllGetCreator.java, > > line 28 > > > > > > Is it possible to have a single configurable implem

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 8, 2016, 7:07 du, Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 489-493 > > > > > > I don't see the need to move this code

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 11, 2016, 2:32 du) Review request for Ambari, Laszlo Puskas, Oli

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review122542 --- I have a lot of concerns about this review. A few items: - Review

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review122536 --- ambari-server/src/main/java/org/apache/ambari/server/api/services

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/#review122532 --- This patch is way too big. It should have been split into multiple

Re: Review Request 44265: Basic Operational Audit Logging

> On márc. 7, 2016, 10:51 de, Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java, > > line 61 > > > > > > I think this shouldn't be static but rather use gu

Re: Review Request 44265: Basic Operational Audit Logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44265/ --- (Updated márc. 8, 2016, 1:36 du) Review request for Ambari, Laszlo Puskas, Oliv