Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124702 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124708 --- Note: To add new patch click on Update>Update Patch and upload the

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/ --- (Updated March 22, 2016, 1:50 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py, > > line 50 > > > > > > We need to define config_dir in

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py, > > line 50 > > > > > > We need to define config_dir in

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/ --- (Updated March 22, 2016, 11:13 p.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Juanjo Marron
> On March 22, 2016, 1:38 a.m., Jayush Luniya wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 32 > > > > > > Use default function instead? > > > >

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124930 --- Thanks @Juanjo Overall looks like. I will validate the patch some

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
> On March 23, 2016, 12:18 a.m., Jayush Luniya wrote: > > Thanks @Juanjo > > > > Overall looks like. I will validate the patch sometime today and commit it. > > Can you also attach the patch to the JIRA and hit "Submit patch" button on > > the Apache JIRA so as to kickoff Hadoop QA build again

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
> On March 23, 2016, 6:34 a.m., Jayush Luniya wrote: > > Ship It! Verified on live cluster - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124969 ---

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124969 --- Ship it! Ship It! - Jayush Luniya On March 22, 2016, 11:13 p

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Jayush Luniya
> On March 23, 2016, 6:34 a.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > Verified on live cluster Committed to trunk. Thanks Juanjo! - Jayush --- This is an automatically generated e-mail. To reply, visit: https