Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134694 --- Ship it! Ship It! - Sumit Mohanty On May 25, 2016, 2:18 a.m.

Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread chen jian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/ --- (Updated 五月 25, 2016, 2:18 a.m.) Review request for Ambari, Alexandr Antonenko,

Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread chen jian
> On 五月 24, 2016, 1:23 p.m., Tom Beerbower wrote: > > The fix looks okay to me. How did you test it? Could you please complete > > the "testing done" section of the review? that's done, thanks. That is my first time commit for Ambari, Could you tell me what to do to close my jira issue. -

Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread chen jian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/ --- (Updated 五月 25, 2016, 12:10 a.m.) Review request for Ambari, Alexandr Antonenko

Re: Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134576 --- Ship it! The fix looks okay to me. How did you test it? Could

Review Request 47773: one very careless mistake for ambari agent cancel logic

2016-05-24 Thread chen jian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/ --- Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom Beerbow