Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162492 --- Pushed to trunk, commit 83cf094b570731920781192db4f4586a3056e382 b

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 19, 2017, 11:49 p.m., Alejandro Fernandez wrote: > > Ship It! Thank you Alejandro, I don't have commit rights on trunk. Could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To r

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162365 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 19, 2017, 6:

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 19, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml, > > line 75 > > > > > > This is also needed in ZK 3.4.9

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162335 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
> On Jan. 18, 2017, 7:05 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml, > > line 238 > > > > > > This annotation is missing in HDFS

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-19 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- (Updated Jan. 19, 2017, 6:16 p.m.) Review request for Ambari, Di Li, Jaimin Jet

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162157 --- ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/c

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-18 Thread Amruta Borkar
> On Jan. 17, 2017, 2:15 p.m., Robert Levas wrote: > > Ship It! Thank you. - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review161866 ---

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-18 Thread Amruta Borkar
> On Jan. 18, 2017, 6:02 p.m., Di Li wrote: > > Ship It! Thank you Di, could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review16214

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-18 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review162146 --- Ship it! Ship It! - Di Li On Jan. 12, 2017, 12:33 a.m., Amru

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review161866 --- Ship it! Ship It! - Robert Levas On Jan. 11, 2017, 7:33 p.m.

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-16 Thread Amruta Borkar
> On Oct. 31, 2016, 4:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > ''' >

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-11 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- (Updated Jan. 12, 2017, 12:33 a.m.) Review request for Ambari, Di Li, Jaimin Je

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-11 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review161291 --- Ship it! Ship It! - Jaimin Jetly On Nov. 9, 2016, 12:11 a.m.

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-10 Thread Amruta Borkar
> On Oct. 31, 2016, 4:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > ''' >

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-08 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- (Updated Nov. 9, 2016, 12:11 a.m.) Review request for Ambari, Di Li, Jaimin Jet

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-08 Thread Amruta Borkar
> On Oct. 31, 2016, 3:31 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 2993 > > > > > > Are we sure that a

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-08 Thread Amruta Borkar
> On Oct. 31, 2016, 4:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > ''' >

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-02 Thread Robert Levas
> On Oct. 31, 2016, 12:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > '''

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-11-01 Thread Amruta Borkar
> On Oct. 31, 2016, 4:27 p.m., Robert Levas wrote: > > This seems dangerous. > > > > I think it would be a better option to make this explicit by using a > > configuration attribute. For example: > > > > ''' > > > > ... > > kerberos_principal > > ... > > > > ''' >

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-10-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154278 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 28, 2016, 5:

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-10-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154274 --- This seems dangerous. I think it would be a better option to ma

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-10-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154268 --- Just a comment/question below about the filtering used here. I co

Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2016-10-26 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- Review request for Ambari, Robert Levas and Robert Nettleton. Bugs: AMBARI-1869