Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154151 --- Ship it! Nice! :) - Robert Levas On Oct. 28, 2016, 12:58 p.m

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154146 --- Ship it! Ship It! - Nate Cole On Oct. 28, 2016, 12:58 p.m.,

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154144 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 28, 2016, 4:

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 12:58 p.m.) Review request for Ambari, Nate Cole and Ro

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 12:52 p.m.) Review request for Ambari, Nate Cole and Ro

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 11:29 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 72-77 > > > > > > I wonder if there would ever be a need to d

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 11:29 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/upgrade-pack.xsd, line 77 > > > > > > Shouldn't this be of type `security-type` from the definition above? Yes it should :) ...

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154131 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 10:18 a.m.) Review request for Ambari, Nate Cole and Ro

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/upgrade-pack.xsd, line 147 > > > > > > Java side doesn't allow for more than one task per execute-stage. Nice catch! > On Oct. 2

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154120 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154097 --- ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolli

Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18726 h