Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

> On Dec. 7, 2016, 10:25 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingCookieStore.java, > > line 31 > > > > > > I'm a little concerned that this

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/#review158531 --- Ship it! Ship It! - Robert Nettleton On Dec. 8, 2016, 11:03

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/ --- (Updated Dec. 8, 2016, 11:03 a.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/ --- (Updated Dec. 7, 2016, 11 p.m.) Review request for Ambari, Miklos Gergely and

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

> On Dec. 7, 2016, 10:25 p.m., Robert Nettleton wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java, > > line 151 > > > > > > The fact that this is a

Re: Review Request 54339: Cookie management for Ambari LogSearch Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54339/#review158420 --- Fix it, then Ship it! Overall, the patch looks fine to me.