Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/ --- Review request for Ambari, Jonathan Hurley, Miklos Gergely, Oliver Szabo, and Su

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159294 --- Ship it! Ship It! - Miklos Gergely On Dec. 14, 2016, 8:08 p.

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159298 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Robert Nettleton
> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > Hi Jonathan, thanks for the review comments. > On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > lines 5086-5090 > >

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Jonathan Hurley
> On Dec. 15, 2016, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Robert Nettleton
> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Jonathan Hurley
> On Dec. 15, 2016, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/ --- (Updated Dec. 15, 2016, 7:54 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Robert Nettleton
> On Dec. 15, 2016, 3:04 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java, > > lines 73-74 > > > > > > This is a little odd;

Re: Review Request 54756: Adding configurable timeouts to Ambari LogSearch Integration

2016-12-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54756/#review159369 --- Ship it! Ship It! - Jonathan Hurley On Dec. 15, 2016, 2:54 p